Ubuntu
unity8 package

Unity8 can't correctly display multi-surface apps (i.e. menus and tooltips)

Bug #1543467 reported by Daniel van Vugt
74
This bug affects 10 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Nick Dedekind
Canonical System Image x1 "xenial bringup"
qtmir (Ubuntu)
Fix Released
High
Daniel d'Andrada
qtubuntu (Ubuntu)
Fix Released
Undecided
Gerry Boland
unity8 (Ubuntu)
Fix Released
High
Daniel d'Andrada

Bug Description

Unity8 can't display multi-surface apps (including menus and tooltips).

Fixing bug 1497085 was a great start. However instead of crashing Unity8 now just shows the most recently created window by the app in the apps /single window/, and stretches it too. When such a secondary window like a menu or tooltip closes, you never get back to the original app window. So existing apps still aren't quite usable yet.

Test case:
sudo apt-get install mir-demos
mir_demo_client_multiwin -- --desktop_file_hint=unity8

Expected: Three windows (red, green, blue)
Observed: Only the blue window

You can also experience the same bug with lots of apps via: Xmir -rootless under Unity8.

See original description

Related branches

lp://qastaging/~dandrader/unity8/childWindows
Gerry Boland (community): Approve
Unity8 CI Bot: Needs Fixing (continuous-integration)
Michael Zanetti: Pending requested
Lukáš Tinkl: Pending requested
Nick Dedekind: Pending requested
Diff: 1464 lines (+726/-108)
31 files modified
CMakeLists.txt (+1/-1)
debian/control (+3/-3)
plugins/WindowManager/TopLevelWindowModel.cpp (+36/-28)
plugins/WindowManager/TopLevelWindowModel.h (+2/-0)
plugins/WindowManager/Window.h (+0/-1)
qml/Components/WindowControlButtons.qml (+2/-0)
qml/Stage/ChildWindow.qml (+159/-0)
qml/Stage/ChildWindowRepeater.qml (+28/-0)
qml/Stage/ChildWindowTree.qml (+127/-0)
qml/Stage/DecoratedWindow.qml (+1/-2)
qml/Stage/MoveHandler.qml (+23/-18)
qml/Stage/Stage.qml (+50/-9)
qml/Stage/WindowControlsOverlay.qml (+21/-24)
qml/Stage/WindowDecoration.qml (+1/-0)
qml/Stage/WindowResizeArea.qml (+3/-2)
tests/mocks/Unity/Application/ApplicationInfo.cpp (+9/-1)
tests/mocks/Unity/Application/ApplicationInfo.h (+3/-0)
tests/mocks/Unity/Application/ApplicationManager.cpp (+9/-0)
tests/mocks/Unity/Application/MirSurface.cpp (+43/-0)
tests/mocks/Unity/Application/MirSurface.h (+11/-0)
tests/mocks/Unity/Application/MirSurfaceItem.cpp (+19/-4)
tests/mocks/Unity/Application/MirSurfaceListModel.h (+0/-1)
tests/mocks/Unity/Application/SurfaceManager.cpp (+15/-8)
tests/mocks/Unity/Application/SurfaceManager.h (+3/-1)
tests/mocks/Unity/Application/VirtualKeyboard.cpp (+5/-4)
tests/mocks/Unity/Application/resources/Kate.qml (+49/-0)
tests/mocks/Unity/Application/resources/KateDialog.qml (+48/-0)
tests/mocks/Unity/Application/resources/KateMenu.qml (+41/-0)
tests/mocks/Unity/Application/resources/surfaces.qrc (+3/-0)
tests/qmltests/Stage/ApplicationCheckBox.qml (+1/-1)
tests/qmltests/Stage/tst_WindowResizeArea.qml (+10/-0)
lp://qastaging/~gerboland/qtubuntu/add--more-surface-type-support
Nick Dedekind (community): Approve
Unity8 CI Bot: Approve (continuous-integration)
Lukáš Tinkl (community): Needs Information
Diff: 535 lines (+264/-155)
2 files modified
src/ubuntumirclient/input.cpp (+2/-0)
src/ubuntumirclient/window.cpp (+262/-155)
Michał Sawicz (saviq)
Changed in qtmir:
status: New → Triaged
Changed in qtmir (Ubuntu):
status: New → Triaged
Changed in unity8 (Ubuntu):
status: New → Triaged
Changed in qtmir:
importance: Undecided → High
Changed in qtmir (Ubuntu):
importance: Undecided → High
Changed in unity8 (Ubuntu):
importance: Undecided → High
Changed in qtmir:
assignee: nobody → Daniel d'Andrada (dandrader)
Changed in qtmir (Ubuntu):
assignee: nobody → Daniel d'Andrada (dandrader)
Changed in unity8 (Ubuntu):
assignee: nobody → Daniel d'Andrada (dandrader)
Changed in qtmir:
status: Triaged → In Progress
Changed in qtmir (Ubuntu):
status: Triaged → In Progress
Changed in unity8 (Ubuntu):
status: Triaged → In Progress
Daniel van Vugt (vanvugt)
tags: added: xmir
Daniel van Vugt (vanvugt)
description: updated
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Still in progress?

This bug is the biggest blocker for using Xmir -rootless in Unity8.

summary: - Unity8 can't display multi-window apps (or menus/tooltips)
+ Unity8 can't display multi-surface apps (or menus/tooltips)
summary: - Unity8 can't display multi-surface apps (or menus/tooltips)
+ Unity8 can't display multi-surface apps (including menus and tooltips)
description: updated
Revision history for this message
Daniel d'Andrada (dandrader) wrote : Re: Unity8 can't display multi-surface apps (including menus and tooltips)

No, it's fixed already.

Released in unity8 8.12+16.04.20160421.1-0ubuntu1 (in xenial, vivid version number likely differs a bit)

Changed in qtmir:
status: In Progress → Fix Released
Changed in qtmir (Ubuntu):
status: In Progress → Fix Released
Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

By the way, there's no support yet for menus and tooltips. They will be shown as regular top-level windows at the moment.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I tested xenial with 8.12+16.04.20160401-0ubuntu1 yesterday. It doesn't work. As you say in comment #3, smaller surfaces like menus and tooltips don't work - they take over the whole app window rendering the app unusable.

Changed in qtmir:
status: Fix Released → Triaged
Changed in qtmir (Ubuntu):
status: Fix Released → Triaged
Changed in unity8 (Ubuntu):
status: Fix Released → Triaged
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Re: Unity8 can't correctly display multi-surface apps (including menus and tooltips)

Even without menus and tooltips, try this test case which should open three different coloured windows:

mir_demo_client_multiwin -- --desktop_file_hint=unity8

summary: - Unity8 can't display multi-surface apps (including menus and tooltips)
+ Unity8 can't correctly display multi-surface apps (including menus and
+ tooltips)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

8.12+16.04.20160401-0ubuntu1 is too old. It's older than the release I mentioned.

Changed in qtmir:
status: Triaged → Fix Released
Changed in qtmir (Ubuntu):
status: Triaged → Fix Released
Changed in unity8 (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

To get the latest release in Xenial you need this:

"""
deb http://ppa.launchpad.net/ci-train-ppa-service/stable-phone-overlay/ubuntu xenial main
deb-src http://ppa.launchpad.net/ci-train-ppa-service/stable-phone-overlay/ubuntu xenial main
"""

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I will retest but FYI your usage of the Launchpad status 'Fix Released' is incorrect.

Fix Released on the Ubuntu task means the fix is in one of these:
   https://launchpad.net/ubuntu/+source/unity8
which it is not.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sorry, that PPA killed my machine: bug 1578461 and bug 1578462

Can we make the qtmir and unity8 tasks Fix Committed instead? At least till the fixes reach the Ubuntu distro?

Daniel d'Andrada (dandrader)
Changed in qtmir (Ubuntu):
status: Fix Released → Fix Committed
Changed in unity8 (Ubuntu):
status: Fix Released → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I got the PPA working today: ppa:ci-train-ppa-service/stable-phone-overlay

Confirmed Unity8 can now multi-window apps, but menus and tooltips are still unbearable. They all open as large full-size app windows eclipsing the app they came from.

Test case: Xmir :0 -rootless --desktop_file_hint=unity8 -sw

Changed in qtmir:
status: Fix Released → Triaged
Changed in qtmir (Ubuntu):
status: Fix Committed → Triaged
Changed in unity8 (Ubuntu):
status: Fix Committed → Triaged
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Similarly broken are native GTK apps which have menus and tooltips:

gedit -- --desktop_file_hint=unity8
sol -- --desktop_file_hint=unity8

Daniel d'Andrada (dandrader)
Changed in qtmir:
assignee: Daniel d'Andrada (dandrader) → nobody
Changed in qtmir (Ubuntu):
assignee: Daniel d'Andrada (dandrader) → nobody
Changed in unity8 (Ubuntu):
assignee: Daniel d'Andrada (dandrader) → nobody
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

I see little value in such a comprehensive bug, covering multiple topics. Supporting multiple top-level windows is a different task from supporting menus and tooltips. I think menus deserve a bug report of their own. Specially since what's written in the bug description is just about multiple top-level windows.

Could you then at least include information (test case, steps to reproduce) on menus and tooltips on that report?

Assigning this bug now to dednick as he's the one working on menus (you known, it's a whole different task).

Changed in qtmir:
assignee: nobody → Nick Dedekind (nick-dedekind)
Changed in qtmir (Ubuntu):
assignee: nobody → Nick Dedekind (nick-dedekind)
Changed in unity8 (Ubuntu):
assignee: nobody → Nick Dedekind (nick-dedekind)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

That's a reasonable argument, however this bug was also about menus and tooltips right from the beginning on 9 February.

Daniel van Vugt (vanvugt)
tags: added: visual-quality
Revision history for this message
Will Cooke (willcooke) wrote : Automatically added comment

Added to Trello: https://trello.com/c/4LyAuicB/13-bug-1543467-unity8-can-t-correctly-display-multi-surface-apps-including-menus-and-tooltips

tags: added: desktop-trello-import
tags: removed: desktop-trello-import
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Re: Unity8 can't correctly display multi-surface apps (including menus and tooltips)

We're copying bugs into Trello now?!

Daniel van Vugt (vanvugt)
summary: - Unity8 can't correctly display multi-surface apps (including menus and
+ Unity8 can't correctly display multi-surface apps (i.e. menus and
tooltips)
Revision history for this message
dinamic (dinamic6661) wrote :

this bug is critical to me, it makes apps unusable and hard to test on unity8-desktop

kevin gunn (kgunn72)
tags: added: unity8-desktop
Revision history for this message
Emanuele Antonio Faraone (emanueleant03) wrote :

@dinamic +1

Revision history for this message
Emanuele Antonio Faraone (emanueleant03) wrote :

Any information?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I was wondering myself. I'm sure the Unity8 guys will get to this soon.

tags: removed: xmir
Daniel van Vugt (vanvugt)
Changed in canonical-devices-system-image:
importance: Undecided → High
status: New → Triaged
milestone: none → 14
Daniel van Vugt (vanvugt)
Changed in canonical-devices-system-image:
assignee: nobody → Nick Dedekind (nick-dedekind)
Revision history for this message
kevin gunn (kgunn72) wrote :

wondering is bug 1542029 a duplicate of this one? if so please dup it

Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: 14 → x1
Revision history for this message
Emanuele Antonio Faraone (emanueleant03) wrote :

Any news?

Daniel d'Andrada (dandrader)
Changed in qtubuntu:
status: New → In Progress
assignee: nobody → Gerry Boland (gerboland)
Changed in unity8 (Ubuntu):
assignee: Nick Dedekind (nick-dedekind) → Daniel d'Andrada (dandrader)
Changed in qtmir (Ubuntu):
assignee: Nick Dedekind (nick-dedekind) → Daniel d'Andrada (dandrader)
Lukáš Tinkl (lukas-kde)
Changed in unity8 (Ubuntu):
status: Triaged → In Progress
Daniel van Vugt (vanvugt)
tags: added: resizing
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.15+17.04.20170206-0ubuntu1

---------------
unity8 (8.15+17.04.20170206-0ubuntu1) zesty; urgency=medium

  [ Daniel d'Andrada ]
  * Initial support for child windows (menus, dialogs, tooltips) (LP:
    #1543467, #1591384, #1656727)

 -- Albert Astals Cid <email address hidden> Mon, 06 Feb 2017 09:12:23 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Daniel d'Andrada (dandrader)
Changed in qtmir (Ubuntu):
status: Triaged → Fix Released
no longer affects: qtmir
Changed in qtubuntu:
status: In Progress → Fix Released
kevin gunn (kgunn72)
Changed in canonical-devices-system-image:
status: Triaged → Fix Released
Michał Sawicz (saviq)
affects: qtubuntu → qtubuntu (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.