Open new tabs next to the tab that launched them
Bug #1499780 reported by
Michael Terry
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Florian Boucault | ||
Bug Description
When clicking on a target="_blank" link or Ctrl-clicking on a link, a new tab opens. But it always opens at the end of the list of current tabs.
Ideally it would open next to the tab that launched it. Other browsers do this, and it helps to keep related content near each other. And makes it faster to switch to the new tab if you want to (one press of Ctrl+Tab instead of many).
Related branches
lp://qastaging/~fboucault/webbrowser-app/background_open_tabs_adjacent
- Olivier Tilloy: Approve
-
Diff: 255 lines (+96/-15)7 files modifiedsrc/app/webbrowser/TabComponent.qml (+14/-11)
src/app/webbrowser/tabs-model.cpp (+9/-0)
src/app/webbrowser/tabs-model.h (+1/-0)
tests/autopilot/webbrowser_app/tests/__init__.py (+9/-0)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+30/-4)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+20/-0)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+13/-0)
- Olivier Tilloy: Needs Fixing
-
Diff: 385 lines (+134/-80)12 files modified.bzrignore (+0/-1)
CMakeLists.txt (+1/-2)
make-snap.sh (+0/-4)
setup/gui/webbrowser-app.desktop.in (+0/-27)
snapcraft.yaml (+4/-1)
src/Ubuntu/Web/ua-overrides-desktop.js.in (+43/-24)
src/Ubuntu/Web/ua-overrides-mobile.js.in (+36/-14)
src/app/webbrowser/TabComponent.qml (+6/-7)
src/app/webbrowser/tabs-model.cpp (+9/-0)
src/app/webbrowser/tabs-model.h (+1/-0)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+22/-0)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+12/-0)
lp://qastaging/webbrowser-app/staging
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 2840 lines (+1499/-148)63 files modified.bzrignore (+0/-2)
debian/control (+7/-2)
debian/rules (+1/-1)
snapcraft.yaml (+8/-16)
src/Ubuntu/Web/ua-overrides-desktop.js.in (+9/-0)
src/Ubuntu/Web/ua-overrides-mobile.js.in (+3/-0)
src/app/ChromeBase.qml (+1/-0)
src/app/webbrowser/Browser.qml (+158/-29)
src/app/webbrowser/BrowserTab.qml (+19/-2)
src/app/webbrowser/CMakeLists.txt (+2/-0)
src/app/webbrowser/Chrome.qml (+12/-2)
src/app/webbrowser/ContextMenuMobile.qml (+10/-2)
src/app/webbrowser/Suggestions.qml (+1/-1)
src/app/webbrowser/TabComponent.qml (+33/-15)
src/app/webbrowser/TabItem.qml (+2/-2)
src/app/webbrowser/TabsBar.qml (+112/-15)
src/app/webbrowser/TabsList.qml (+2/-2)
src/app/webbrowser/drag-helper.cpp (+203/-0)
src/app/webbrowser/drag-helper.h (+91/-0)
src/app/webbrowser/reparenter.cpp (+124/-0)
src/app/webbrowser/reparenter.h (+46/-0)
src/app/webbrowser/webbrowser-app.cpp (+6/-0)
src/app/webbrowser/webbrowser-app.qml (+33/-3)
src/app/webcontainer/ContextMenuMobile.qml (+10/-2)
src/app/webcontainer/WebappWebview.qml (+5/-4)
tests/autopilot/webbrowser_app/emulators/browser.py (+7/-1)
tests/autopilot/webbrowser_app/tests/__init__.py (+40/-7)
tests/autopilot/webbrowser_app/tests/test_downloads.py (+62/-10)
tests/autopilot/webbrowser_app/tests/test_history.py (+30/-4)
tests/autopilot/webbrowser_app/tests/test_multiple_windows.py (+222/-0)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+10/-0)
tests/unittests/bookmarks-folder-model/CMakeLists.txt (+1/-1)
tests/unittests/bookmarks-folderlist-model/CMakeLists.txt (+1/-1)
tests/unittests/bookmarks-model/CMakeLists.txt (+1/-1)
tests/unittests/container-url-patterns/CMakeLists.txt (+1/-1)
tests/unittests/cookie-store/CMakeLists.txt (+1/-1)
tests/unittests/domain-utils/CMakeLists.txt (+1/-1)
tests/unittests/downloads-model/CMakeLists.txt (+1/-1)
tests/unittests/favicon-fetcher/CMakeLists.txt (+1/-1)
tests/unittests/history-domain-model/CMakeLists.txt (+1/-1)
tests/unittests/history-domainlist-model/CMakeLists.txt (+1/-1)
tests/unittests/history-lastvisitdatelist-model/CMakeLists.txt (+1/-1)
tests/unittests/history-model/CMakeLists.txt (+1/-1)
tests/unittests/intent-filter/CMakeLists.txt (+1/-1)
tests/unittests/limit-proxy-model/CMakeLists.txt (+1/-1)
tests/unittests/meminfo/CMakeLists.txt (+1/-1)
tests/unittests/oxide-cookie-helper/CMakeLists.txt (+1/-1)
tests/unittests/qml/CMakeLists.txt (+2/-0)
tests/unittests/qml/ReparenterFakeContainer.qml (+40/-0)
tests/unittests/qml/ReparenterFakeTab.qml (+37/-0)
tests/unittests/qml/tst_BrowserTab.qml (+3/-2)
tests/unittests/qml/tst_QmlTests.cpp (+7/-0)
tests/unittests/qml/tst_Reparenter.qml (+114/-0)
tests/unittests/qml/tst_TabsBar.qml (+2/-0)
tests/unittests/qml/tst_UbuntuWebView02.qml (+1/-0)
tests/unittests/search-engine/CMakeLists.txt (+1/-1)
tests/unittests/session-storage/CMakeLists.txt (+1/-1)
tests/unittests/session-utils/CMakeLists.txt (+1/-1)
tests/unittests/single-instance-manager/CMakeLists.txt (+1/-1)
tests/unittests/tabs-model/CMakeLists.txt (+1/-1)
tests/unittests/text-search-filter-model/CMakeLists.txt (+1/-1)
tests/unittests/webapp-container-color-helper/CMakeLists.txt (+1/-1)
tests/unittests/webapp-container-hook/CMakeLists.txt (+1/-1)
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Florian Boucault (fboucault) |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This branch introduces changes to the tabs model that will make it easy to implement the requested feature: https:/