Ubuntu
webbrowser-app package

Not requesting desktop content when connected to monitor

Bug #1534682 reported by Bill Filler
40
This bug affects 8 people
Affects Status Importance Assigned to Milestone
Canonical Pocket Desktop
In Progress
High
Michał Sawicz
Canonical System Image
In Progress
High
Michał Sawicz
Canonical System Image backlog
qtubuntu (Ubuntu)
Fix Released
High
Gerry Boland
webbrowser-app (Ubuntu)
Invalid
High
Olivier Tilloy

Bug Description

The ua string is supposed to change based on screensize and other hueristics, but this is not happening. Getting mobile ua string always, even when connected to monitor via slimport

using this build:
(r112) ubuntu-device-flash touch --channel=ubuntu-touch/rc-proposed/ubuntu-pd

Not seeing any messages in the browser log when I plug/unplug the monitor

Tags: convergence

Related branches

lp://qastaging/~unity-team/qtubuntu/screen-info
On hold for merging into lp://qastaging/qtubuntu
Unity8 CI Bot: Approve (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 1696 lines (+777/-270)
15 files modified
src/ubuntumirclient/backingstore.cpp (+11/-5)
src/ubuntumirclient/input.cpp (+101/-53)
src/ubuntumirclient/input.h (+2/-0)
src/ubuntumirclient/integration.cpp (+51/-14)
src/ubuntumirclient/integration.h (+12/-3)
src/ubuntumirclient/nativeinterface.cpp (+55/-3)
src/ubuntumirclient/nativeinterface.h (+11/-1)
src/ubuntumirclient/screen.cpp (+100/-62)
src/ubuntumirclient/screen.h (+26/-4)
src/ubuntumirclient/screenobserver.cpp (+131/-0)
src/ubuntumirclient/screenobserver.h (+54/-0)
src/ubuntumirclient/ubuntumirclient.pro (+4/-1)
src/ubuntumirclient/utils.h (+29/-0)
src/ubuntumirclient/window.cpp (+172/-118)
src/ubuntumirclient/window.h (+18/-6)
lp://qastaging/~unity-team/qtubuntu/screen-info-without-dpr
Unity8 CI Bot: Approve (continuous-integration)
Daniel d'Andrada (community): Approve
Gerry Boland (community): Approve
Nick Dedekind (community): Approve
Diff: 1849 lines (+874/-341)
15 files modified
src/ubuntumirclient/glcontext.cpp (+141/-32)
src/ubuntumirclient/glcontext.h (+9/-7)
src/ubuntumirclient/input.cpp (+103/-52)
src/ubuntumirclient/input.h (+3/-1)
src/ubuntumirclient/integration.cpp (+81/-19)
src/ubuntumirclient/integration.h (+33/-7)
src/ubuntumirclient/nativeinterface.cpp (+61/-14)
src/ubuntumirclient/nativeinterface.h (+16/-5)
src/ubuntumirclient/screen.cpp (+113/-150)
src/ubuntumirclient/screen.h (+26/-15)
src/ubuntumirclient/screenobserver.cpp (+137/-0)
src/ubuntumirclient/screenobserver.h (+54/-0)
src/ubuntumirclient/ubuntumirclient.pro (+2/-0)
src/ubuntumirclient/window.cpp (+74/-31)
src/ubuntumirclient/window.h (+21/-8)
Bill Filler (bfiller)
Changed in canonical-devices-system-image:
milestone: none → ww04-2016
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → High
Changed in webbrowser-app (Ubuntu):
importance: Undecided → High
Changed in canonical-pocket-desktop:
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → High
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
Olivier Tilloy (osomon)
tags: added: convergence
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: New → Confirmed
Revision history for this message
Gerry Boland (gerboland) wrote :

Qt not being told the screen changed. Qtubuntu work

Changed in qtubuntu (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Gerry Boland (gerboland)
Revision history for this message
Kugi Eusebio (kugi-igi) wrote :

Isn't this the same as https://bugs.launchpad.net/bugs/1504084 ?
I see that it was fixed already but I assume it hasn't landed yet on vivid channels since the package mentioned was for Xenial.

Revision history for this message
Olivier Tilloy (osomon) wrote :

No, it’s a slightly different issue: bug #1504084 was an issue in the browser app, this bug is in qtubuntu.

Changed in webbrowser-app (Ubuntu):
status: New → Invalid
Bill Filler (bfiller)
Changed in canonical-pocket-desktop:
assignee: Bill Filler (bfiller) → Michał Sawicz (saviq)
Changed in canonical-devices-system-image:
assignee: Bill Filler (bfiller) → Michał Sawicz (saviq)
Pat McGowan (pat-mcgowan)
no longer affects: canonical-devices-system-image
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
assignee: nobody → Michał Sawicz (saviq)
importance: Undecided → High
milestone: none → ww08-2016
status: New → Confirmed
Michał Sawicz (saviq)
Changed in canonical-devices-system-image:
status: Confirmed → Triaged
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww08-2016 → ww04-2016
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww04-2016 → ww08-2016
Revision history for this message
Gerry Boland (gerboland) wrote :

I've attached the QtUbuntu branch which
1. correctly updates applications of the screen their window is on, so the Screen information is correct
2. has getters and notifiers for these properties: scale & form factor

This branch relies on a QtMir branch to function correctly. All in progress

Changed in qtubuntu (Ubuntu):
status: Confirmed → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-pocket-desktop:
status: New → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Triaged → In Progress
Michał Sawicz (saviq)
Changed in canonical-devices-system-image:
milestone: ww08-2016 → backlog
Revision history for this message
Olivier Tilloy (osomon) wrote :

Any update on this?

Revision history for this message
Gerry Boland (gerboland) wrote :

Yep, as of now, you can fetch the shell mode by using the QPlatformNativeInterface::windowProperty api to fetch a "formFactor" property which will return an enum (look in mir for the enum interpretation) indicating what mode the shell is in. Connect to windowPropertyChanged for signal on change.

This is an intermediary means of accessing this info, and it is clunky. The UITK needs to grow a proper API for this. Lemme know if you need a hand.

Changed in qtubuntu (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Olivier Tilloy (osomon) wrote :

@Gerry: I’m aware of that new API to get the "formFactor" value, but I was referring to the original issue of the window’s screen property not being updated, see the first comment (the browser relies on the size of the current screen to decide whether to advertise a desktop or a mobile UA string). Is that fixed?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.