Ubuntu
webbrowser-app package

Reload shortcut is redundant and ambiguous

Bug #1593877 reported by Alexandre Abreu
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
webbrowser-app (Ubuntu)
Fix Released
Medium
Alexandre Abreu

Bug Description

While researching why

https://code.launchpad.net/~santoshbit2007/webbrowser-app/webcontainer_shortcut_fix/+merge/297355

wasn't working for me I found that there is an inconsistency and confusion apparently in the Reload shortcuts in this branch and in the current webbrowser.

For a given shortcut,

StandardKey.Refresh

as seen here:

http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/Browser.qml#L2086

actually is platform dependant, and could refer to either F5, F5 AND Ctrl+r or Ctrl+r,

When running the webbrowser-app tests or the tests for the webapp-container branch above besides failing for me, they also report ambiguous events (ambiguous in the sense of http://doc.qt.io/qt-5/qshortcutevent.html#QShortcutEvent) which means that there is an overloaded shortcut. And there is since StandardKey.Refresh is redundant with F5 on my setup (Ubuntu 16.04 with canadian keyboard),

Check for the Refresh keyboard shortcut there

http://doc.qt.io/qt-5/qkeysequence.html#standard-shortcuts

See original description

Related branches

lp://qastaging/~abreu-alexandre/webbrowser-app/browser-keyboard-refresh-shortcut
Olivier Tilloy: Approve
system-apps-ci-bot: Approve (continuous-integration)
Diff: 12 lines (+1/-1)
1 file modified
src/app/webbrowser/Browser.qml (+1/-1)
lp://qastaging/webbrowser-app/staging
system-apps-ci-bot: Needs Fixing (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 2840 lines (+1499/-148)
63 files modified
.bzrignore (+0/-2)
debian/control (+7/-2)
debian/rules (+1/-1)
snapcraft.yaml (+8/-16)
src/Ubuntu/Web/ua-overrides-desktop.js.in (+9/-0)
src/Ubuntu/Web/ua-overrides-mobile.js.in (+3/-0)
src/app/ChromeBase.qml (+1/-0)
src/app/webbrowser/Browser.qml (+158/-29)
src/app/webbrowser/BrowserTab.qml (+19/-2)
src/app/webbrowser/CMakeLists.txt (+2/-0)
src/app/webbrowser/Chrome.qml (+12/-2)
src/app/webbrowser/ContextMenuMobile.qml (+10/-2)
src/app/webbrowser/Suggestions.qml (+1/-1)
src/app/webbrowser/TabComponent.qml (+33/-15)
src/app/webbrowser/TabItem.qml (+2/-2)
src/app/webbrowser/TabsBar.qml (+112/-15)
src/app/webbrowser/TabsList.qml (+2/-2)
src/app/webbrowser/drag-helper.cpp (+203/-0)
src/app/webbrowser/drag-helper.h (+91/-0)
src/app/webbrowser/reparenter.cpp (+124/-0)
src/app/webbrowser/reparenter.h (+46/-0)
src/app/webbrowser/webbrowser-app.cpp (+6/-0)
src/app/webbrowser/webbrowser-app.qml (+33/-3)
src/app/webcontainer/ContextMenuMobile.qml (+10/-2)
src/app/webcontainer/WebappWebview.qml (+5/-4)
tests/autopilot/webbrowser_app/emulators/browser.py (+7/-1)
tests/autopilot/webbrowser_app/tests/__init__.py (+40/-7)
tests/autopilot/webbrowser_app/tests/test_downloads.py (+62/-10)
tests/autopilot/webbrowser_app/tests/test_history.py (+30/-4)
tests/autopilot/webbrowser_app/tests/test_multiple_windows.py (+222/-0)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+10/-0)
tests/unittests/bookmarks-folder-model/CMakeLists.txt (+1/-1)
tests/unittests/bookmarks-folderlist-model/CMakeLists.txt (+1/-1)
tests/unittests/bookmarks-model/CMakeLists.txt (+1/-1)
tests/unittests/container-url-patterns/CMakeLists.txt (+1/-1)
tests/unittests/cookie-store/CMakeLists.txt (+1/-1)
tests/unittests/domain-utils/CMakeLists.txt (+1/-1)
tests/unittests/downloads-model/CMakeLists.txt (+1/-1)
tests/unittests/favicon-fetcher/CMakeLists.txt (+1/-1)
tests/unittests/history-domain-model/CMakeLists.txt (+1/-1)
tests/unittests/history-domainlist-model/CMakeLists.txt (+1/-1)
tests/unittests/history-lastvisitdatelist-model/CMakeLists.txt (+1/-1)
tests/unittests/history-model/CMakeLists.txt (+1/-1)
tests/unittests/intent-filter/CMakeLists.txt (+1/-1)
tests/unittests/limit-proxy-model/CMakeLists.txt (+1/-1)
tests/unittests/meminfo/CMakeLists.txt (+1/-1)
tests/unittests/oxide-cookie-helper/CMakeLists.txt (+1/-1)
tests/unittests/qml/CMakeLists.txt (+2/-0)
tests/unittests/qml/ReparenterFakeContainer.qml (+40/-0)
tests/unittests/qml/ReparenterFakeTab.qml (+37/-0)
tests/unittests/qml/tst_BrowserTab.qml (+3/-2)
tests/unittests/qml/tst_QmlTests.cpp (+7/-0)
tests/unittests/qml/tst_Reparenter.qml (+114/-0)
tests/unittests/qml/tst_TabsBar.qml (+2/-0)
tests/unittests/qml/tst_UbuntuWebView02.qml (+1/-0)
tests/unittests/search-engine/CMakeLists.txt (+1/-1)
tests/unittests/session-storage/CMakeLists.txt (+1/-1)
tests/unittests/session-utils/CMakeLists.txt (+1/-1)
tests/unittests/single-instance-manager/CMakeLists.txt (+1/-1)
tests/unittests/tabs-model/CMakeLists.txt (+1/-1)
tests/unittests/text-search-filter-model/CMakeLists.txt (+1/-1)
tests/unittests/webapp-container-color-helper/CMakeLists.txt (+1/-1)
tests/unittests/webapp-container-hook/CMakeLists.txt (+1/-1)
lp://qastaging/~ci-train-bot/webbrowser-app/webbrowser-app-ubuntu-zesty-2504
Alexandre Abreu (abreu-alexandre)
description: updated
Revision history for this message
Olivier Tilloy (osomon) wrote :

I couldn’t observe the issue when running webbrowser-app on unity7, but I got hit by it on unity8 (reported by Bill as bug #1661690). I’ve verified that the proposed change fixes the issue indeed. Thanks!

Changed in webbrowser-app (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Alexandre Abreu (abreu-alexandre)
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+17.04.20170310-0ubuntu1

---------------
webbrowser-app (0.23+17.04.20170310-0ubuntu1) zesty; urgency=medium

  [ Alexandre Abreu ]
  * Explicitely define Ctrl+R as the refresh shortcut for the browser
    (LP: #1593877)

  [ Andrew Hayzen ]
  * Use the new TabsBar component from Ubuntu.Components.Extras

  [ Florian Boucault ]
  * Add Peekier to available search engines (LP: #1649673)
  * Bookmarks and history: increased font size one level
  * Make new tabs opened in the background to be placed next to the tab
    requesting them instead of at the end of the list of tabs (LP: #1499780)
  * Enable predictive text in address bar (LP: #1378750)
  * Fix issue with new tab page sometimes never being unloaded (LP: #1659435)
  * Snap: embed ubuntu-ui-extras by building it from source
  * Improved UX for <select> dropdowns in web content
  * Store and restore on startup the size of each window (LP: #1312892)
  * Do not go fullscreen if already fullscreen (LP: #1665727)
  * Do not rely on qmake as webbrowser is CMake based

  [ Jeremy Bicha ]
  * Drop "Open a " prefix from .desktop Actions (LP: #1668699)

  [ Matthieu James ]
  * Updated browser icon (LP: #1358050)

  [ Michael Terry ]
  * Properly set the APP_ID variable for the snappy world

  [ Olivier Tilloy ]
  * Use the no-system-libraries build attribute instead of specifying extra
    stage packages
  * Move snapcraft.yaml to snap directory (new in snapcraft 2.26)
  * Add a desktop UA override for dailymotion.com (LP: #1662826)
  * Log oxide and chromium versions at app startup
  * Add UA overrides for google photos (desktop and mobile) (LP: #1665926)
  * Explicitly plug to the "mir" interface (LP: #1662145)
  * Add "ibus" and "nvidia" apparmor abstractions to webbrowser-app apparmor
    profile
  * Additional holes in generated apparmor profile to allow webbrowser-app
    to run under unity8 in zesty (LP: #1590561)

 -- Olivier Tilloy <email address hidden> Fri, 10 Mar 2017 15:35:28 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.