use the size of the data when determining the server response
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
whoopsie (Ubuntu) |
Fix Released
|
Medium
|
Brian Murray | ||
Focal |
Fix Released
|
Medium
|
Brian Murray | ||
Groovy |
Fix Released
|
Medium
|
Brian Murray | ||
Hirsute |
Fix Released
|
Medium
|
Brian Murray |
Bug Description
[Note]
This SRU has been built in a security-only PPA and should be released to both -updates and -security.
[Impact]
whoopsie's server_response code is using "g_string_append" instead of "g_string_
Here's an example when using whoopsie on groovy to send a crash to a bionic daisy server:
[15:35:30] Sent; server replied with: No error
[15:35:30] Response code: 200
[15:35:30] Initial response data is: 2bbb776e-
0
[15:35:30] Got command: OOPSID
We can see a fair number of extra characters (\n0\n\n) after the OOSID command. This becomes more problematic when daisy requests a core dump from the client as the CORE command won't match and the client will never send the core dump.
[Test Case]
Setup a Bionic version of the Error Tracker:
0) modify /etc/hosts so daisy.staging.
1) sudo service stop whoopsie
2) sudo CRASH_DB_URL=https:/
3) Run test/submit-crash test-crashes/
4) check the whoopsie log file for "Got command: OOPSID" and extra data.
With the version of whoopsie from -proposed this will not happen. Additionally, a regression test should be run against the staging version of the error tracker by removing the entry from /etc/hosts for the daisy.staging server. After confirming that one test crash works one should also send a python crash, and an end of life release crash as those all generate different response codes from the server.
[Regression Potential]
The code being changed is clearly wrong and doesn't confirm to the curl API https:/
Related branches
description: | updated |
description: | updated |
summary: |
- use the size of the data when determing the server response + use the size of the data when determining the server response |
Changed in whoopsie (Ubuntu Groovy): | |
assignee: | nobody → Brian Murray (brian-murray) |
Changed in whoopsie (Ubuntu Focal): | |
assignee: | nobody → Brian Murray (brian-murray) |
Changed in whoopsie (Ubuntu Groovy): | |
status: | New → In Progress |
Changed in whoopsie (Ubuntu Focal): | |
status: | New → In Progress |
Changed in whoopsie (Ubuntu Focal): | |
importance: | Undecided → Medium |
Changed in whoopsie (Ubuntu Groovy): | |
importance: | Undecided → Medium |
This is the result of the following merge:
https:/ /bazaar. launchpad. net/~daisy- pluckers/ whoopsie/ trunk/revision/ 707
So affects Ubuntu 20.04 LTS and later releases.