xen hibernation support for linux-aws (bionic+)

Bug #1804533 reported by Kamal Mostafa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-aws (Ubuntu)
Fix Released
Undecided
Kamal Mostafa
Bionic
Fix Released
Undecided
Kamal Mostafa
Cosmic
Fix Released
Undecided
Kamal Mostafa
Disco
Fix Released
Undecided
Kamal Mostafa
Eoan
Won't Fix
Undecided
Unassigned
Focal
New
Undecided
Unassigned

Bug Description

AWS-specific xen hibernation support (as is already supported in linux-aws Xenial and Trusty) has been ported to linux-aws Bionic by the Amazon team.

Patches to be applied to linux-aws-bionic:

UBUNTU: SAUCE [aws] x86/xen: Introduce new function to map HYPERVISOR_shared_info on
UBUNTU: SAUCE [aws] x86/xen: add system core suspend and resume callbacks
UBUNTU: SAUCE [aws] xen-netfront: add callbacks for PM suspend and hibernation support
UBUNTU: SAUCE [aws] xen-time-introduce-xen_-save-restore-_steal_clock
UBUNTU: SAUCE [aws] x86/xen: save and restore steal clock
UBUNTU: SAUCE [aws] xen/events: add xen_shutdown_pirqs helper function
UBUNTU: SAUCE [aws] x86/xen: close event channels for PIRQs in system core suspend
UBUNTU: SAUCE [aws] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA

This patch set passes simple hibernation smoke-testing on an instance.

Changed in linux-aws (Ubuntu Bionic):
assignee: nobody → Kamal Mostafa (kamalmostafa)
status: New → In Progress
Changed in linux-aws (Ubuntu):
status: New → In Progress
Changed in linux-aws (Ubuntu Bionic):
status: In Progress → Fix Committed
Changed in linux-aws (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-aws - 4.15.0-1031.33

---------------
linux-aws (4.15.0-1031.33) bionic; urgency=medium

  * linux-aws: 4.15.0-1031.33 -proposed tracker (LP: #1806664)

  * xen hibernation support for linux-aws (bionic) (LP: #1804533)
    - SAUCE [aws] x86/xen: Introduce new function to map HYPERVISOR_shared_info on
      Resume
    - SAUCE [aws] x86/xen: add system core suspend and resume callbacks
    - SAUCE [aws] xen-netfront: add callbacks for PM suspend and hibernation
      support
    - SAUCE [aws] xen-time-introduce-xen_-save-restore-_steal_clock
    - SAUCE [aws] x86/xen: save and restore steal clock
    - SAUCE [aws] xen/events: add xen_shutdown_pirqs helper function
    - SAUCE [aws] x86/xen: close event channels for PIRQs in system core suspend
      callback
    - SAUCE [aws] PM / hibernate: update the resume offset on
      SNAPSHOT_SET_SWAP_AREA

  [ Ubuntu: 4.15.0-43.46 ]

  * linux: 4.15.0-43.46 -proposed tracker (LP: #1806659)
  * System randomly hangs during suspend when mei_wdt is loaded (LP: #1803942)
    - SAUCE: base/dd: limit release function changes to vfio driver only
  * Workaround CSS timeout on AMD SNPS 3.0 xHC (LP: #1806838)
    - xhci: Allow more than 32 quirks
    - xhci: workaround CSS timeout on AMD SNPS 3.0 xHC
  * linux-buildinfo: pull out ABI information into its own package
    (LP: #1806380)
    - [Packaging] limit preparation to linux-libc-dev in headers
    - [Packaging] commonise debhelper invocation
    - [Packaging] ABI -- accumulate abi information at the end of the build
    - [Packaging] buildinfo -- add basic build information
    - [Packaging] buildinfo -- add firmware information to the flavour ABI
    - [Packaging] buildinfo -- add compiler information to the flavour ABI
    - [Packaging] buildinfo -- add buildinfo support to getabis
    - [Config] buildinfo -- add retpoline version markers
  * linux packages should own /usr/lib/linux/triggers (LP: #1770256)
    - [Packaging] own /usr/lib/linux/triggers
  * CVE-2018-12896
    - posix-timers: Sanitize overrun handling
  * CVE-2018-16276
    - USB: yurex: fix out-of-bounds uaccess in read handler
  * CVE-2018-10902
    - ALSA: rawmidi: Change resized buffers atomically
  * CVE-2018-18710
    - cdrom: fix improper type cast, which can leat to information leak.
  * CVE-2018-18690
    - xfs: don't fail when converting shortform attr to long form during
      ATTR_REPLACE
  * CVE-2018-14734
    - infiniband: fix a possible use-after-free bug
  * CVE-2018-18445
    - bpf: 32-bit RSH verification must truncate input before the ALU op
  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts

 -- Khalid Elmously <email address hidden> Thu, 06 Dec 2018 21:51:22 +0000

Changed in linux-aws (Ubuntu Bionic):
status: Fix Committed → Fix Released
status: Fix Committed → Fix Released
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

This patch set is also required for Cosmic and future linux-aws kernel series.

Changed in linux-aws (Ubuntu Disco):
status: Fix Committed → In Progress
Changed in linux-aws (Ubuntu Cosmic):
status: New → In Progress
assignee: nobody → Kamal Mostafa (kamalmostafa)
summary: - xen hibernation support for linux-aws (bionic)
+ xen hibernation support for linux-aws (bionic+)
Changed in linux-aws (Ubuntu Cosmic):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.3 KiB)

This bug was fixed in the package linux-aws - 4.18.0-1011.13

---------------
linux-aws (4.18.0-1011.13) cosmic; urgency=medium

  * linux-aws: 4.18.0-1011.13 -proposed tracker (LP: #1814757)

  * PAGE_POISONING / PAGE_POISONING_NO_SANITY / PAGE_POISONING_ZERO option was
    expected to be set in C-KVM (LP: #1812624)
    - [Config]: enable PAGE_POISONING, PAGE_POISONING_NO_SANITY,
      PAGE_POISONING_ZERO

  * Update ENA driver to version 2.0.3K (LP: #1816806)
    - net: ena: fix crash during failed resume from hibernation
    - net: ena: fix race between link up and device initalization
    - net: ena: update driver version from 2.0.2 to 2.0.3

  * xen hibernation support for linux-aws (bionic+) (LP: #1804533)
    - SAUCE [aws] x86/xen: Introduce new function to map HYPERVISOR_shared_info on
      Resume
    - SAUCE [aws] x86/xen: add system core suspend and resume callbacks
    - SAUCE [aws] xen-netfront: add callbacks for PM suspend and hibernation
      support
    - SAUCE [aws] xen-time-introduce-xen_-save-restore-_steal_clock
    - SAUCE [aws] x86/xen: save and restore steal clock
    - SAUCE [aws] xen/events: add xen_shutdown_pirqs helper function
    - SAUCE [aws] x86/xen: close event channels for PIRQs in system core suspend
      callback
    - SAUCE [aws] PM / hibernate: update the resume offset on
      SNAPSHOT_SET_SWAP_AREA

  * Packaging resync (LP: #1786013)
    - [Packaging] resync getabis
    - [Packaging] update helper scripts

linux-aws (4.18.0-1010.12) cosmic; urgency=medium

  * linux-aws: 4.18.0-1010.12 -proposed tracker (LP: #1814757)

  * bluetooth controller not detected with 4.15 kernel (LP: #1810797)
    - [Config] Disable BT_QCOMSMD_HACK for AWS

  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts

  [ Ubuntu: 4.18.0-16.17 ]

  * linux: 4.18.0-16.17 -proposed tracker (LP: #1814749)
  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts
  * CVE-2018-16880
    - vhost: fix OOB in get_rx_bufs()
  * RTL8822BE WiFi Disabled in Kernel 4.18.0-12 (LP: #1806472)
    - SAUCE: staging: rtlwifi: allow RTLWIFI_DEBUG_ST to be disabled
    - [Config] CONFIG_RTLWIFI_DEBUG_ST=n
    - SAUCE: Add r8822be to signature inclusion list
  * kernel oops in bcache module (LP: #1793901)
    - SAUCE: bcache: never writeback a discard operation
  * CVE-2018-18397
    - userfaultfd: use ENOENT instead of EFAULT if the atomic copy user fails
    - userfaultfd: shmem: allocate anonymous memory for MAP_PRIVATE shmem
    - userfaultfd: shmem/hugetlbfs: only allow to register VM_MAYWRITE vmas
    - userfaultfd: shmem: add i_size checks
    - userfaultfd: shmem: UFFDIO_COPY: set the page dirty if VM_WRITE is not set
  * Ignore "incomplete report" from Elan touchpanels (LP: #1813733)
    - HID: i2c-hid: Ignore input report if there's no data present on Elan
      touchpanels
  * Vsock connect fails with ENODEV for large CID (LP: #1813934)
    - vhost/vsock: fix vhost vsock cid hashing inconsistent
  * Fix non-working pinctrl-intel (LP: #1811777)
    - pinctrl: intel: Do pin translation in other GPIO operations as well
  * ip6_gre: fix tunnel list corruption for x-netns (LP: #1812875)
    - ip6_gre: fix tu...

Read more...

Changed in linux-aws (Ubuntu Cosmic):
status: Fix Committed → Fix Released
Changed in linux-aws (Ubuntu Disco):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

The Eoan Ermine has reached end of life, so this bug will not be fixed for that release

Changed in linux-aws (Ubuntu Eoan):
status: New → Won't Fix
Revision history for this message
gerald.yang (gerald-yang-tw) wrote :

We are hitting the hibernation issue on Jammy aws kernel (5.15), it gets stuck when hibernating

Turn out it needs some patches from 5.15 amazonlinux to make hibernation work
https://github.com/amazonlinux/linux/tree/amazon-5.15.y/mainline

Revision history for this message
gerald.yang (gerald-yang-tw) wrote :

This should be the minimal set of patches needed for hibernation on 5.15 aws kernel

270756abd4ee x86: Disable KASLR when Xen is detected
7fea4363d9ed xen: Restore xen-pirqs on resume from hibernation
90c68a4dc544 xen-netfront: call netif_device_attach on resume
145e43c7bcb1 xen: Only restore the ACPI SCI interrupt in xen_restore_pirqs.
0bee88d07b90 xen: restore pirqs on resume from hibernation.
eea0b7233237 block: xen-blkfront: consider new dom0 features on restore
58384365b8f9 x86: tsc: avoid system instability in hibernation
fa7338e2cc40 xen-blkfront: Fixed blkfront_restore to remove a call to negotiate_mq
adbfd873b794 Revert "xen: dont fiddle with event channel masking in suspend/resume"
82da236ac6b7 PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA
f80eefc94f1c x86/xen: close event channels for PIRQs in system core suspend callback
f63322520aef xen/events: add xen_shutdown_pirqs helper function
e1b7133cbbff x86/xen: save and restore steal clock
cabbc45bf231 xen/time: introduce xen_{save,restore}_steal_clock
12fd0b3780ca xen-netfront: add callbacks for PM suspend and hibernation support
233164df57b9 xen-blkfront: add callbacks for PM suspend and hibernation
d4bb270004c6 x86/xen: add system core suspend and resume callbacks
2f0124f09f40 x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume
abccdb907327 xenbus: add freeze/thaw/restore callbacks support
89d7d6edb461 xen/manage: introduce helper function to know the on-going suspend mode
7d6397dc12ad xen/manage: keep track of the on-going suspend mode

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.