mailman breaks CC field incorrectly when spread over multiple lines

This version of mailman bundles the python email package for compatibility; the patch will need to be applied within the email-2.5.8.tar.gz located in this package.

Discussed this bug with the guys on #ubuntu-server and I think that its worth raising a SRU for this bug.

I'll work on a patch to feed into this process; however it will need extensive testing - @Satish is this something that you would be able to help out with?

I'm having trouble re-producing this issue on Hardy; please could you detail exactly how this can be tested and what combination of mailman and mail transfer agent you are using (postfix/exim etc...)

Thanks

We are using postfix (version 2.5.1-2ubuntu1.2) and mailman version 2.1.9-9ubuntu1 in our environment. The scenario in which we noticed this problem:

To: <email address hidden>
Cc: <email address hidden>, <email address hidden>, <email address hidden>, <email address hidden>, display
      name <email address hidden>

There was an email sent by an user as mentioned above. In this scenario, display and name <email address hidden> became two email addresses (as noticed by the user who received the email from mailing list).

Yes, I am willing to test the patches.

OK; the key bit I missed was that the incorrectly parsed email address was broken over two lines.

Using a standalone mailman + postfix setup on Hardy I have been able to reproduce using the following procedure:

  Install postfix and configure as final destination for <hostname>.example.com
  Setup three users (user1, user2 and user3)
  Install mailman and setup default (mailman) and test-list (with user1 as list owner) list.
  Configure Apache to allow administration of mail lists
  Install and configure dovecot for local mail delivery.
  Add user2 to the test-list mail list using the administration screens

Using the attached email (test.txt), simulate the offending use case using the following command using the user1 account:

  telnet localhost 25 < test.txt

The posting to the test-list mailing list incorrectly has two emails addresses:

Date: Mon, 18 Oct 2010 10:44:12 +0100 (BST)
From: <email address hidden>
Cc: three <email address hidden>,
 <email address hidden>, <email address hidden>
Subject: [Test-list] Test

Test Email
_______________________________________________
Test-list mailing list
<email address hidden>
http://hardy-mailman.example.com/cgi-bin/mailman/listinfo/test-list

Note that this bug only impacts the mailman package up to and including 2.1.9-9ubuntu1 (as distributed on 8.04) as the bundled version of Python email is removed in later versions

Why does this ship an entirely new file instead of a patch? Is there a patch to review here? Thanks!

Closing main Ubuntu task as per comment 6.

I chose this approach as the fix required needs to be applied within misc/email-3.5.8.tar.gz which is expanded during the package build process.

I can rework this into a patch for the _parseaddr.py contained with misc/email-3.5.8.tar.gz and patch instead of overwriting if you would like me to.

James,

ah, that makes sense. You can keep the package as it is, I am just interested in seeing a diff of what will actually change. Thanks!

As requested - patch detailing the changes made to _parseaddr.py.

James,

Is the mailman package updated in ubuntu? If yes, where can I d/l the updated one?

Thanks for fixing this.

James, that looks fine, thanks! Please go ahead and get this uploaded.

Chuck you seem to have worked on this package before, could you sponsor the sru there if it makes sense to you?

Looks good to me. Uploaded to hardy-proposed.

Accepted mailman into hardy-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Looks good on my virtual test instance that I did the original confirmation and fix on.

Satish - are you able to support with more in-depth testing?

Thanks

I have downloaded the package and right now we are testing in a development server. Thanks for the fix. I will post about results of our testing.

I've tested the package from -proposed according to the test case and it seems to work. Below some details.

- set up test-list with user1 and user2 as test users, and user3 NOT a member
- sent a mail to the list, like this:

HELO localhost
MAIL FROM: <email address hidden>
RCPT TO: <email address hidden>
DATA
Subject: Test
Cc: <email address hidden>, "user two" <email address hidden>, user
          three <email address hidden>

Test Email
.
QUIT

- got the following header after it got delivered to user1 (which is a member):

From: <email address hidden>
Cc: <email address hidden>, <email address hidden>,
        three <email address hidden>
Subject: [Test-list] Test

- notice the user@ ... email address which is wrong

After activating -proposed and installed 2.1.9-9ubuntu1.1, sent the same message and got the correct header:

From: <email address hidden>
Cc: user three <email address hidden>,
        <email address hidden>
Subject: [Test-list] Test

I can confirm that the package from -proposed fixes this bug.

This bug was fixed in the package mailman - 1:2.1.9-9ubuntu1.1

---------------
mailman (1:2.1.9-9ubuntu1.1) hardy-proposed; urgency=low

  * Patched bundled python-2.5.8 email package to correctly parse
    email addresses (LP: #659975)
 -- James Page <email address hidden> Thu, 14 Oct 2010 15:43:11 +0100