select in gilbc 2.33 does not always set select timeout in Hirsute

Bug #1930473 reported by Balint Reczey
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GLibC
Fix Released
Critical
glibc (Ubuntu)
Fix Released
Undecided
Unassigned
Hirsute
New
Undecided
Unassigned

Bug Description

[Impact]
* Not updating select's timeout breaks topline's autopkgtest and possibly other software. https://github.com/kilobyte/topline/issues/1

[Test Plan]

* Run Groovy's topline's autopkgtest, it should pass:

  $ autopkgtest -U topline_0.3-1.dsc --apt-pocket=proposed=src:glibc -- lxd autopkgtest/ubuntu/hirsute/amd64

[Where problems could occur]

* The fix removes obsolete checks that prevented updating the returned timeout. There are no unexpected side effects from this.

Revision history for this message
In , Andreas Schwab (schwab-linux-m68k) wrote :

When the [p]select syscall returns with an error (eg. EINTR) the timeout argument is no longer updated.

Revision history for this message
In , Andreas Schwab (schwab-linux-m68k) wrote :

When 64-bit time_t is supported, the timeout argument is not updated at all.

Revision history for this message
In , Adhemerval Zanella (adhemerval-zanella) wrote :

Fixed on 2.33, I will backport to 2.32 as well.

Revision history for this message
In , Adhemerval Zanella (adhemerval-zanella) wrote :

My confusion, I meant fixed on 2.34 and I will backport to 2.33.

Revision history for this message
In , Florian Weimer (fweimer) wrote :

commit cedbf6d5f3f70ca911176de87d6e453eeab4b7a1
Author: Adhemerval Zanella <email address hidden>
Date: Thu Apr 8 07:39:32 2021 -0300

    linux: always update select timeout (BZ #27706)

    The timeout should be updated even on failure for time64 support.

Balint Reczey (rbalint)
description: updated
Changed in glibc (Ubuntu):
status: New → Fix Released
summary: - select in gilbc 2.33 does not always set select timeout
+ select in gilbc 2.33 does not always set select timeout in Hirsute
Changed in glibc:
importance: Unknown → Critical
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.