Add modaliases support

modalias should also be added to linux-modules-{ivsc,ipu6)-* packages. Perhaps only to the meta packages but not the ones with built modules?

debdiff for mantic with following bugs addressed:
* bug 2021740 (add modaliases),
* bug 2012407 (add CONFIG_VIDEO_V4L2_I2C to BUILD_EXCLUSIVE_CONFIG),
* bug 2026402 (fix build against linux v6.5-rc1)

The attachment "ipu6-drivers_0~git202302081010.7fdfb5eb-0ubuntu0.23.10.2.mantic.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Prebuilt PPA: https://launchpad.net/~vicamo/+archive/ubuntu/ppa-2021740

Attach all the debdiff for affected targets. Need sponsoring.

I have sponsored ivsc-driver for mantic. Right now that's as much as I can sponsor however, as the other bits need some questions answered:

 * ipu6-drivers for all series: when looking at the debdiff for mantic, I see that there's quite a lot of changes being added to the package. Besides the aforementioned 3 bug fixes, in the changelog I see entries from Andy Shevchenko, Hans de Goede and liang1.wang which are not clear to how they are related to the upload. Are those required to fix one of the 3 bugs? Can this be made clear in the changelog entry and the bug description? Since without full knowledge it's hard to know what's their purpose.
Also, currently the debdiff is 5k+ lines long. Are all these patches that are added required as-is?

 * ipu6-drivers and ivsc-driver for stable series: for these debdiffs to get sponsored, I would like the bug being prepared from the SRU perspective. Please see the template on https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template and be sure to provide all the necessary information in the bug.

I'll remove the ubuntu-sponsors subscription for now. Please address my comments as written in comment #7 and re-subscribe in case sponsorship is still required!

Updated bug descriptions to include details.

As for those huge patches, yes, the upstream project is still in a very early development stage and official releases may not meet the schedule from Ubuntu/OEM's side. Side-loaded patches are often needed to reflect the need from new hardware platforms and bug fixes.

Re-subscribe ubuntu-sponsors after more detailed information along with SRU justifications.

This bug was fixed in the package ivsc-driver - 0~git202212210258.94ecb88b-0ubuntu0.23.10.2

---------------
ivsc-driver (0~git202212210258.94ecb88b-0ubuntu0.23.10.2) mantic; urgency=low

  [ You-Sheng Yang ]
  * debian: add modaliases (LP: #2021740)

 -- You-Sheng Yang <email address hidden> Wed, 12 Jul 2023 16:17:37 +0800

For ipu6-drivers into Mantic: are these straight cherry-picks from the upstream master branch, or have they been mdified? Please add dep3 headers[1] to the quilt patches that you're adding. This would make it easier to review them. This is our standard in Ubuntu. You might find git-to-dquilt.sh useful[2].

[For other sponsors: my inclination is that if they are direct cherry-picks from upstream then it's probably OK without further review though I'd verify it that far.]

Please adjust your test plan as follows in the SRU documentation.

> Bug 2012407: make sure intel-ipu6-dkms build will be skipped on platforms without CONFIG_VIDEO_V4L2_I2C, and intel-vsc-dkms on platforms without CONFIG_GPIOLIB_IRQCHIP, such as linux-headers-kvm/jammy.

What are the exact steps you will use to verify this please?

> Bug 2021740: check built binary deb has XB-Modaliases tag in `dpkg-deb --info` output.

This test is insufficient. The case you made for SRUing this fix is for support in ubuntu-drivers, so please plan to test that support in ubuntu-drivers is actually working and document how you will do this.

> For rest of the changes, they should be verified on next IPU6 equipped platform.

Please expand on this. What are you intending to test and how exactly?

For bug 2026402, the case for SRUing this fix is that building the DKMS package fails using the upcoming HWE kernel and after this fix that it will work. So please test this end-to-end functionality by checking that with a given kernel the DKMS build succeeds. I would expect that to be tested against a version of the kernel that is in the archive. Is that already the case? If not, then I suggest that we either wait until it is, or split the SRU. If you think that's not practical then we can discuss further.

Since DKMS packages also need to build against the release (non-HWE) kernel version, it's a common area of risk that fixing against the HWE kernel may break the build against the release kernel, so please additionally plan to test that the package still builds against the release kernel.

I'm unsubscribing ~ubuntu-sponsors again; please resubscribe once ready.

[1] https://dep-team.pages.debian.net/deps/dep3/
[2] https://git.launchpad.net/~ubuntu-server/+git/ubuntu-helpers/tree/cpaelzer/git-to-dquilt.sh

SRU:
* https://lists.ubuntu.com/archives/kernel-team/2023-October/146164.html (lunar)
* https://lists.ubuntu.com/archives/kernel-team/2023-October/146166.html (unstable, mantic)

SRU:
* http://10.131.201.69/kernel/jammy-linux-oem/pulls/81 (oem-6.5)
* http://10.131.201.69/kernel/jammy-linux-oem/pulls/82 (oem-6.1)

> > Bug 2012407: make sure intel-ipu6-dkms build will be skipped on platforms without CONFIG_VIDEO_V4L2_I2C and intel-vsc-dkms on platforms without CONFIG_GPIOLIB_IRQCHIP, such as linux-headers-kvm/jammy.
> What are the exact steps you will use to verify this please?

Steps detailed in bug 2012407's SRU justification.

> > Bug 2021740: check built binary deb has XB-Modaliases tag in `dpkg-deb --info` output.
> This test is insufficient.

Add ubuntu-drivers command in SRU justification to show that demonstrate u-d is already capable of discovering dkms/linux-modules for ipu6 drivers.

> For bug 2026402, the case for SRUing this fix is that building the DKMS package fails using the upcoming HWE kernel and after this fix that it will work. So please test this end-to-end functionality by checking that with a given kernel the DKMS build succeeds. I would expect that to be tested against a version of the kernel that is in the archive. Is that already the case? If not, then I suggest that we either wait until it is, or split the SRU. If you think that's not practical then we can discuss further.

We're testing compiling these staging changes in several PPAs for different purposes, such as:
* https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/intermediate-kernel
  - this covers generic and oem kernels
* https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/experimental-unstable
  - linux-unstable kernel, currently at v6.6
* https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/experimental-drmtip
  - linux-unstable kernel rebased onto drm-tip, currently at v6.6
* https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/experimental-next
  - linux-unstable kernel rebased onto linux-next, last good build at next-20231020

The dkms packages are compiled along with the kernel to create linux-modules-<foo>-<version>-<variant> packages.

Remove outdated ipu6-drivers debdiff for Mantic.

Remove already released ivsc-driver debdiff for Mantic.

This bug was fixed in the package ipu6-drivers - 0~git202310180730.3f813580-0ubuntu0.24.04.1

---------------
ipu6-drivers (0~git202310180730.3f813580-0ubuntu0.24.04.1) noble; urgency=low

  [ Hao Yao ]
  * New upstream 20230802_1500_mtl_plat release.
  * New upstream 20230911_0620_mtl_plat_pv release.

  [ Hans de Goede ]
  * Fix compilation with kernels >= 6.5.0 (LP: #2026402)
    - ipu-psys: Fix compilation with kernels >= 6.5.0
    - ipu6: Fix compilation with kernels >= 6.6.0
    - ipu6: Fix sensor driver compilation with kernels >= 6.6.0

  [ You-Sheng Yang ]
  * Support mipi camera on Intel Meteor Lake platform (LP: #2031412)
    - debian: refresh patches
  * dkms: add CONFIG_VIDEO_V4L2_I2C to BUILD_EXCLUSIVE_CONFIG (LP: #2012407)
  * debian: add modaliases (LP: #2021740)
  * UBUNTU: SAUCE: i2c: compile omitted sensor drivers

 -- You-Sheng Yang <email address hidden> Fri, 01 Sep 2023 17:51:53 +0800

Remove affecting kernel parts per conclusion from Riga Sprint.