Include cifs.ko in linux-modules package

Bug #2042546 reported by Roxana Nicolescu
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Invalid
Undecided
Unassigned
Lunar
Fix Committed
High
Roxana Nicolescu

Bug Description

SRU Justification:

[Impact]

Commit: "smb: move client and server files to common directory fs/smb" introduced in 2023.09.04 moved the fs/cifs directory to fs/sb/client. The inclusion list for linux-modules was not updated, it still contains the old path. This means that the cifs.ko module cannot be loaded if only linux-modules package is installed, now being part of linux-modules-extra.
For lunar:main this is not a problem because linux-modules-extra is always installed, but for derivatives like aws, azure etc, this module cannot be loaded without explicitly installing linux-modules-extra.

[How to reproduce it]:
1. Install the latest azure kernel 6.2.0-1016.16
2. Load cifs module
$ modprobe cifs
modprobe: FATAL: Module cifs not found in directory /lib/modules/6.2.0-1016-azure
If modules-extra is installed, this works.

[Fix]

Replace fs/cifs/* with fs/smb/client/* in debian.<derivative>/control.d/<derivative>.inclusiojn-list
This is going to be done in s2023.10.02 cycle for derivatives.

[Test Plan]

1. Apply the fix to one of the derivative (azure), build a new kernel and install it
2. Load cifs module
$ modprobe cifs
It should work without installing modules-extra.

[Regression potential]

Very low, it's a straightforward fix.

[Other Info]
Sending a patch for every derivative takes time and each derivative will be fixed once this proposal is acked.
There is also the possibility to do it via cranky fix, but owners may omit it during security updates and it's hard to enforce it. Plus, it is a one-time change.

description: updated
tags: added: sru-s2023.10.02
tags: added: sru-s20231002
removed: sru-s2023.10.02
description: updated
Changed in linux (Ubuntu):
status: New → Invalid
Changed in linux (Ubuntu Lunar):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Roxana Nicolescu (roxanan)
summary: - Cifs.ko not part of linux-modules anymore
+ Include cifs.ko in linux-modules
summary: - Include cifs.ko in linux-modules
+ Include cifs.ko in linux-modules package
Changed in linux (Ubuntu Lunar):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-kvm/6.2.0-1017.17 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-kvm' to 'verification-done-lunar-linux-kvm'. If the problem still exists, change the tag 'verification-needed-lunar-linux-kvm' to 'verification-failed-lunar-linux-kvm'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-kvm-v2 verification-needed-lunar-linux-kvm
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-hwe-6.2/6.2.0-37.38~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-hwe-6.2' to 'verification-done-jammy-linux-hwe-6.2'. If the problem still exists, change the tag 'verification-needed-jammy-linux-hwe-6.2' to 'verification-failed-jammy-linux-hwe-6.2'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-hwe-6.2-v2 verification-needed-jammy-linux-hwe-6.2
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-aws/6.2.0-1016.16 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-aws' to 'verification-done-lunar-linux-aws'. If the problem still exists, change the tag 'verification-needed-lunar-linux-aws' to 'verification-failed-lunar-linux-aws'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-aws-v2 verification-needed-lunar-linux-aws
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp/6.2.0-1019.21 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-gcp' to 'verification-done-lunar-linux-gcp'. If the problem still exists, change the tag 'verification-needed-lunar-linux-gcp' to 'verification-failed-lunar-linux-gcp'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-gcp-v2 verification-needed-lunar-linux-gcp
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-lowlatency-hwe-6.2/6.2.0-1017.17~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-lowlatency-hwe-6.2' to 'verification-done-jammy-linux-lowlatency-hwe-6.2'. If the problem still exists, change the tag 'verification-needed-jammy-linux-lowlatency-hwe-6.2' to 'verification-failed-jammy-linux-lowlatency-hwe-6.2'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-lowlatency-hwe-6.2-v2 verification-needed-jammy-linux-lowlatency-hwe-6.2
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-azure/6.2.0-1017.17 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-azure' to 'verification-done-lunar-linux-azure'. If the problem still exists, change the tag 'verification-needed-lunar-linux-azure' to 'verification-failed-lunar-linux-azure'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-azure-v2 verification-needed-lunar-linux-azure
Revision history for this message
Dean Attewell (eitsop) wrote :

when will this change be deployed?

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-riscv/6.2.0-37.38.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-riscv' to 'verification-done-lunar-linux-riscv'. If the problem still exists, change the tag 'verification-needed-lunar-linux-riscv' to 'verification-failed-lunar-linux-riscv'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-riscv-v2 verification-needed-lunar-linux-riscv
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/6.2.0-39.40 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux' to 'verification-done-lunar-linux'. If the problem still exists, change the tag 'verification-needed-lunar-linux' to 'verification-failed-lunar-linux'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-v2 verification-needed-lunar-linux
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-starfive/6.2.0-1009.10 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-starfive' to 'verification-done-lunar-linux-starfive'. If the problem still exists, change the tag 'verification-needed-lunar-linux-starfive' to 'verification-failed-lunar-linux-starfive'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-starfive-v2 verification-needed-lunar-linux-starfive
Revision history for this message
Roxana Nicolescu (roxanan) wrote :

@eitsop It is part of the 2023.10.30 cycle and it will be released on the week of 4th of December as described here https://kernel.ubuntu.com.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.