Lockscreen prompt missing hi dpi
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
7.2 |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[ Impact ]
The lockscreen has correct Panel HiDPI support, but the prompt doesn't scale right now.
[ Test Case ]
(1) Using the System Settings, adjust the scaling for your monitor to, say, 1.88
(2) Invoke the screen lock by, say, pressing Super-L
(3) hit the shift key to bring up the lockscreen, observe the scaling of the password prompt: it should be appropriately scaled.
[ Regression Potential ]
Any change to the Unity desktop shell could potentially introduce a new crash or lockup: in this case, a crash could be a security violation.
[ Additional Info ]
The SRU for for Ubuntu 14.04 LTS was cherry-picked from Ubuntu 14.10 where it has been in production use for some time without apparent regression.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Andrea Azzarone (community): Approve
-
Diff: 1483 lines (+362/-193)28 files modifieddash/previews/ErrorPreview.cpp (+1/-0)
dash/previews/PaymentPreview.cpp (+3/-1)
launcher/SwitcherView.cpp (+1/-1)
lockscreen/BackgroundSettings.cpp (+13/-11)
lockscreen/BackgroundSettings.h (+0/-1)
lockscreen/CofView.cpp (+15/-2)
lockscreen/CofView.h (+3/-1)
lockscreen/LockScreenAbstractShield.h (+2/-0)
lockscreen/LockScreenController.cpp (+10/-18)
lockscreen/LockScreenController.h (+3/-2)
lockscreen/LockScreenPanel.cpp (+3/-1)
lockscreen/LockScreenSettings.cpp (+2/-0)
lockscreen/LockScreenSettings.h (+2/-1)
lockscreen/LockScreenShield.cpp (+43/-11)
lockscreen/LockScreenShield.h (+3/-0)
lockscreen/UserPromptView.cpp (+95/-17)
lockscreen/UserPromptView.h (+5/-4)
plugins/unityshell/src/unityshell.cpp (+1/-1)
plugins/unityshell/src/unityshell.h (+2/-2)
tests/test_previews_music_payment.cpp (+1/-0)
tests/test_text_input.cpp (+1/-0)
unity-shared/IconTexture.cpp (+1/-1)
unity-shared/SearchBar.cpp (+12/-8)
unity-shared/SearchBar.h (+9/-9)
unity-shared/SearchBarSpinner.h (+0/-2)
unity-shared/SpreadFilter.cpp (+3/-1)
unity-shared/TextInput.cpp (+114/-79)
unity-shared/TextInput.h (+14/-19)
- Marco Trevisan (Treviño): Approve
-
Diff: 6023 lines (+2168/-709)105 files modifiedCMakeLists.txt (+1/-0)
UnityCore/DBusIndicators.cpp (+11/-0)
UnityCore/DBusIndicators.h (+1/-0)
UnityCore/DesktopUtilities.cpp (+12/-0)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+100/-3)
UnityCore/GLibDBusProxy.h (+6/-0)
UnityCore/GLibWrapper-inl.h (+12/-0)
UnityCore/GLibWrapper.h (+1/-0)
UnityCore/GnomeSessionManager.cpp (+0/-1)
UnityCore/Indicators.h (+1/-0)
dash/FilterBasicButton.cpp (+6/-3)
dash/previews/ActionButton.cpp (+5/-2)
dash/previews/ErrorPreview.cpp (+1/-0)
dash/previews/PaymentPreview.cpp (+3/-1)
data/CMakeLists.txt (+1/-0)
data/pam/CMakeLists.txt (+1/-0)
data/pam/unity (+2/-0)
debian/changelog (+59/-0)
debian/rules (+1/-1)
debian/unity.install (+1/-0)
debian/unity.migrations (+1/-0)
decorations/DecoratedWindow.cpp (+155/-64)
decorations/DecorationsEdgeBorders.cpp (+32/-19)
decorations/DecorationsForceQuitDialog.cpp (+17/-3)
decorations/DecorationsManager.cpp (+17/-26)
decorations/DecorationsPriv.h (+12/-3)
decorations/DecorationsTitle.cpp (+1/-0)
decorations/DecorationsWidgets.cpp (+13/-1)
decorations/DecorationsWidgets.h (+5/-0)
doc/unity.1 (+35/-10)
hud/HudIconTextureSource.cpp (+0/-5)
hud/HudIconTextureSource.h (+0/-1)
launcher/ApplicationLauncherIcon.cpp (+2/-0)
launcher/DesktopLauncherIcon.cpp (+13/-1)
launcher/DesktopLauncherIcon.h (+2/-0)
launcher/Launcher.cpp (+1/-3)
launcher/LauncherIcon.cpp (+117/-104)
launcher/LauncherIcon.h (+12/-8)
launcher/MockLauncherIcon.h (+0/-5)
launcher/SwitcherView.cpp (+9/-1)
launcher/Tooltip.cpp (+5/-4)
lockscreen/BackgroundSettings.cpp (+13/-11)
lockscreen/BackgroundSettings.h (+0/-1)
lockscreen/CMakeLists.txt (+2/-0)
lockscreen/CofView.cpp (+15/-2)
lockscreen/CofView.h (+3/-1)
lockscreen/LockScreenAbstractShield.h (+14/-1)
lockscreen/LockScreenController.cpp (+54/-14)
lockscreen/LockScreenController.h (+12/-3)
lockscreen/LockScreenPanel.cpp (+31/-2)
lockscreen/LockScreenSettings.cpp (+2/-0)
lockscreen/LockScreenSettings.h (+2/-1)
lockscreen/LockScreenShield.cpp (+60/-29)
lockscreen/LockScreenShield.h (+10/-3)
lockscreen/LockScreenShieldFactory.cpp (+7/-2)
lockscreen/LockScreenShieldFactory.h (+12/-2)
lockscreen/ShutdownNotifier.cpp (+152/-0)
lockscreen/ShutdownNotifier.h (+51/-0)
lockscreen/SuspendNotifier.cpp (+153/-0)
lockscreen/SuspendNotifier.h (+51/-0)
lockscreen/UserAuthenticatorPam.cpp (+1/-2)
lockscreen/UserPromptView.cpp (+96/-17)
lockscreen/UserPromptView.h (+5/-4)
panel/PanelIndicatorEntryView.cpp (+1/-1)
panel/PanelMenuView.cpp (+83/-38)
panel/PanelMenuView.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+29/-35)
plugins/unityshell/src/unityshell.h (+2/-2)
services/panel-main.c (+8/-0)
services/panel-service.c (+15/-0)
services/panel-service.h (+2/-0)
tests/CMakeLists.txt (+1/-1)
tests/mock_indicators.h (+1/-0)
tests/test_lockscreen_controller.cpp (+10/-2)
tests/test_main_xless.cpp (+4/-5)
tests/test_previews_music_payment.cpp (+1/-0)
tests/test_text_input.cpp (+1/-0)
tools/migration-scripts/03_unity_first_run_stamp_move (+35/-0)
unity-shared/CompizUtils.cpp (+77/-58)
unity-shared/CompizUtils.h (+36/-5)
unity-shared/DashStyle.cpp (+8/-11)
unity-shared/DecorationStyle.cpp (+2/-2)
unity-shared/GnomeKeyGrabber.cpp (+9/-0)
unity-shared/IconRenderer.cpp (+73/-43)
unity-shared/IconRenderer.h (+0/-2)
unity-shared/IconTexture.cpp (+1/-1)
unity-shared/IconTextureSource.cpp (+37/-1)
unity-shared/IconTextureSource.h (+10/-4)
unity-shared/LayoutSystem.cpp (+28/-4)
unity-shared/LayoutSystem.h (+2/-1)
unity-shared/PluginAdapter.cpp (+39/-2)
unity-shared/PluginAdapter.h (+3/-0)
unity-shared/SearchBar.cpp (+18/-12)
unity-shared/SearchBar.h (+9/-9)
unity-shared/SearchBarSpinner.h (+0/-2)
unity-shared/SpreadFilter.cpp (+3/-1)
unity-shared/StandaloneWindowManager.h (+2/-0)
unity-shared/TextInput.cpp (+138/-76)
unity-shared/TextInput.h (+17/-19)
unity-shared/UScreen.cpp (+26/-4)
unity-shared/UScreen.h (+0/-1)
unity-shared/UnitySettings.cpp (+9/-1)
unity-shared/WindowManager.h (+5/-0)
unity-shared/XWindowManager.cpp (+1/-1)
tags: | added: lockscreen |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → In Progress |
assignee: | nobody → Brandon Schaefer (brandontschaefer) |
tags: | added: hidpi |
Changed in unity: | |
assignee: | Brandon Schaefer (brandontschaefer) → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
assignee: | Brandon Schaefer (brandontschaefer) → Marco Trevisan (Treviño) (3v1n0) |
no longer affects: | unity/7.2 |
Changed in unity: | |
milestone: | none → 7.3.1 |
Changed in unity: | |
status: | In Progress → Fix Committed |
tags: |
added: verification-done removed: verification-needed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
This bug was fixed in the package unity - 7.3.1+14. 10.20140904- 0ubuntu1
--------------- 14.10.20140904- 0ubuntu1) utopic; urgency=low
unity (7.3.1+
[ Martin Pitt ]
* Adjust upstart dependency to upstart-bin. (LP: #1351306)
[ Brandon Schaefer ]
* When Show Desktop is active, it will set the tooltip icon as
"Restore Windows". This is per workspace. So each time show_destop
bool is updated in PluginAdapter, the Show Desktop icon will update
its tooltip if needed. (LP: #1237132)
* Use CONFIG instead of CACHE to store the first_run.stamp
[ Stephen M. Webb ]
* update the unity manpage (LP: #1059275)
[ Andrea Azzarone ]
* Share lockscreen password entry between screens. (LP: #1308540)
[ Marco Trevisan (Treviño) ]
* IconRenderer: draw count texture at proper scaling, built by
LauncherIcon (LP: #1353070)
* LauncherIcon: make the Icon count width depending on the text value
width (LP: #796527)
* Lockscreen: scale the UI elements based on current monitor scaling
(LP: #1292218)
* SwitcherView: set progress on icon render args (LP: #1361679)
* SearchBar, ActionButtons, IconRenderer: include the font scaling
when scaling textual items
-- Ubuntu daily release <email address hidden> Thu, 04 Sep 2014 22:12:54 +0000