Keyboard shortcuts overlay does not show up when workspaces are enabled at 1366x768
Bug #1317869 reported by
Jorge Morais
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
| 7.2 |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
| unity (Ubuntu) |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
Bug Description
[Impact]
The shortcut hint is not shown when workspaces are enabled in displays with 1366x768 resolution.
[Test case]
1. Run unity in a monitor with 1366x768 resolution.
2. From Unity Control Center -> Appearance -> Behavior -> enable the workspaces
3. Hold Super and keep it pressed, the shortcut should show up
[Regression potential]
The potential of regression is basically none, we just resized the view to make sure there's enough space for showing in smaller resolutions.
------------
My notebook has a 1366x768 screen - it is a very common screen resolution. When I boot Ubuntu 14.04 liveISO the keyboard shortcuts overlay is displayed and works very well - therefore my screen resolution is large enough for it. But after I installed 14.04 on my hard disk, the shortcuts overlay does not show anymore.
The attachment is a screenshot of the shortcuts overlay working on the liveISO.
Related branches
lp://qastaging/~3v1n0/unity/dynamic-shortcut-hint
- Andrea Azzarone (community): Approve
-
Diff: 268 lines (+95/-44)3 files modifiedshortcuts/ShortcutController.cpp (+1/-1)
shortcuts/ShortcutView.cpp (+85/-40)
shortcuts/ShortcutView.h (+9/-3)
lp://qastaging/~3v1n0/unity/shortcuts-hidpi
- Andrea Azzarone (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 333 lines (+123/-52)3 files modifiedshortcuts/ShortcutController.cpp (+1/-1)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
lp://qastaging/~unity-team/unity/7.2.2
- Marco Trevisan (Treviño): Approve
-
Diff: 3472 lines (+1152/-478)54 files modifiedUnityCore/GnomeSessionManager.cpp (+32/-0)
UnityCore/GnomeSessionManagerImpl.h (+4/-0)
UnityCore/SessionManager.h (+4/-0)
dash/DashController.cpp (+3/-1)
debian/changelog (+59/-0)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+20/-19)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+26/-10)
launcher/LauncherIcon.cpp (+7/-3)
launcher/LauncherIcon.h (+2/-1)
launcher/SwitcherView.cpp (+54/-31)
launcher/SwitcherView.h (+3/-4)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
lockscreen/LockScreenAbstractShield.h (+0/-1)
lockscreen/LockScreenController.cpp (+2/-3)
lockscreen/LockScreenShield.cpp (+0/-6)
lockscreen/LockScreenShield.h (+0/-1)
lockscreen/UserPromptView.cpp (+8/-99)
lockscreen/UserPromptView.h (+1/-13)
panel/PanelIndicatorEntryView.cpp (+7/-0)
plugins/unityshell/src/GesturalWindowSwitcher.cpp (+3/-0)
plugins/unityshell/src/GesturalWindowSwitcher.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+57/-50)
plugins/unityshell/src/unityshell.h (+2/-0)
po/POTFILES.in (+1/-0)
po/unity.pot (+70/-3)
shortcuts/ShortcutController.cpp (+4/-6)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
shutdown/SessionButton.cpp (+30/-5)
shutdown/SessionButton.h (+5/-0)
shutdown/SessionController.cpp (+2/-0)
shutdown/SessionView.cpp (+68/-27)
shutdown/SessionView.h (+5/-0)
tests/test-gestures/LockScreenControllerMock.h (+43/-0)
tests/test-gestures/sed_script_switcher (+2/-0)
tests/test-gestures/unityshell_mock.h (+8/-1)
tests/test_lockscreen_controller.cpp (+0/-1)
tests/test_switcher_view.cpp (+1/-2)
tests/test_unity_window_view.cpp (+9/-9)
unity-shared/EMConverter.cpp (+2/-2)
unity-shared/IMTextEntry.cpp (+7/-0)
unity-shared/IMTextEntry.h (+2/-0)
unity-shared/PluginAdapter.cpp (+43/-10)
unity-shared/RawPixel.cpp (+1/-1)
unity-shared/TextInput.cpp (+178/-4)
unity-shared/TextInput.h (+19/-4)
unity-shared/UnityWindowStyle.cpp (+135/-62)
unity-shared/UnityWindowStyle.h (+35/-20)
unity-shared/UnityWindowView.cpp (+53/-25)
unity-shared/UnityWindowView.h (+6/-0)
- Unity Team: Pending requested
-
Diff: 1674 lines (+1380/-30) (has conflicts)7 files modifiedCMakeLists.txt (+5/-0)
ChangeLog (+1162/-0)
debian/changelog (+77/-26)
debian/control (+1/-1)
po/unity.pot (+70/-3)
shutdown/SessionView.cpp (+55/-0)
shutdown/SessionView.h (+10/-0)
| affects: | ayatana-design → unity |
| summary: |
- Keyboard shortcuts overlay works fine on liveISO, but not after - installation + Keyboard shortcuts overlay does not show up when workspaces are enabled + at 1366x768 |
| Changed in unity: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| milestone: | none → 7.3.0 |
| Changed in unity: | |
| status: | Triaged → In Progress |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| status: | New → Fix Released |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → Low |
| description: | updated |
Revision history for this message
| Jorge Morais (jorgemorais) wrote | #2 |
| tags: | added: verification-done |
To post a comment you must log in.
This screenshot shows that the keyboard shortcuts overlay fits perfectly fine on a 1366x768 screen and therefore unity _should not disable it after installation_.