Quicklist drawing for checked/unchecked radio/check boxes is inverted
Bug #910286 reported by
Marco Trevisan (Treviño)
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
| Unity Distro Priority |
Fix Released
|
Undecided
|
Unassigned | ||
| unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
Bug Description
If you add a checkbox or radio quicklist item to the unity launcher, using libunity then if you set a dbusmenuitem of type radio or checkbox as checked, no check is actually shown in unity. While if you set it as unchecked the proper mark is shown.
This sample code underlines the issue: http://
Related branches
lp://qastaging/~3v1n0/unity/fixed-bad-quicklist-items-drawing
- Andrea Azzarone (community): Approve
- Mirco Müller (community): Needs Fixing
-
Diff: 1770 lines (+1118/-336)13 files modifiedplugins/unityshell/src/QuicklistMenuItemCheckmark.cpp (+9/-33)
plugins/unityshell/src/QuicklistMenuItemRadio.cpp (+11/-35)
plugins/unityshell/src/QuicklistView.cpp (+1/-2)
standalone-clients/CMakeLists.txt (+16/-8)
standalone-clients/TestFilterBar.cpp (+1/-1)
standalone-clients/TestFilters.cpp (+7/-7)
standalone-clients/nux_automated_test_framework.cpp (+461/-0)
standalone-clients/nux_automated_test_framework.h (+127/-0)
standalone-clients/nux_test_framework.cpp (+129/-0)
standalone-clients/nux_test_framework.h (+61/-0)
standalone-clients/ui/TestQuicklist.cpp (+269/-223)
standalone-clients/ui/TestQuicklistVisuals.cpp (+25/-27)
tests/unit/TestQuicklistMenuitems.cpp (+1/-0)
| Changed in unity: | |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| Changed in unity: | |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| importance: | Medium → High |
| Changed in unity (Ubuntu): | |
| status: | New → In Progress |
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) wrote | #1 |
| Changed in unity: | |
| milestone: | none → 5.0.0 |
| Changed in unity: | |
| milestone: | 5.0.0 → 5.2.0 |
Revision history for this message
| Dmitry Shachnev (mitya57) wrote | #2 |
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) wrote | #3 |
| Changed in unity-distro-priority: | |
| status: | New → Fix Committed |
| Changed in unity: | |
| milestone: | 5.2.0 → 5.4.0 |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
| Changed in unity: | |
| importance: | High → Medium |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | In Progress → Fix Committed |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| tags: | added: distro-priority |
| Changed in unity (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in unity-distro-priority: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The bug is even worst using disabled radio/checkbox: http://
See attached screenshot