Unity

Quicklist are not showing if right-clicking a launcher icon in Expo mode if triggered by Super + S

Bug #944979 reported by Marco Trevisan (Treviño)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz Core
Fix Released
Medium
Daniel van Vugt
Compiz Core 0.9.7.2
Unity
Fix Released
Medium
Sam Spilsbury
Unity Distro Priority
Fix Released
Medium
Unassigned
compiz (Ubuntu)
Fix Released
Undecided
Unassigned
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When in expo-mode, if right-clicking over a launcher icon, unity should terminate the expo and open a quicklist.

This is has been working for some releases, but it has currently broken by recent compiz updates in the case that the expo is initiated using the Super+S keyboard binding (it doesn't happen if changing the keybinding to something not using Super).

After some research, I've found that when the expo is initiated using the default Super+S keybinding, no NotifyGrab event happens in the time that goes from the super-keypress to the super-keyrelease (or later).
Due to this, PluginAdapter is not notified of the current expo status, and so it won't emit any event when it terminates (that's why no quicklist is opened at this point).

An ugly workaround for this is just adding something like:
  PluginAdapter::Default()->OnScreenGrabbed();
  PluginAdapter::Default()->OnScreenUngrabbed();

in UnityScreen::showLauncherKeyTerminate as this forces PluginAdapter to check if the expo is really active when super is released. But this doesn't fix at all the base issue.

Edit: could be possibly related to the fix for bug #934058 ?

See original description

Related branches

lp://qastaging/~vanvugt/compiz-core/fix-alt-bugs
Alan Griffiths: Approve
Diff: 160 lines (+36/-15)
4 files modified
metadata/core.xml.in (+7/-0)
src/event.cpp (+25/-6)
src/privatescreen.h (+1/-2)
src/screen.cpp (+3/-7)
lp://qastaging/~compiz/compiz/ubuntu
lp://qastaging/ubuntu/precise/compiz
Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
status: New → Confirmed
importance: Undecided → Medium
Changed in compiz-core:
status: New → Triaged
Changed in unity:
status: Confirmed → Triaged
Changed in compiz-core:
importance: Undecided → Medium
Marco Trevisan (Treviño) (3v1n0)
description: updated
Marco Trevisan (Treviño) (3v1n0)
Changed in compiz-core:
assignee: nobody → Sam Spilsbury (smspillaz)
Changed in unity:
assignee: nobody → Sam Spilsbury (smspillaz)
Marco Trevisan (Treviño) (3v1n0)
description: updated
Didier Roche-Tolomelli (didrocks)
summary: Quicklist are not showing if right-clicking a launcher icon in Expo mode
+ if triggered by Super + S
Changed in unity-distro-priority:
status: New → Fix Committed
importance: Undecided → Medium
Didier Roche-Tolomelli (didrocks)
Changed in unity:
status: Triaged → Fix Committed
Changed in compiz-core:
assignee: Sam Spilsbury (smspillaz) → Daniel van Vugt (vanvugt)
status: Triaged → Fix Committed
Daniel van Vugt (vanvugt)
Changed in compiz-core:
milestone: none → 0.9.7.2
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Merged into lp:compiz-core at revision 3046

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.7.0+bzr3035-0ubuntu1

---------------
compiz (1:0.9.7.0+bzr3035-0ubuntu1) precise; urgency=low

  [ Łukasz 'sil2100' Zemczak ]
  * New upstream snapshot:
    - Fix gtk-window-decorator crash upon demaximizing a window (LP: #930071)
    - Fix core keybindings (LP: #930412)
    - Fixes compiz crash with SIGSEGV on shutdown (LP: #931283)
    - Plugins can't tell the difference between a key-tap and modifier
      key-release (LP: #925293)
    - compiz-core r3001 (and 3002) ftbfs (LP: #933226)
    - Semi-maximized windows have no shadow or frame (LP: #924736)
    - Untranslated strings in gtk-window-decorator (LP: #780505)
    - Initialize the _NET_WM_STATE_FOCUSED (LP: #932087)
    - [regression] Customized shortcuts don't work (LP: #931927)
    - Window stacking problem (LP: #936675)
    - Quickly demaximized windows can receive maximized window decorations if
      they were initially maximized (LP: #936778)
    - Maximized windows do not get shadows at all (LP: #936774)
    - [regression] Launcher, top panel and keyboard un-responsive after using
      any Super-x shortcut (LP: #934058)
    - No draggable border if mutter isn't installed (LP: #936781)
    - Fix compiz crash with SIGSEGV in XDefineCursor() (LP: #936487)
    - Fixes memory leak at DecorWindow::updateSwitcher() (LP: #940115)
    - Unresolved symbols in plugins cause compiz to exit (LP: #938478)
    - Fix compiz spending about 51% of its CPU time in CompRegion
      construction/destruction (LP: #940139)
    - Fix Conditional jump or move depends on uninitialised value(s) in
      decor_match_pixmap (LP: #940066)
    - Fix 'show desktop' behaviour (LP: #871801)
    - Tweak algorithm used to cast shadows on maximized windows (LP: #936784)
    - "Svg" and "Png" should be "SVG and "PNG" (LP: #942890)
    - Fix invalid memory usage after free() in DecorWindow (LP: #943116)
    - Fix alt + F10 (LP: #943223)
  * Removed cherry-picked patches
  * debian/patches/fix_944631.patch:
    - Always replay the keyboard if something was grabbed and didn't trigger
      an action and don't trigger actions which aren't added accidentally
      (LP: #943612) (LP: #944631)
  * debian/patches/fix_923683.patch:
    - Backports a patch which prevents the shift race condition

  [ Didier Roche ]
  * debian/patches/fix_alt_pressing.patch:
    - Patch from ddv to fix all the regressions with the alt key fix and other
      (LP: #943851, #945373)
    - Fix Quicklist are not showing if right-clicking a launcher icon in Expo
      mode if triggered by Super + S (LP: #944979)
  * debian/patches/fix_806255.patch:
    - Unity/compiz intercepts keystrokes from grabbed windows (LP: #806255)
  * debian/patches/fix_943194.patch:
    - second part for the alt key fix (LP: #943194)
  * debian/patches/additional_alt_tapping_fix.patch:
    - again another alt tapping related fix for some regressions from the
      previous branch. Taken from "tapping-panacea" upstream branch.
 -- Didier Roche <email address hidden> Mon, 12 Mar 2012 10:22:10 +0100

Changed in compiz (Ubuntu):
status: New → Fix Released
Didier Roche-Tolomelli (didrocks)
Changed in unity:
status: Fix Committed → Fix Released
Changed in compiz-core:
status: Fix Committed → Fix Released
Changed in unity (Ubuntu):
status: New → Fix Released
Daniel van Vugt (vanvugt)
Changed in compiz-core:
status: Fix Released → Fix Committed
Daniel van Vugt (vanvugt)
Changed in compiz-core:
status: Fix Committed → Fix Released
Didier Roche-Tolomelli (didrocks)
Changed in unity-distro-priority:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.