make input_parameters part of the Loadable interface
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
watcher |
New
|
Wishlist
|
Pradeep Kumar Singh |
Bug Description
From irc chat
<vincentfrancoise> pksingh: take a look at https:/
<vincentfrancoise> pksingh: if you have a look at https:/
<pksingh> vincentfrancoise: yes
<vincentfrancoise> pksingh: you see that input_parameters (which are additional options that you specify to the audit and are passed down to the strategy)
<pksingh> vincentfrancoise: ok
* vmahe_ (uid116507@
<vincentfrancoise> pksingh: and these input_parameters are not injected at the construction of the Strategy objects
<vincentfrancoise> pksingh: instead they are set after instantiation
<pksingh> vincentfrancoise: correct
<vincentfrancoise> pksingh: that forces us to do https:/
<vincentfrancoise> pksingh: to do some lazyloading
<pksingh> vincentfrancoise: ok
<vincentfrancoise> pksingh: and we actually "hope" it's going to be there when we get to it
<pksingh> vincentfrancoise: through the getter?
<vincentfrancoise> pksingh: so the idea would be to make it part of the Loadable interface
<vincentfrancoise> pksingh: https:/
<pksingh> vincentfrancoise: ok
<vincentfrancoise> pksingh: all plugins in Watcher inherit from this class that acts like an interface
<pksingh> vincentfrancoise: k
<vincentfrancoise> pksingh: this is a simple problem but it requires a lot of refactoring
* vmahe_
<pksingh> vincentfrancoise: agree
<vincentfrancoise> pksingh: but you don't really add a new feature so that should make things easier
Changed in watcher: | |
importance: | Undecided → Wishlist |
Changed in watcher: | |
assignee: | nobody → Pradeep Kumar Singh (pradeep-singh-u) |
IRC link for the chat: eavesdrop. openstack. org/irclogs/ %23openstack- watcher/ %23openstack- watcher. 2017-01- 25.log. html
http://