Widelands Website

Wiki article was last changed tomorrow

Bug #811686 reported by Hans Joachim Desserud on 2011-07-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Widelands Website	Fix Released	Medium	Unassigned

Bug Description

When users are logged in, wiki changes or forum posts from the same day is converted from the actual date to "today". This is quite neat, however it is strangely enough possible to edit a wiki article and be informed that it was last changed tomorrow. I managed to trigger this by updating an article late in the evening. I use default time zone / time display.

I assume the reason is due to differences between time zones near midnight which turns what is today in one time zone into tomorrow in another. Still it looks a bit weird. I am not sure if this is solvable without removing the conversion from [current_date] to "today". I am not sure if it should be done either, as I can easily live with the current behaviour.

Related branches

lp://qastaging/~janus-jhor/widelands-website/website-wl.jhor.de

Revision history for this message

Hans Joachim Desserud (hjd) wrote on 2011-07-16:

screenshot of a wiki article edited tomorrow Edit (19.0 KiB, image/png)

janus (janus-jhor) on 2011-07-16

Changed in widelands-website:
importance:	Low → Medium
status:	New → In Progress

kaputtnik (franku) on 2015-08-31

Changed in widelands-website:
status:	In Progress → Confirmed

Revision history for this message

kaputtnik (franku) wrote on 2016-12-11:

We may have to consider the whole timezone support in our project. For example we use

USE_TZ=False

which causes the using of local time, afaik.

See: https://docs.djangoproject.com/en/1.10/topics/i18n/timezones/
Especially when changing USE_TZ: https://docs.djangoproject.com/en/1.10/topics/i18n/timezones/#migration-guide

Revision history for this message

Hans Joachim Desserud (hjd) wrote on 2016-12-23:

Timezones and USE_TZ was also briefly discussed in an earlier attempt to upgrade to a newer Django version (https://code.launchpad.net/~shevonar/widelands-website/django1.4/+merge/143219). I haven't been paying too close attention, but from what I've understand Django has been upgraded in the mean time. I think it was intially delayed since it would require updating the existing timestamps in the db, and that it wasn't a requirement for newer Django which was the main focus. As you say, it might be time to look more into this again.