xdiagnose needs root privilege to create /etc/default/grub.bak
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
xdiagnose |
Fix Released
|
Medium
|
Unassigned | ||
xdiagnose (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Precise |
Fix Released
|
Medium
|
Unassigned | ||
Quantal |
Fix Released
|
High
|
Unassigned | ||
Raring |
Fix Released
|
Medium
|
Unassigned |
Bug Description
[Impact]
xdiagnose requires root permission to run, otherwise it crashes when it tries to update the grub configuration.
This is showing up in the automatically collected errors:
https:/
This shows the issue affects precise, quantal, and raring users, with quantal being the most heavily affected.
[Testcase]
1. Open xterm window
2. Run `xdiagnose` as a non-root user
3. Change some grub settings
4. Click apply
Expected behavior: At step 2, remind user to run app as superuser.
Actual behavior: Crashes at step 4
[Fix]
A partial fix was added to the .desktop file, which made xdiagnose use gksu/pkexec to request root permissions when run from the menus. However, xdiagnose can also be run directly from X terminals. To address this case it needs to check if it's run as root at startup, and if not print an error so the user knows to run it with sudo or similar.
[Regression Risk]
The patch is very trivial and non-invasive so not likely to cause regressions. Also, the application is for diagnostic purposes so the impact of a regression in this tool is pretty minor.
[Original Report]
Hello
Launching the xdiagnose gui from the icon, it start, accept the checkboxes variation but when i click apply it don't require me the password to read the grub file.
Launching it from terminal it return the permission denied error.
Thanks
Fabio
Changed in xdiagnose: | |
status: | New → Confirmed |
Changed in xdiagnose (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in xdiagnose (Ubuntu Quantal): | |
importance: | Medium → High |
summary: |
- xdiagnose need root previlege to create /etc/default/grub.bak + xdiagnose needs root privilege to create /etc/default/grub.bak |
description: | updated |
description: | updated |
Changed in xdiagnose (Ubuntu Precise): | |
status: | New → Fix Committed |
Changed in xdiagnose (Ubuntu Quantal): | |
status: | Triaged → Fix Committed |
Changed in xdiagnose (Ubuntu Raring): | |
status: | Triaged → Fix Committed |
Changed in xdiagnose (Ubuntu Precise): | |
importance: | Undecided → Medium |
description: | updated |
Changed in xdiagnose (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in xdiagnose: | |
status: | Triaged → New |
status: | New → Incomplete |
status: | Incomplete → Opinion |
status: | Opinion → Invalid |
status: | Invalid → Confirmed |
status: | Confirmed → In Progress |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |
Agreed this is annoying from a usability standpoint. I'm thinking I should investigate policykit for this.