| 2016-11-24 14:30:00 |
hongbin |
description |
See @Shubham's comment in review https://review.openstack.org/#/c/396896/ :
If we are at this line then we can safely assume that sandbox container for this container was started successfully. But here container creation has failed but respective sandbox container will still be in running state. Should we stop corresponding sandbox container?
If we do not do that then we will have sandbox containers piled up for each failed instance of container create .
Right now, the sandbox container is always running when the normal container is created. An improvement is to stop the sandbox container when the normal container is stopped. Consider this as an optional improvement. |
See @Shubham's comment in review https://review.openstack.org/#/c/396896/ :
If we are at this line then we can safely assume that sandbox container for this container was started successfully. But here container creation has failed but respective sandbox container will still be in running state. Should we stop corresponding sandbox container?
If we do not do that then we will have sandbox containers piled up for each failed instance of container create .
Right now, the sandbox container is always running when the normal container is created. An improvement is to stop the sandbox container when the normal container is stopped. Consider this as an optional improvement. We don't need this right away. |
|
