Comment 14 for bug 894997

Revision history for this message
AlexB (alexander-b) wrote :

Is the target unit a train?
Ok, found the problem. NonVehicle is still obeyed because a certain function checks for it. I can exclude the function (it's sole purpose is to return whether something is to be considered a unit), but it will allow buildings to be captured as well (Hijacker.Allowed defaults to yes).

A) Leave this check as it is, but simply do not use it for units. NonVehicle would have no effect anymore. Buildings aren't affected.
B) Remove the check altogether. This would allow non-undeploable buildings with non-1x1-foundations to be hijacked also. Mind the default; you'd have to change all buildings a hijacker shouldn't try to steal.
C) Option B, but changing the default to yes for all units, and no for all buildings. The default will only depend on the type, no support for fancy things like ConsiderBuildingAircraft or any other tag (thus, it cannot include the foundation).

Which one shall it be? I vote for A, because it is the solution with the smallest scope and it doesn't introduce any new features.