Probetests do not run successfully

Bug #1014931 reported by Maru Newby
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Undecided
gholt

Bug Description

- .probetests was run on a clean SAIO build
- all tests failed due to swift.common.client not being present (having been moved to swiftclient)
- updated test imports to point to swiftclient.client
- tests ran with reported errors: FAILED (errors=1, failures=5)

Note that .unittests and .functests ran without error in the same environment.

I can post the test output if required, but it is really long and anybody investigating this issue would presumably see the same output.

Given the failure to update probetests after the swiftclient move, I'm guessing that probetests aren't part of any gating job. Should they be? Are they considered useful enough to maintain?

Revision history for this message
Chmouel Boudjnah (chmouel) wrote :

As mentionned in the SAIO document (http://swift.openstack.org/development_saio.html) you need to check out python-swiftclient and install it before to be able to run the tests. If you were using tox it would do that automatically.

Changed in swift:
status: New → Invalid
Maru Newby (maru)
Changed in swift:
status: Invalid → New
Revision history for this message
Chmouel Boudjnah (chmouel) wrote :

After discussion with Maru it is indeed a bug.

Revision history for this message
Maru Newby (maru) wrote :

I followed the SAIO instructions. Installing python-swiftclient does not solve the problem because the tests in test/probe are importing the wrong thing:

from swift.common import client

instead of

from swiftclient import client

Note that tox only runs the unittests, not the probetests.

Changed in swift:
assignee: nobody → gholt (gholt)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/9049
Committed: http://github.com/openstack/swift/commit/be79b0884eb7ba91836c5296aec92cf6066be767
Submitter: Jenkins
Branch: master

commit be79b0884eb7ba91836c5296aec92cf6066be767
Author: gholt <email address hidden>
Date: Wed Jun 27 05:01:55 2012 +0000

    Fixes for probe tests

    Updated the imports and added a head_account to the "is the cluster
    started yet?" checks. Hopefully this fixes the notorious timing
    issues of these tests where auth answers requests just a bit before
    the rest of the cluster is ready.

    Fixes bug 1014931

    Change-Id: Iea1d62db2317560371da49af5e94a0279b646294

Changed in swift:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in swift:
milestone: none → 1.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.