TPAC: Complete column sorting in some screens

Great, but where is this test implementation? If you've identified the issue and already done the work (or most of the work), please share the code!

It's coming! I'm a newbie at this stuff.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/exsort

Withdrawing pullrequest to do more checking

Restored pullrequest, along with an amended commit. Same branch.

The code needed to support the multi-page presentation.

Hey Dan,

I'm adding a needsreleasenote tag to this. Although it's a smallish enhancements, it probably warrants an entry in the next release notes. You can add the entry in docs/RELEASE_NOTES_NEXT.

Kathy

In the sort_head() block you're wrapping the variable containing the translatable string in l(). I believe this causes problems for i18n.

So, instead of :

sort_head("sort_title", "Title")

You should wrap translatable strings directly in the l() macro:

sort_head("sort_title", l("Title"))

I can easily address Pasi's concern in a collab branch, unless Dan Pearl beats me to it.

Dan Pearl's branch needs a rebase on master. There are conflicts in Open-ILS/src/templates/opac/css/style.css.tt2 and Open-ILS/src/templates/opac/parts/misc_util.tt2. While I was confident that I can resolve the first one, I'm not as confident on the second.

I am going to remove the pullrequest tag until such time as Dan or someone rebases the branch and addresses Pasi's i18n concerns above.

I'll take care of rebase. Thanks klussier for the alert.

Now in place. Release notes added.

New branch to include rebase:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/exsort1

I loaded Dan's branch on my development machine this afternoon and had a quick look.

Overall, it looks like the branch does what is says on the tin. My only nit is that the triangle that appears next to the header of the field that is being sorted does not also cause the sort to happen. Typically, those icons are clickable just like the text label next to them. My expectation when clicking it would be the same as what happens when click the sort field again, it would reverse the direction of the sort.

Something else that I have noticed after loading this branch. There is now a discrepancy in the headers between the different places where sorting can happen in the patron's account area.

For instance, sorting my list entries does not add the triangle to the header, and the column sizes to do not appear to adjust.

When sorting in a patron's circ_history with Dan's code, I get the triangle, and the column widths appear to change. (It is rather odd sorting by author, when a patron has dozens of things with no author in their history.)

I think it would be beneficial to make the look consistent with the different "tables" that get sorted in the My Account area.

Pushed an UNTESTED rebased branch with some minor merge conflicts resolved to:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/berick/lp1086934-tpac-col-sort-rebase

Tossing this into a bug-squashing-day test branch....

Newly rebased branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1086934-tpac-col-sort-rebase

Works for me. Signed off at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1086934-tpac-col-sort

Pushed to master, thanks for testing Kathy.