swift_store_admin_tenants not working as expected

A patch like this:

sam:glance$ git diff
diff --git a/glance/api/v1/controller.py b/glance/api/v1/controller.py
index 2234303..8b74e5d 100644
--- a/glance/api/v1/controller.py
+++ b/glance/api/v1/controller.py
@@ -76,9 +76,9 @@ class BaseController(object):
                             write_tenants.append(member['member_id'])
                         else:
                             read_tenants.append(member['member_id'])
- store.set_acls(req.context, location_uri, public=public,
- read_tenants=read_tenants,
- write_tenants=write_tenants)
+ store.set_acls(req.context, location_uri, public=public,
+ read_tenants=read_tenants,
+ write_tenants=write_tenants)
             except exception.UnknownScheme:
                 msg = _("Store for image_id not found: %s") % image_id
                 raise webob.exc.HTTPBadRequest(explanation=msg,

which is consistent with the v2 equivalent, makes the acls appear:

$ swift --os-password hpinvent --os-tenant-name service --os-username glance --os-auth-url http://localhost:35357/v2.0 stat glance_44e4144b-4345-4875-9a5c-de25495914e1
  Account: AUTH_0e041755ac31411ba7ac0c8393bf51f9
Container: glance_44e4144b-4345-4875-9a5c-de25495914e1
  Objects: 1
    Bytes: 731
 Read ACL: .r:* <<<<
Write ACL: 0e041755ac31411ba7ac0c8393bf51f9 <<<<<
  Sync To:
 Sync Key:
Accept-Ranges: bytes
X-Timestamp: 1359479432.37732
X-Trans-Id: txe055679ebbe546419e0a1bf4471de43d
Content-Type: text/plain; charset=utf-8

Fix proposed to branch: master
Review: https://review.openstack.org/20718

Reviewed: https://review.openstack.org/20718
Committed: http://github.com/openstack/glance/commit/1b5409341099c869607d02e874d0476b4c959c42
Submitter: Jenkins
Branch: master

commit 1b5409341099c869607d02e874d0476b4c959c42
Author: Stuart McLaren <email address hidden>
Date: Tue Jan 29 16:46:46 2013 +0000

    Ensure swift_store_admin_tenants ACLs are set

    When using the V1 api ensure that admin tenant ACLs are set
    correctly on the relevant swift container.

    Fixes bug 1109089.

    Change-Id: I275e8aa7d2f02859c0d9ddbf373a0ae51e81e53d

Hi,

I have also a wrong behavious when using admin_tenats list, but the problem doesn't seem to have the same root cause.
I'm testing on icehouse (git >> 2c4bd695652a628758eb56cb36394940a855d696)

Here how to reproduce:
http://paste.openstack.org/show/61570/

I have two problem here
* The admin tenant list seems to be applied to only the write ACL.
* Whatever the value of the admin_tenants list, the string ":*" is added to the list, which will result in having a bad format or the ACL string, Swift accept this string format but will end up with an error when countainer is accessed by glance. Making the image unusable in some cases

I checked the code and we can easily see the problem here.
in glance.store.swift
  http://paste.openstack.org/show/61574/

Fix proposed to branch: master
Review: https://review.openstack.org/67875