Cinder

create_cloned_volume calls non-existant method '_sizestr'

Bug #1112485 reported by Rushi Agrawal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Avishay Traeger
Cinder 2013.1 "grizzly"

Bug Description

The method create_cloned_volume is located in cinder/volume/driver.py

Avishay Traeger (avishay-il)
Changed in cinder:
assignee: nobody → Avishay Traeger (avishay-il)
status: New → Confirmed
assignee: Avishay Traeger (avishay-il) → nobody
assignee: nobody → Avishay Traeger (avishay-il)
Revision history for this message
Avishay Traeger (avishay-il) wrote :

This goes beyond _sizestr ; also _create_volume() and _copy_volume() are defined in LVMVolumeDriver and not driver.py. My guess is that this was a merging error. Will move the function to LVMVolumeDriver.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21416

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/21416
Committed: http://github.com/openstack/cinder/commit/033d21f6f0a93ab664d7615e2c71486c7fbce03a
Submitter: Jenkins
Branch: master

commit 033d21f6f0a93ab664d7615e2c71486c7fbce03a
Author: Avishay Traeger <email address hidden>
Date: Thu Feb 7 11:11:03 2013 +0200

    Move create_cloned_volume() to LVMVolumeDriver.

    The implementation of create_cloned_volume() that was in driver.py
    relied on functions that aren't declared there, such as
    _create_volume(), _copy_volume(), and _sizestr(). Moved the function
    to LVMVolumeDriver in lvm.py, where those functions exist.

    Change-Id: I5ab77a119b3af0a152a3b5e0c2ff6a5ce196ad0f
    Fixes: bug #1112485

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.