Cinder

rtslib dependency (AGPL) should be made optional

Bug #1157091 reported by Thierry Carrez
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith
Cinder 2013.1 "grizzly"

Bug Description

From Sean Dague on the ML:

rtslib is currently listed as a dependency for cinder. The package itself is AGPL, which has some rather strong requirements for a cloud provider using it (https://github.com/agrover/rtslib-fb/blob/master/COPYING).

It's currently used only in bin/cinder-rtstool, so it's largely isolated in it's use. However given that the spirit of the OpenStack project was Apache 2 style licensing, it's a bit odd to have an AGPL dependency that really means cinder-rtstool is AGPL (even though it says Apache2 in the header).

This was a grizzly addition that originally landed in test-requires here:
commit 1fc557561b711f6edb06cf28edb0f90900e2c21e

And then moved to pip requires here:
commit 2443e35d8c2370f39f9bf0b3cda523103af3f261

Revision history for this message
Thierry Carrez (ttx) wrote :

John suggested:

One possible solution is that since the LIO driver is an optional config
we could remove it from pip-requires and packaging and add information
to the install/config guide for folks that want to use LIO with a note
about the licensing. If nothing else this may at least be prudent for
Grizzly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24780

Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/24780
Committed: http://github.com/openstack/cinder/commit/7bb449aa5a0a069cc6df918acc33bf550fbd5834
Submitter: Jenkins
Branch: master

commit 7bb449aa5a0a069cc6df918acc33bf550fbd5834
Author: john-griffith <email address hidden>
Date: Tue Mar 19 09:02:52 2013 -0600

    Remove AGPL rtslib pkg from pip-requires.

    Fixes bug: 1157091

    Change-Id: I1879712ab33324740496b284500fa2b22a1bc310

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24802

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/24815

Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → In Progress
Revision history for this message
Eric Harney (eharney) wrote :

rtstool has been split out to https://pypi.python.org/pypi/rtstool now.

https://review.openstack.org/#/c/24840/ along with https://review.openstack.org/#/c/24815/ should have this covered.

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/24815
Committed: http://github.com/openstack/cinder/commit/b66c3361be2095186e19b0d44e49a8b2c48f7235
Submitter: Jenkins
Branch: master

commit b66c3361be2095186e19b0d44e49a8b2c48f7235
Author: Sean Dague <email address hidden>
Date: Tue Mar 19 15:30:26 2013 -0400

    remove cinder-rtstool because of rtslib dep

    rtslib is AGPL, so cinder-rtstool is defacto AGPL by importing it.
    Remove cinder-rtstool from the OpenStack repository.

    Fixes bug #1157091

    Change-Id: I30c9ee19d43107fa7f2e5e65d69049b8d69d2bdf

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25095

Thierry Carrez (ttx)
tags: removed: grizzly-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/25095
Committed: http://github.com/openstack/cinder/commit/6e376a74c88dc8b5a096cef8181c9edd0c1a090e
Submitter: Jenkins
Branch: milestone-proposed

commit 6e376a74c88dc8b5a096cef8181c9edd0c1a090e
Author: Sean Dague <email address hidden>
Date: Tue Mar 19 15:30:26 2013 -0400

    remove cinder-rtstool because of rtslib dep

    rtslib is AGPL, so cinder-rtstool is defacto AGPL by importing it.
    Remove cinder-rtstool from the OpenStack repository.

    Fixes bug #1157091

    Change-Id: I30c9ee19d43107fa7f2e5e65d69049b8d69d2bdf
    (cherry picked from commit b66c3361be2095186e19b0d44e49a8b2c48f7235)

Changed in cinder:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25405

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/25405
Committed: http://github.com/openstack/cinder/commit/e9b07388f1b35ace0cb296148135723df6bef753
Submitter: Jenkins
Branch: milestone-proposed

commit e9b07388f1b35ace0cb296148135723df6bef753
Author: john-griffith <email address hidden>
Date: Tue Mar 19 09:02:52 2013 -0600

    Remove AGPL rtslib pkg from pip-requires.

    Fixes bug: 1157091

    Change-Id: I1879712ab33324740496b284500fa2b22a1bc310
    (cherry picked from commit 7bb449aa5a0a069cc6df918acc33bf550fbd5834)

Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-rc2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.