OpenStack Compute (nova)

sql_connection not marked secret

Bug #1160680 reported by Michael Fork on 2013-03-27

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Cinder	Fix Released	Medium	Michael Fork	Cinder 2013.2 "havana"
Grizzly	Fix Released	Undecided	Unassigned	Cinder 2013.1.1
Glance	Invalid	Undecided	Unassigned
OpenStack Compute (nova)	Fix Released	Medium	Oleg Bondarev	OpenStack Compute (nova) 2013.2 "havana"
Grizzly	Fix Released	Medium	Vish Ishaya	OpenStack Compute (nova) 2013.1.1
OpenStack Identity (keystone)	Fix Released	Undecided	Michael Fork	OpenStack Identity (keystone) 2013.2 "havana"
Folsom	Won't Fix	Undecided	Unassigned
neutron	Fix Released	Medium	Roman Podoliaka	neutron 2013.2 "havana"
Grizzly	Fix Released	Undecided	Unassigned	neutron 2013.1.1
oslo-incubator	Fix Released	Medium	Michael Fork	oslo-incubator 2013.2 "havana"
Grizzly	Fix Committed	Medium	Mark McLoughlin

Bug Description

sql_connection contains the password in plain text, but it not marked secret and could cause the password to be logged.

OpenStack Infra (hudson-openstack) on 2013-03-27

Changed in oslo:
assignee:	nobody → Michael Fork (mjfork)
status:	New → In Progress

yong sheng gong (gongysh) on 2013-03-27

Changed in quantum:
status:	New → Confirmed
importance:	Undecided → Medium
milestone:	none → havana-1

Roman Podoliaka (rpodolyaka) on 2013-03-27

Changed in quantum:
assignee:	nobody → Roman Podolyaka (rpodolyaka)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-27: Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25500

Changed in quantum:
status:	Confirmed → In Progress

Oleg Bondarev (obondarev) on 2013-03-27

Changed in nova:
assignee:	nobody → Oleg Bondarev (obondarev)

OpenStack Infra (hudson-openstack) on 2013-03-27

Changed in nova:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-27: Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/25481
Committed: http://github.com/openstack/oslo-incubator/commit/f79915ec1d975219719e0ba99128d7c62398ae0a
Submitter: Jenkins
Branch: master

commit f79915ec1d975219719e0ba99128d7c62398ae0a
Author: Michael J Fork <email address hidden>
Date: Wed Mar 27 02:34:49 2013 +0000

Mark sql_connection with secret flag

sql_connection contains the password in some setups and marking as
secret prevents accidental logging

fixes bug 1160680

Change-Id: Ib2d00219ea40a010c62e6a29045309f030e6de28

Changed in oslo:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-27: Fix merged to quantum (master)

Reviewed: https://review.openstack.org/25500
Committed: http://github.com/openstack/quantum/commit/b5e6c2c8556927efb6de9de1e7c19e0aab450b10
Submitter: Jenkins
Branch: master

commit b5e6c2c8556927efb6de9de1e7c19e0aab450b10
Author: Roman Podolyaka <email address hidden>
Date: Wed Mar 27 07:59:39 2013 +0200

Mark 'sql_connection' config option as secret

Fixes bug 1160680.

Change-Id: I42b16d006f162cb41090fa34677d6ad054b6a55a

Changed in quantum:
status:	In Progress → Fix Committed

Eugene Nikanorov (enikanorov) on 2013-03-27

Changed in nova:
milestone:	none → havana-1

Michael Fork (mjfork) on 2013-03-28

Changed in glance:
assignee:	nobody → Michael Fork (mjfork)
Changed in keystone:
assignee:	nobody → Michael Fork (mjfork)
Changed in cinder:
assignee:	nobody → Michael Fork (mjfork)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-28: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25584

Changed in cinder:
status:	New → In Progress

Revision history for this message

Michael Fork (mjfork) wrote on 2013-03-28:

After further investigation, found out that sql_connection is marked secret in Glance.

Changed in glance:
assignee:	Michael Fork (mjfork) → nobody
status:	New → Invalid

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-28: Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25585

Changed in keystone:
status:	New → In Progress

Revision history for this message

Oleg Bondarev (obondarev) wrote on 2013-03-28:

The bug doesn't need to be fixed in Nova as it was already fixed in oslo and will be merged to Nova.

Changed in nova:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-28: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25607

Revision history for this message

Alan Pevec (apevec) wrote on 2013-03-28:

I'd like to propose this to Folsom series in all projects, any objections?

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-29: Fix merged to cinder (master)

#10

Reviewed: https://review.openstack.org/25584
Committed: http://github.com/openstack/cinder/commit/9f8ee9d2981c5f317139e3743385b59956546d65
Submitter: Jenkins
Branch: master

commit 9f8ee9d2981c5f317139e3743385b59956546d65
Author: Michael J Fork <email address hidden>
Date: Thu Mar 28 02:58:04 2013 +0000

Mark sql_connection with secret flag

sql_connection contains the password in some setups and marking as
secret prevents accidental logging

fixes bug 1160680

Change-Id: I3704237d0923bb30138b5ece7e5c7bbda0a78b9b

Changed in cinder:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-29: Fix merged to nova (master)

#11

Reviewed: https://review.openstack.org/25607
Committed: http://github.com/openstack/nova/commit/6ff9c9effe011cb7d8d5479ec8cd2f6c7f61705c
Submitter: Jenkins
Branch: master

commit 6ff9c9effe011cb7d8d5479ec8cd2f6c7f61705c
Author: Michael J Fork <email address hidden>
Date: Thu Mar 28 11:57:29 2013 +0000

sync oslo db/sqlalchemy module

sync oslo db/sqlalchemy module to grab "Mark sql_connection with secret
flag" change.

fixes bug 1160680

Change-Id: Id48419624c41eea5a0f2e130d7cdbe8a8f0a9118

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-29: Fix merged to keystone (master)

#12

Reviewed: https://review.openstack.org/25585
Committed: http://github.com/openstack/keystone/commit/ee0e4be91ea6010bebed3a63e531f24063dcfa4c
Submitter: Jenkins
Branch: master

commit ee0e4be91ea6010bebed3a63e531f24063dcfa4c
Author: Michael J Fork <email address hidden>
Date: Thu Mar 28 03:09:58 2013 +0000

Mark sql connection with secret flag

sql connection parameter contains the password in some setups and
marking as secret prevents accidental logging

fixes bug 1160680

Change-Id: I093d9c6556197ec25cb63bf16bcc90bb9679fed0

Changed in keystone:
status:	In Progress → Fix Committed

Mark McLoughlin (markmc) on 2013-03-29

Changed in oslo:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-29: Fix proposed to oslo-incubator (stable/grizzly)

#13

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/25724

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-29: Fix merged to oslo-incubator (stable/grizzly)

#14

Reviewed: https://review.openstack.org/25724
Committed: http://github.com/openstack/oslo-incubator/commit/07ce6a36c35e07169e11178e6a48340e2ed1b1c9
Submitter: Jenkins
Branch: stable/grizzly

commit 07ce6a36c35e07169e11178e6a48340e2ed1b1c9
Author: Michael J Fork <email address hidden>
Date: Wed Mar 27 02:34:49 2013 +0000

Mark sql_connection with secret flag

sql_connection contains the password in some setups and marking as
secret prevents accidental logging

fixes bug 1160680

Change-Id: Ib2d00219ea40a010c62e6a29045309f030e6de28
(cherry picked from commit f79915ec1d975219719e0ba99128d7c62398ae0a)

Neela Shah (neela) on 2013-04-03

tags:

added: grizzly-backport-potential

Vish Ishaya (vishvananda) on 2013-04-04

Changed in nova:
importance:	Undecided → Medium

John Griffith (john-griffith) on 2013-04-04

Changed in cinder:
importance:	Undecided → Medium
milestone:	none → havana-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-04-05: Fix proposed to quantum (stable/grizzly)

#15

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/26196

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-04-11: Fix merged to quantum (stable/grizzly)

#16

Reviewed: https://review.openstack.org/26196
Committed: http://github.com/openstack/quantum/commit/61e63789c5998026f47313f6dfa93824d871186f
Submitter: Jenkins
Branch: stable/grizzly

commit 61e63789c5998026f47313f6dfa93824d871186f
Author: Roman Podolyaka <email address hidden>
Date: Wed Mar 27 07:59:39 2013 +0200

Mark 'sql_connection' config option as secret

Fixes bug 1160680.

Change-Id: I42b16d006f162cb41090fa34677d6ad054b6a55a

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-04-11: Fix proposed to cinder (stable/grizzly)

#17

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/26767

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-04-12: Fix proposed to nova (stable/grizzly)

#18

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/26874

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-04-12: Fix merged to cinder (stable/grizzly)

#19

Reviewed: https://review.openstack.org/26767
Committed: http://github.com/openstack/cinder/commit/2113fe1832a305ccaf1093ccf866adbd20d2f5ac
Submitter: Jenkins
Branch: stable/grizzly

commit 2113fe1832a305ccaf1093ccf866adbd20d2f5ac
Author: Michael J Fork <email address hidden>
Date: Thu Mar 28 02:58:04 2013 +0000

Mark sql_connection with secret flag

sql_connection contains the password in some setups and marking as
secret prevents accidental logging

fixes bug 1160680

Change-Id: I3704237d0923bb30138b5ece7e5c7bbda0a78b9b
(cherry picked from commit 9f8ee9d2981c5f317139e3743385b59956546d65)

Gary Kotton (garyk) on 2013-04-22

tags:

added: in-stable-grizzly
removed: grizzly-backport-potential

Revision history for this message

Avishay Traeger (avishay-il) wrote on 2013-04-22: AUTO: Avishay Traeger is out of the office (returning 05/12/2013)

#20

I am out of the office until 05/12/2013.

For technical issues regarding the Storwize/SVC Cinder driver, please
contact: Jie Ping Wu <email address hidden>, Li Min Liu <email address hidden>,
Ronen Kat <email address hidden>
For all other issue, please contact my manager, Dalit Naor
<email address hidden>

Note: This is an automated response to your message "[Bug 1160680] Re:
sql_connection not marked secret" sent on 22/04/2013 20:23:41.

This is the only notification you will receive while this person is away.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-04-23: Fix merged to nova (stable/grizzly)

#21

Reviewed: https://review.openstack.org/26874
Committed: http://github.com/openstack/nova/commit/0f4c3f91cac93ce8444a9c65af80af9dc053d06f
Submitter: Jenkins
Branch: stable/grizzly

commit 0f4c3f91cac93ce8444a9c65af80af9dc053d06f
Author: Michael J Fork <email address hidden>
Date: Thu Mar 28 11:57:29 2013 +0000

sync oslo db/sqlalchemy module

sync oslo db/sqlalchemy module to grab "Mark sql_connection with secret
flag" change.

fixes bug 1160680

Change-Id: Id48419624c41eea5a0f2e130d7cdbe8a8f0a9118
(cherry picked from commit 6ff9c9effe011cb7d8d5479ec8cd2f6c7f61705c)

Thierry Carrez (ttx) on 2013-05-29

Changed in keystone:
milestone:	none → havana-1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-05-29

Changed in cinder:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-05-29

Changed in nova:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-05-29

Changed in quantum:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-05-30

Changed in oslo:
milestone:	none → havana-1
status:	Fix Committed → Fix Released

Alan Pevec (apevec) on 2013-08-06

tags:

removed: in-stable-grizzly

Thierry Carrez (ttx) on 2013-10-17

Changed in oslo:
milestone:	havana-1 → 2013.2

Thierry Carrez (ttx) on 2013-10-17

Changed in cinder:
milestone:	havana-1 → 2013.2

Thierry Carrez (ttx) on 2013-10-17

Changed in neutron:
milestone:	havana-1 → 2013.2

Thierry Carrez (ttx) on 2013-10-17

Changed in nova:
milestone:	havana-1 → 2013.2

Thierry Carrez (ttx) on 2013-10-17

Changed in keystone:
milestone:	havana-1 → 2013.2

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.