libindicator desktop shortcuts should create a GAppinfo from commandline
Bug #1168373 reported by
Marco Trevisan (Treviño)
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libindicator |
Fix Committed
|
Low
|
Marco Trevisan (Treviño) | ||
libindicator (Ubuntu) |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
Raring |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
Use of a hack to generate shortcuts instead of the dedicated function.
[Test Case]
Not known, the hack seems to work but is not optimal.
[Regression Potential]
The code affected is the generation of indicator shortcuts.
---
We currently generate the GAppInfo to launch the shortcuts using an hack by generating a fake .desktop key-file in memory and then building an AppInfo from it. This is not needed, since g_app_info_
Related branches
lp://qastaging/~3v1n0/libindicator/use-gappinfo-commandline
- PS Jenkins bot (community): Approve (continuous-integration)
- Ted Gould (community): Approve
-
Diff: 62 lines (+12/-24)1 file modifiedlibindicator/indicator-desktop-shortcuts.c (+12/-24)
lp://qastaging/~3v1n0/libindicator/use-gappinfo-commandline-13.04
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 62 lines (+12/-22)1 file modifiedlibindicator/indicator-desktop-shortcuts.c (+12/-22)
Changed in libindicator (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
description: | updated |
tags: |
added: verification-done removed: removal-candidate verification-needed |
To post a comment you must log in.
Fix committed into lp:libindicator at revision 491, scheduled for release in libindicator, milestone Unknown