zaqar

Create Queue with non ASCII name returns http 500

Bug #1208873 reported by Malini Kamalambal
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
High
Kurt Griffiths
zaqar havana-3 "h3"

Bug Description

Steps to repro:
Create a queue with non ASCII name
(or Run system test test_queue:TestQueue.test_008_insert_queue_nonASCII_name)

Expected Result:
marconi server will return 400

Actual Result:
marconi server returns 500

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to marconi (master)

Reviewed: https://review.openstack.org/38588
Committed: http://github.com/stackforge/marconi/commit/f1e71796b4a0436c2728e92c28979c5ca4d5d144
Submitter: Jenkins
Branch: master

commit f1e71796b4a0436c2728e92c28979c5ca4d5d144
Author: Zhihao Yuan <email address hidden>
Date: Thu Jul 25 02:36:57 2013 -0400

    feat(validation): validate user input

    The validation is implemented as a set of free-standing functions
    in a separated module; each driver which uses storage functions
    should call call the corresponding validation functions first.

    Fixes: bug #1177971
    Fixes: bug #1177976
    Fixes: bug #1177979
    Fixes: bug #1206175
    Fixes: bug #1208873

    Change-Id: I0b9c9766a9c3de42f2a2eb470cba0ab7265e669a

Changed in marconi:
status: New → Fix Committed
Flavio Percoco (flaper87)
Changed in marconi:
status: Fix Committed → Fix Released
Revision history for this message
Malini Kamalambal (malini-pk) wrote :

This bug is still open.
Please run the following functional test for a repro.

test_queues:TestInsertQueue.test_insert_queue_invalid_name

(NOTE: The failing test is currently skipped)

Changed in marconi:
status: Fix Released → Confirmed
Kurt Griffiths (kgriffs)
Changed in marconi:
importance: Undecided → High
milestone: none → icehouse-1
milestone: icehouse-1 → havana-3
status: Confirmed → Won't Fix
status: Won't Fix → Triaged
Flavio Percoco (flaper87)
Changed in marconi:
assignee: nobody → Flavio Percoco (flaper87)
Kurt Griffiths (kgriffs)
Changed in marconi:
assignee: Flavio Percoco (flaper87) → Kurt Griffiths (kgriffs)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to marconi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48776

Changed in marconi:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to marconi (master)

Reviewed: https://review.openstack.org/48776
Committed: http://github.com/openstack/marconi/commit/fa487de15e264798022c96de3caad1b272cfaea8
Submitter: Jenkins
Branch: master

commit fa487de15e264798022c96de3caad1b272cfaea8
Author: kgriffs <email address hidden>
Date: Fri Sep 27 23:13:46 2013 -0400

    fix(wsgi): Non-ASCII characters in the queue name trigger 500 status

    The problem was that queue_name wasn't being validated before being
    used to construct log messages. Also, I found that the regex used to
    validate queue names was not reliable and needed to be rewritten.

    Upon further investigation, I also discovered that the queue name
    wasn't being validated for all routes that included it. This was
    also fixed. Validating all input is a basic best practice re
    application security.

    Along the way, I edited the validation error messages for clarity,
    and relocated the ValidationFailed exception since it is only used
    by the transport driver.

    Change-Id: Idf9f6c7b9a88865a6396dfcd72abbce96c774490
    Closes-Bug: 1208873

Changed in marconi:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in marconi:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.