Ceilometer

import of rabbitMQ-specific config options regardless of configured RPC backend

Bug #1244698 reported by Eoghan Glynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
High
Eoghan Glynn
Ceilometer 2014.1 "icehouse"
Havana
Fix Released
High
Eoghan Glynn
Ceilometer 2013.2.1
oslo-incubator
Won't Fix
Undecided
Unassigned
oslo.messaging
Invalid
High
Mehdi Abaakouk

Bug Description

The RPC publisher queuing policy support involves importing the rabbit_max_retries config option from the ceilometer.openstack.common.rpc.impl_kombu module, regardless of the configured RPC backend.

This can cause the publisher loading to fail with an ImportError, if all the dependencies for ceilometer.openstack.common.rpc.impl_kombu are not installed locally.

For example:

2013-10-06 13:35:30.602 3988 TRACE stevedore.extension File ".../ceilometer/openstack/common/rpc/impl_kombu.py", line 26, in <module>
2013-10-06 13:35:30.602 3988 TRACE stevedore.extension import kombu
2013-10-06 13:35:30.602 3988 TRACE stevedore.extension ImportError: No module named kombu
2013-10-06 13:35:30.602 3988 TRACE stevedore.extension
2013-10-06 13:35:30.606 3988 ERROR ceilometer.pipeline [-] Unable to load publisher rpc://

This requirement unnecessary if the configured RPC backend is qpid or zmq.

Eoghan Glynn (eglynn)
Changed in ceilometer:
status: New → In Progress
assignee: nobody → Eoghan Glynn (eglynn)
tags: added: havana-backport-potential
Changed in ceilometer:
milestone: none → icehouse-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53889

OpenStack Infra (hudson-openstack)
Changed in ceilometer:
assignee: Eoghan Glynn (eglynn) → Sean Dague (sdague)
Julien Danjou (jdanjou)
Changed in ceilometer:
assignee: Sean Dague (sdague) → Eoghan Glynn (eglynn)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/53889
Committed: http://github.com/openstack/ceilometer/commit/a8e12c0429516d477b40eb7106c3b160a29c965a
Submitter: Jenkins
Branch: master

commit a8e12c0429516d477b40eb7106c3b160a29c965a
Author: Eoghan Glynn <email address hidden>
Date: Fri Oct 25 16:25:41 2013 +0100

    Selectively import RPC backend retry config

    Fixes bug 1244698

    When setting the RPC publisher policies, selectively import
    the retry config native to the configured RPC backend.

    This avoid ImportErrors when all the dependencies of an unused
    RPC backend are not installed locally.

    Change-Id: If05a5a389a1b417875e0426fd83fb6d73d570487

Changed in ceilometer:
status: In Progress → Fix Committed
Eoghan Glynn (eglynn)
Changed in ceilometer:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/57932

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/havana)

Reviewed: https://review.openstack.org/57932
Committed: http://github.com/openstack/ceilometer/commit/9f0a54a48481cc40494a67ac3355af1a76bb8e40
Submitter: Jenkins
Branch: stable/havana

commit 9f0a54a48481cc40494a67ac3355af1a76bb8e40
Author: Eoghan Glynn <email address hidden>
Date: Fri Oct 25 16:25:41 2013 +0100

    Selectively import RPC backend retry config

    Fixes bug 1244698

    When setting the RPC publisher policies, selectively import
    the retry config native to the configured RPC backend.

    This avoid ImportErrors when all the dependencies of an unused
    RPC backend are not installed locally.

    Change-Id: If05a5a389a1b417875e0426fd83fb6d73d570487
    (cherry picked from commit a8e12c0429516d477b40eb7106c3b160a29c965a)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

We are deprecating the rpc code in the incubator in favor of oslo.messaging, and I don't think this problem appears in oslo.messaging (reopen if it does, please).

Changed in oslo:
status: New → Triaged
status: Triaged → Won't Fix
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: havana-backport-potential
Revision history for this message
Mark McLoughlin (markmc) wrote :

For reference, this use of rabbit_max_retries came in via https://review.openstack.org/35604

We need to revisit this in the context of oslo.messaging - ceilometer should not be looking at rabbit specific config options

Changed in oslo.messaging:
status: New → Triaged
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77845

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-1 → 2014.1
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
assignee: nobody → Mehdi Abaakouk (sileht)
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

It's not clear if there's any work to be done in oslo.messaging for this. It seems like it was an application issue?

Changed in oslo.messaging:
status: Triaged → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/77845
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=b629e14111d825cb677c47f05c8946e83838660a
Submitter: Jenkins
Branch: master

commit b629e14111d825cb677c47f05c8946e83838660a
Author: Mehdi Abaakouk <email address hidden>
Date: Tue Mar 4 11:32:39 2014 +0100

    Use oslo.msg retry API in rpc publisher

    This patch removes the ceilometer hack around rabbitmq configuration
    to use the oslo.messaging API to retry rpc connection.

    Closes bug #1244698
    Co-Authored-By: Ala Rezmerita <email address hidden>

    Change-Id: I162f2ce7ba7f6644d995dfeef8b0ef5e2727c226

Doug Hellmann (doug-hellmann)
Changed in oslo.messaging:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.