Ubuntu
webbrowser-app package

Save/Restore state when app killed

Bug #1268056 reported by Michał Sawicz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Webapps-core project
Invalid
High
Unassigned
webbrowser-app
Fix Released
High
Olivier Tilloy
webbrowser-app ux-freeze
webbrowser-app (Ubuntu)
Fix Released
Medium
Olivier Tilloy

Bug Description

The browser should remember the previously open tabs between runs.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: webbrowser-app 0.22+14.04.20131107-0ubuntu1
Uname: Linux 3.4.0-3-mako armv7l
ApportVersion: 2.12.7-0ubuntu6
Architecture: armhf
Date: Sat Jan 11 01:23:48 2014
InstallationDate: Installed on 2014-01-10 (0 days ago)
InstallationMedia: Ubuntu Trusty Tahr (development branch) - armhf (20140110)
SourcePackage: webbrowser-app
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

lp://qastaging/~artmello/webbrowser-app/webbrowser-app-statesaver
Olivier Tilloy: Disapprove
PS Jenkins bot: Approve (continuous-integration)
Bill Filler (community): Needs Fixing
Diff: 180 lines (+31/-1)
9 files modified
src/app/webbrowser/Browser.qml (+7/-0)
src/app/webbrowser/webbrowser-app.cpp (+3/-0)
src/app/webbrowser/webbrowser-app.qml (+2/-0)
src/app/webcontainer/WebApp.qml (+2/-0)
src/app/webcontainer/WebViewImplOxide.qml (+4/-0)
src/app/webcontainer/WebViewImplWebkit.qml (+4/-0)
src/app/webcontainer/WebappContainerWebview.qml (+3/-1)
src/app/webcontainer/webapp-container.cpp (+4/-0)
src/app/webcontainer/webapp-container.qml (+2/-0)
lp://qastaging/~osomon/webbrowser-app/persist-open-tabs
PS Jenkins bot: Approve (continuous-integration)
Arthur Mello (community): Approve
Alexandre Abreu (community): Approve
Diff: 834 lines (+516/-18)
21 files modified
src/app/BrowserView.qml (+3/-0)
src/app/CMakeLists.txt (+1/-0)
src/app/browserapplication.cpp (+6/-0)
src/app/session-storage.cpp (+90/-0)
src/app/session-storage.h (+55/-0)
src/app/webbrowser/Browser.qml (+77/-0)
src/app/webbrowser/TabPreview.qml (+1/-0)
src/app/webbrowser/TabsView.qml (+1/-0)
src/app/webbrowser/tabs-model.cpp (+8/-0)
src/app/webbrowser/tabs-model.h (+1/-0)
src/app/webbrowser/webbrowser-app.cpp (+9/-10)
src/app/webbrowser/webbrowser-app.qml (+5/-5)
src/app/webcontainer/WebApp.qml (+55/-0)
src/app/webcontainer/webapp-container.cpp (+2/-0)
src/app/webcontainer/webapp-container.qml (+2/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+1/-1)
tests/autopilot/webbrowser_app/tests/__init__.py (+5/-2)
tests/autopilot/webbrowser_app/tests/test_session_save_restore.py (+54/-0)
tests/unittests/CMakeLists.txt (+1/-0)
tests/unittests/session-storage/CMakeLists.txt (+9/-0)
tests/unittests/session-storage/tst_SessionStorageTests.cpp (+130/-0)
lp://qastaging/ubuntu/utopic-proposed/webbrowser-app
Revision history for this message
Michał Sawicz (saviq) wrote :
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
Changed in webbrowser-app:
status: New → Triaged
importance: Undecided → Wishlist
Javier López (javier-lopez)
Changed in webbrowser-app (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Bill Filler (bfiller) wrote :

we should investigate using StateSaver for this especially when moving to the new design

Changed in webbrowser-app:
importance: Wishlist → Medium
Changed in webbrowser-app (Ubuntu):
importance: Wishlist → Medium
tags: added: rtm14
Revision history for this message
Bill Filler (bfiller) wrote :

Bumping up the priority here. In my testing, especially when running multiple webapps, the oom killer frequently kills the webapps and/or the browser if too many apps are open. We should minimally save/restore the url of the currently viewed page and use the StateSaver mechanism in the sdk to do so. Otherwise when you switch back to the app from the apps lens you are back at the starting page, which is quite annoying if you had previously navigated a few pages deep.

Step one should be save/restore url
Step two should be save/restore list of open tabs and remember currently visible tabs

Changed in webbrowser-app:
importance: Medium → High
assignee: nobody → Olivier Tilloy (osomon)
milestone: none → ux-freeze
Changed in webapps-core:
importance: Undecided → High
Revision history for this message
Bill Filler (bfiller) wrote :

Note, this needs to be done in the webapps-container as well as the webbrowser-app

summary: - Should preserve session (open tabs etc.)
+ Save/Restore state when app killed
Bill Filler (bfiller)
Changed in webbrowser-app:
assignee: Olivier Tilloy (osomon) → Arthur Mello (artmello)
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Triaged → In Progress
Víctor R. Ruiz (vrruiz)
tags: added: qa-daily-testing
removed: rtm14
Olivier Tilloy (osomon)
Changed in webbrowser-app:
assignee: Arthur Mello (artmello) → Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
status: Confirmed → In Progress
Changed in webapps-core:
status: New → Invalid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+14.10.20140812-0ubuntu1

---------------
webbrowser-app (0.23+14.10.20140812-0ubuntu1) utopic; urgency=low

  [ Olivier Tilloy ]
  * Save/restore browsing sessions for webbrowser-app and webapp-
    container. For now, only the list of currently open tabs (URLs) is
    persisted (current URL for the container), not the complete state
    for each webview. (LP: #1268056)
  * Fix a harmless warning that was issued when closing the last open
    tab.
 -- Ubuntu daily release <email address hidden> Tue, 12 Aug 2014 08:26:26 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.