database_list shows Percona system databases

Hey Doug,

this bug might be invalid.
You can hide DBs by tweaking the config. Just add the DBs that you want to ignore.
https://github.com/openstack/trove/blob/master/etc/trove/trove-guestagent.conf.sample#L56

Steve,

Thanks for the feedback - I guess I was thinking we would want to "ship" with these in the configuration?

And one other thing I noticed - the guest agent has some database excludes for mysql hardcoded in the query the gets the db list. (Around line 422 in guestagent/datastore/mysql/service.py)

Interesting. Now that you mentioned, this could be indeed a bug where list_database does not make use of ignore_dbs conf, but uses hard coded strings in the query.

The ignore_dbs conf is used in ValidatedMySQLDatabase to make sure that any action that create/delete/update any databases is not applied in any of these databases defined here.

Could you verify if adding 'performance_schema' and 'test' in the ingore_dbs conf prevents these DBs to appear when being listed?. If it doesnt, then you have a bug and should be fixed by using the conf.

Marking as incomplete until we get further info. Please reactivate based on findings if the bug still exists.

Thanks!

updated a patchset https://review.openstack.org/92176 to add performance_schema to ignore_dbs list

Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https://review.openstack.org/92176
Reason: Abandoning patches that have a negative review and are older than 4 weeks as part of a house-keeping sweep. Please feel free to restore the patch if it is still actively being worked on.