OpenStack DBaaS (Trove)

list_database in mysql/service.py does not uses ignore_dbs

Bug #1403822 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Committed
Low
Sushil Kumar
OpenStack DBaaS (Trove) kilo-rc1 "RC1"

Bug Description

list_database in mysql/service.py does not uses ignore_dbs.
Instead it uses a hard-coded value at
https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/service.py#L437-L440.

Sushil Kumar (sushil-kumar2)
Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142719

Changed in trove:
status: New → In Progress
Sushil Kumar (sushil-kumar2)
summary: - list_database does not uses ignore_dbs
+ list_database in mysql/service.py does not uses ignore_dbs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/142719
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=dafe5f73659599d2a153093eae48a1327475eede
Submitter: Jenkins
Branch: master

commit dafe5f73659599d2a153093eae48a1327475eede
Author: Sushil Kumar <email address hidden>
Date: Thu Dec 18 10:34:01 2014 +0000

    Corrects list_database query for MySQL

    Reasons:
    - query used in list_database for MySQL datastore uses a
      hard-coded where clause condition to filter schemas,
      instead of using the values from config variable ignore_dbs.

    Changes:
    - Removed the hard-coded where condition.
    - Updated where clause to use the ignore_dbs.
    - Updated unit tests to remove the older where clause matching.

    Change-Id: I59738e2874e7fd3801e2b0e90cbbb7035e922bd8
    Closes-Bug: #1403822

Changed in trove:
status: In Progress → Fix Committed
Nikhil Manchanda (slicknik)
Changed in trove:
milestone: none → kilo-rc1
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.