selectable aggregate list should be explicitly de-duped

Bug #1298514 reported by Eoghan Glynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
High
Eoghan Glynn

Bug Description

Repeated aggregate functions in a single statistics query are problematic.

For example, requesting count twice:

  GET /v2/meters/cpu_util/statistics?aggregate.func=count&aggregate.func=count

results in the count reported via the mongo driver being double the real value.

Worse, multiple references to cardinality results in a Nan being reported for the additional aggregate:

  GET /v2/meters/cpu_util/statistics?aggregate.func=cardinality&aggregate.param=project_id&aggregate.func=cardinality&aggregate.param=resource_id

   ... "aggregate": {"cardinality/project_id": 1.0, "cardinality/resource_id": NaN}

Instead the aggregate list should be de-deduped in the API layer, as is the groupby list currently.

Eoghan Glynn (eglynn)
Changed in ceilometer:
assignee: nobody → Eoghan Glynn (eglynn)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83511

Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/83511
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=ef2ccd39923e30af713fd5a63b5f3d2333d8bd13
Submitter: Jenkins
Branch: master

commit ef2ccd39923e30af713fd5a63b5f3d2333d8bd13
Author: Eoghan Glynn <email address hidden>
Date: Thu Mar 27 17:02:42 2014 +0000

    De-dupe selectable aggregate list in statistics API

    Fixes bug 1298514

    Discard full duplicates from the selectable aggregate list passed
    to the statistics API.

    Partial duplicates (i.e. matching func but different param) are
    now allowed and supported by the storage drivers.

    Change-Id: I5e2780befa9e265d5f1deb71b2aa375d05ca2e64

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.