Ubuntu
ofono package

[TOPBLOCKER] [krillin] Failure to unset flight mode

Bug #1388030 reported by Alfonso Sanchez-Beato
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ofono (Ubuntu)
Fix Released
High
Alfonso Sanchez-Beato
ofono (Ubuntu RTM)
Fix Released
Critical
Alfonso Sanchez-Beato

Bug Description

In some cases a failure that leaves ofono in an inconsistent state happens when unsetting flight mode. ofonod shows modem as "Online=1", but not all atoms are created.

See attached syslog that has output of ofono with "-d" option when this happened.

This has been also reported by QA as happening occasionally.

Related branches

lp://qastaging/~phablet-team/ofono/lp1388030
Alfonso Sanchez-Beato: Approve
Diff: 126 lines (+62/-1)
2 files modified
debian/changelog (+9/-0)
plugins/mtk.c (+53/-1)
lp://qastaging/~phablet-team/ofono/vivid-update-1
Alfonso Sanchez-Beato: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 3916 lines (+2429/-479)
35 files modified
Makefile.am (+4/-3)
debian/changelog (+16/-0)
doc/mtk-settings-api.txt (+49/-0)
drivers/mtkmodem/mtk_constants.h (+1/-0)
drivers/mtkmodem/mtkreply.c (+5/-6)
drivers/mtkmodem/mtkrequest.c (+11/-0)
drivers/mtkmodem/mtkrequest.h (+6/-0)
drivers/mtkmodem/mtksettings.c (+261/-0)
drivers/mtkmodem/mtksettings.h (+43/-0)
drivers/mtkmodem/mtkutil.c (+2/-0)
drivers/mtkmodem/mtkutil.h (+2/-0)
drivers/mtkmodem/radio-settings.c (+5/-3)
drivers/rilmodem/gprs.c (+18/-14)
drivers/rilmodem/network-registration.c (+2/-1)
drivers/rilmodem/phonebook.c (+1054/-0)
drivers/rilmodem/radio-settings.c (+8/-0)
drivers/rilmodem/rilmodem.c (+2/-0)
drivers/rilmodem/rilmodem.h (+3/-0)
drivers/rilmodem/sim.c (+73/-53)
gril/grilreply.c (+233/-173)
gril/grilreply.h (+7/-2)
gril/parcel.c (+35/-0)
gril/parcel.h (+7/-0)
include/sim.h (+23/-1)
plugins/mtk.c (+307/-109)
plugins/ril.c (+2/-62)
src/sim.c (+30/-2)
src/simfs.c (+107/-7)
src/simfs.h (+8/-5)
src/simutil.c (+2/-0)
src/simutil.h (+1/-0)
test/set-3g-slot (+20/-0)
unit/test-grilreply.c (+48/-34)
unit/test-mtkreply.c (+4/-4)
unit/test-mtkrequest.c (+30/-0)
lp://qastaging/ubuntu/vivid-proposed/ofono
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

This PR

https://github.com/rilmodem/ofono/pull/131

might solve the issue.

Alfonso Sanchez-Beato (alfonsosanchezbeato)
Changed in ofono (Ubuntu):
assignee: nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

This is one of the reasons for bug #1388065. Taking a look at the logs in that bug:

Oct 31 06:13:15 ubuntu-phablet ofonod[1936]: io_disconnect: disconnected from rild
Oct 31 06:13:16 ubuntu-phablet ofonod[1936]: mtk_send_sim_mode: failure sending request
Oct 31 06:13:16 ubuntu-phablet URfkill[9498]: <warning> Could not set Online property in oFono: GDBus.Error:org.ofono.Error.Failed: Operation failed

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

The modem gets unusable and the phone needs to be re-started when this happens, so marking as critical.

Changed in ofono (Ubuntu):
status: New → In Progress
tags: added: rtm14
Tony Espy (awe)
Changed in ofono (Ubuntu):
importance: Undecided → Critical
summary: - Failure to unset flight mode
+ [krillin] Failure to unset flight mode
Tony Espy (awe)
Changed in ofono (Ubuntu RTM):
importance: Undecided → Critical
assignee: nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato)
status: New → Fix Committed
Olli Ries (ories)
tags: added: touch-2014-11-06
summary: - [krillin] Failure to unset flight mode
+ [TOPBLOCKER] [krillin] Failure to unset flight mode
Tony Espy (awe)
Changed in ofono (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Tony Espy (awe) wrote :

FixedReleased via:

Releasing 1.12.bzr6882+14.10.20141103~rtm-0ubuntu1

Changed in ofono (Ubuntu RTM):
status: Fix Committed → Fix Released
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

This landed in RTM image #143

Olli Ries (ories)
Changed in ofono (Ubuntu):
importance: Critical → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ofono - 1.12.bzr6882+15.04.20141126-0ubuntu1

---------------
ofono (1.12.bzr6882+15.04.20141126-0ubuntu1) vivid; urgency=medium

  [ Alfonso Sanchez-Beato ]
  * grilreply.c, parcel.c, rilmodem: merge data and voice reg parsing
    This change splits the orginal parsing code for data and voice
    registration replies, cleaning up some of original parsing code
    which wasn't very elegant.
  * Makefile.am, rilmodem, src/sim*.*, include/sim.h,
    plugins/mtk.c, ril.c: enable SIM phonebook import support
  * rilmodem/sim.c, plugins/mtk.c, ril.c: fix SIM interface signals (LP: #1376250)
  * plugins/mtk.c: fix krillin slow socket disconnection (LP: #1388030)
  * Makefile.am, doc/mtk-settings-api.txt, mtkmodem,
    plugins/mtk.c, test, unit: support krillin 3g slot switch (LP: #1373388)
 -- Ubuntu daily release <email address hidden> Wed, 26 Nov 2014 01:44:00 +0000

Changed in ofono (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.