Ubuntu
command-not-found package

Remove empty lines from output

Bug #1875501 reported by Joshua Powers
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
command-not-found (Ubuntu)
Fix Released
Medium
Unassigned
Groovy
Fix Released
Medium
Unassigned

Bug Description

Can we please remove the extra white space before and after the command-not-found output? It is entirely unnecessary and inconsistent with nearly any other command. I recall having this discussion way back in Budapest, but I don't think it ever happened.

Current Result
---
$ vimx

Command 'vimx' not found, did you mean:

  command 'vim' from deb vim (2:8.1.2269-1ubuntu5)
  command 'vim' from deb vim-tiny (2:8.1.2269-1ubuntu5)
  command 'vim' from deb neovim (0.4.3-3)
  command 'vim' from deb vim-athena (2:8.1.2269-1ubuntu5)
  command 'vim' from deb vim-gtk3 (2:8.1.2269-1ubuntu5)
  command 'vim' from deb vim-nox (2:8.1.2269-1ubuntu5)

Try: sudo apt install <deb name>

$

Expected Result
---
$ vimx
Command 'vimx' not found, did you mean:

  command 'vim' from deb vim (2:8.1.2269-1ubuntu5)
  command 'vim' from deb vim-tiny (2:8.1.2269-1ubuntu5)
  command 'vim' from deb neovim (0.4.3-3)
  command 'vim' from deb vim-athena (2:8.1.2269-1ubuntu5)
  command 'vim' from deb vim-gtk3 (2:8.1.2269-1ubuntu5)
  command 'vim' from deb vim-nox (2:8.1.2269-1ubuntu5)

Try: sudo apt install <deb name>
$

$ lsb_release -rd
Description: Ubuntu 20.04 LTS
Release: 20.04

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, by white space you mean empty line right?

tags: added: champagne
Revision history for this message
Joshua Powers (powersj) wrote :

Yes, the empty line at the top and bottom of the output.

Sebastien Bacher (seb128)
summary: - Remove white space from output
+ Remove empty lines from output
Brian Murray (brian-murray)
Changed in command-not-found (Ubuntu):
importance: Undecided → Medium
Brian Murray (brian-murray)
summary: - Remove empty lines from output
+ Remove empty line from output
Revision history for this message
Dimitri John Ledkov (xnox) wrote : Re: Remove empty line from output

Personally, when scrolling the long terminal. I find it helpful that this weird output is delimited by new lines.

It makes it obvious that it is output from the OS / command-not-found, rather than the output from the command one has run.

Can we please have input from the design team on this? ie. mpt?

Changed in command-not-found (Ubuntu):
status: New → Incomplete
Brian Murray (brian-murray)
summary: - Remove empty line from output
+ Remove empty lines from output
Francis Ginther (fginther)
tags: added: id-5ebd60920daa22481b00c310
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

In visual design, I find it useful to follow a rule that spacing should reflect closeness of relationship. That is, less-related things should be at least as far apart as closer-related things.

How applicable that is to a CLI is debatable … But it would go against that rule to have blank lines within the output, but not surrounding the output.

So I think it would be fine to drop the initial and final blank lines, if you also dropped the other two blank lines.

(BTW, Incomplete is for reports that should expire if the missing info isn’t provided. That doesn’t apply here.)

Changed in command-not-found (Ubuntu Groovy):
status: Incomplete → New
Brian Murray (brian-murray)
tags: removed: champagne
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I am a convert, condensed output looks very fresh and light.

Changed in command-not-found (Ubuntu Groovy):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package command-not-found - 20.04.3

---------------
command-not-found (20.04.3) groovy; urgency=medium

  * Condense all output, drop all empty new lines. LP: #1875501

 -- Dimitri John Ledkov <email address hidden> Wed, 27 May 2020 10:50:21 +0100

Changed in command-not-found (Ubuntu Groovy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.