[sos39][networking] dpdk port flapping observed during sosreport execution
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
sosreport (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
High
|
Eric Desrochers | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned | ||
Groovy |
Fix Released
|
Undecided
|
Unassigned | ||
Hirsute |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[IMPACT]
sosreport networking plugin unconditionally exercise 'ethtool -e'.
EEPROM dump collection might hang on specific types of devices,
ETHTOOL(8)
-e --eeprom-dump
[TEST PLAN]
* On a xenial system
## Should not execute 'ethtool -e' (New default behaviour)
* sosreport -o networking
## Should execute 'ethtool -e'. (Only if sosreport is instructed to do so (AKA former default behaviour))
* sosreport -o networking --plugin-option networking.
## Should not execute 'ethtool -e' with -a (if with appropriate tunables in /etc/sos.conf)
---
[tunables]
networking.
---
## Should execute 'ethtool -e' with -a (if without appropriate tunables in /etc/sos.conf)
[WHERE PROBLEM OCCURS]
No problem expected.
networking plugin will be gated to prevent 'ethtool -e' to be run by default, so that 'sosreport -o networking' will now no longer execute 'ethtool -e' command.
On the other end, if one really want to eepromdump, one can use the 'eepromdump' plugin option as follows:
sosreport -o networking --plugin-option networking.
Yes, we are changing the default behaviour for good reasons as it may produce more harm than good the way it is at the moment, BUT the former behaviour is still available if *REALLY* needed, and after knowing the risk that this could occur.
Note:
sosreport -a ## Will still execute 'ethtool -e' as it turns all options to 'True'.
-a, --alloptions
Set all boolean options to True for all enabled plug-ins.
Unless one specify the following in /etc/sos.conf:
---
[tunables]
networking.
---
so 'sosreport -a' with a combination of adding the right tunables in /etc/sos.conf will prevent 'ethtool_e' to be executed.
[OTHER INFORMATION]
Upstream fix:
https:/
$ git describe --contains aca8bd83
4.1~44
$ rmadison sosreport
=> sosreport | 3.9.1-1ubuntu0.
sosreport | 4.1-1ubuntu0.
sosreport | 4.1-1ubuntu0.
sosreport | 4.1-1ubuntu0.
sosreport | 4.1-1ubuntu1 | hirsute
Changed in sosreport (Ubuntu): | |
status: | New → Fix Released |
Changed in sosreport (Ubuntu Xenial): | |
status: | New → In Progress |
assignee: | nobody → Eric Desrochers (slashd) |
importance: | Undecided → High |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
tags: | added: serg sts |
tags: |
added: seg removed: serg |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
summary: |
- [networking] dpdk port flapping observed during sosreport execution + [sos39][networking] dpdk port flapping observed during sosreport + execution |
Changed in sosreport (Ubuntu Xenial): | |
importance: | High → Critical |
description: | updated |
Changed in sosreport (Ubuntu Bionic): | |
status: | New → Fix Released |
Changed in sosreport (Ubuntu Focal): | |
status: | New → Fix Released |
Changed in sosreport (Ubuntu Groovy): | |
status: | New → Fix Released |
[XENIAL][PRE-SRU TESTING]
An impacted user did 'pre-SRU' testing. Here's what has been brought to my attention:
"
Thanks for the test package.
We tested it, and as per expectation, it is not executing ethtool -e and in turn not causing dpdk port flap.
Please let us know when can we have the official fix.
"
- Eric