[EHL][TGL][ADL][ICX] Enable Time Coordinated Compute interface driver

Bug #1929903 reported by Chao Qin
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
intel
Fix Released
Undecided
Brad Figg
Lookout-canyon-series
Fix Released
Undecided
Unassigned
linux-intel (Ubuntu)
Fix Released
Medium
Brad Figg
Focal
Fix Released
Undecided
Unassigned
linux-intel-5.13 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

Description
Time Coordinated Compute (TCC)
Pseudo SRAM interface support on top of Cache Allocation Technology

Hardware: Tiger Lake & Elkhart Lake & Alder Lake & Ice Lake

Target Release: 21.04
Target Kernel: TBD

External links:
https://github.com/intel/linux-intel-quilt/tree/mainline-tracking-v5.11-yocto-210223T083754Z

---

[Update, 2021-08-26]
Please find the Getting Started Guide for Intel TCC Tools here, has steps to download, install and verify:

https://software.intel.com/content/www/us/en/develop/documentation/get-started-with-tcc-tools-2021-2-ubuntu-yp-uefi/top.html

You can find the BIOS settings to enable TCC here:

https://software.intel.com/content/www/us/en/develop/documentation/get-started-with-tcc-tools-2021-2-ubuntu-yp-uefi/top/step-6-configure-intel-tcc-tools-in-bios.html

CVE References

Revision history for this message
Chao Qin (chaoqin) wrote :

Please find the following patches in the above external link

0001-tcc-parse-PTCT-table-and-record-pesudo-sram-ranges.tcc
0002-tcc-this-is-kernel-driver-to-interface-to-TCC-PTCM-pes.tcc
0003-tcc-update-license-header.tcc
0004-tcc-L3-psram-region-should-not-overlay-L2-psram-region.tcc
0005-tcc-driver-should-exit-if-no-psram-entry-found-in-PTCT.tcc
0006-tcc-tcc-drvier-should-not-exit-even-if-no-psram-entry.tcc
0007-tcc-return-error-code-to-better-match-varies-error-sce.tcc
0008-tcc-update-tcc-range-end_address.tcc
0009-tcc-l3-psram-region-size-could-become-zero-after-exclu.tcc

tags: added: lookout-canyon
no longer affects: linux (Ubuntu)
Changed in linux-intel (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Hsuan-Yu Lin (shanelin)
Changed in linux-intel (Ubuntu):
assignee: Hsuan-Yu Lin (shanelin) → nobody
Revision history for this message
Anthony Wong (anthonywong) wrote :

Copy from email:

> The patch list you provided at https://bugs.launchpad.net/ubuntu/+source/linux-intel/+bug/1929903/comments/1 is pretty short. Which kernel version is this patch list for, is it 5.11?

[Chao] Yes, the patches are based on our v5.11 kernel.

> From https://software.intel.com/content/www/us/en/develop/tools/time-coordinated-computing-tools.html, TCC seems to require real-time kernel, do we also need to implement real-time kernel for TCC?

[Chao] No, TCC driver is standalone and can works on platforms which enabled Cache Allocation Technology. And There are BIOS changes for TCC and user space tools, please @Sangal, Apoorv help on this.

description: updated
Brad Figg (brad-figg)
Changed in linux-intel (Ubuntu):
status: New → In Progress
Changed in intel:
status: New → In Progress
Changed in linux-intel (Ubuntu):
assignee: nobody → Brad Figg (brad-figg)
Changed in intel:
assignee: nobody → Brad Figg (brad-figg)
Revision history for this message
Brad Figg (brad-figg) wrote :

All patches mentioned in the description have been committed to focal:linux-intel intel-5.13-next.

Changed in linux-intel (Ubuntu):
status: In Progress → Fix Committed
Changed in intel:
status: In Progress → Fix Committed
Revision history for this message
Chao Qin (chaoqin) wrote :

v5.13 updates are as following

https://github.com/intel/linux-intel-quilt/tree/mainline-tracking-v5.13-yocto-210727T062416Z
0001-tcc-parse-PTCT-table-and-record-pesudo-sram-ranges.tcc
0002-tcc-this-is-kernel-driver-to-interface-to-TCC-PTCM-pes.tcc
0003-tcc-update-license-header.tcc
0004-tcc-L3-psram-region-should-not-overlay-L2-psram-region.tcc
0005-tcc-driver-should-exit-if-no-psram-entry-found-in-PTCT.tcc
0006-tcc-tcc-drvier-should-not-exit-even-if-no-psram-entry.tcc
0007-tcc-update-tcc-range-end_address.tcc
0008-tcc-return-error-code-to-better-match-varies-error-sce.tcc
0009-tcc-l3-psram-region-size-could-become-zero-after-exclu.tcc
0010-tcc-update-RTCT-table-parser-to-support-two-versions.tcc
0011-Enable-support-to-read-a-few-whitelisted-registers.tcc
0012-Remove-Clock_Cycles_VT-from-MHL-entry.tcc
0013-Add-new-IOCTL-to-read-error-log-buffer.tcc
0014-Display-errlog-buffer-raw-data-in-kernel-log-as-reques.tcc
0015-Fix-issue-found-in-acrn-uos-when-convert-cacheid-to-ap.tcc

Jesse Sung (wenchien)
information type: Private → Public
Jesse Sung (wenchien)
Changed in linux-intel-5.13 (Ubuntu Focal):
status: New → Fix Committed
Changed in linux-intel-5.13 (Ubuntu):
status: New → Invalid
Chao Qin (chaoqin)
tags: added: iotg-adl
description: updated
Chao Qin (chaoqin)
summary: - [EHL][TGL] Enable Time Coordinated Compute interface driver
+ [EHL][TGL][ADL] Enable Time Coordinated Compute interface driver
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Re: [EHL][TGL][ADL] Enable Time Coordinated Compute interface driver

This bug is awaiting verification that the linux-intel-5.13/5.13.0-1006.6 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (25.4 KiB)

This bug was fixed in the package linux-intel-5.13 - 5.13.0-1007.7

---------------
linux-intel-5.13 (5.13.0-1007.7) focal; urgency=medium

  * focal/linux-intel-5.13: 5.13.0-1007.7 -proposed tracker (LP: #1946503)

  * [iotg][tgl][tgl-aaeon] 20211006 image does not boot (LP: #1946223)
    - Revert CET patches

linux-intel-5.13 (5.13.0-1006.6) focal; urgency=medium

  * focal/linux-intel-5.13: 5.13.0-1006.6 -proposed tracker (LP: #1945669)

  * Packaging resync (LP: #1786013)
    - [Packaging] update variants

  * MEI (Intel Management Engine Interface) for sprint 2 (LP: #1945464)
    - Revert "mei: dal: add test module"
    - mei: backport fix from 5.12
    - Revert "UBUNTU: [Config] Disable INTEL_MEI_DAL and INTEL_MEI_VIRTIO"
    - [Config] Enable CONFIG_INTEL_MEI_DAL and CONFIG_INTEL_MEI_VIRTIO

  * [EHL] Intel ishtp VNIC driver (LP: #1943524)
    - net: Add support for Intel vnic driver
    - [Config] CONFIG_INTEL_ISHTP_VNIC=m

  * [EHL] Quadrature Encoder Peripheral support for sprint 2 (LP: #1945494)
    - counter: Add support for Intel Quadrature Encoder Peripheral
    - counter: intel-qep: Mark PM callbacks with __maybe_unused
    - counter: intel-qep: Use to_pci_dev() helper
    - [Config] CONFIG_INTEL_QEP=m

  * I225-IT Ethernet (8086:0d9f) does not work on AAEON's EHL Board
    (LP: #1945548)
    - igc: Remove _I_PHY_ID checking
    - igc: Remove phy->type checking

  * [EHL][TGL][ADL] Enable Time Coordinated Compute interface driver
    (LP: #1929903)
    - tcc: update RTCT table parser to support two versions
    - Enable support to read a few whitelisted registers.
    - Remove Clock_Cycles_VT from MHL entry.
    - Add new IOCTL to read error log buffer.
    - Display errlog buffer raw data in kernel log as requested once this driver
      is loaded.
    - Fix issue found in acrn uos when convert cacheid to apicid.

  * Integrated TSN controller for sprint 2 (LP: #1945461)
    - net: pcs: Introducing support for DWC xpcs Energy Efficient Ethernet
    - net: stmmac: Add callbacks for DWC xpcs Energy Efficient Ethernet
    - net: stmmac: enable platform specific safety features
    - net: phy: probe for C45 PHYs that return PHY ID of zero in C22 space
    - net: stmmac: Fix mixed enum type warning
    - net: stmmac: Fix unused values warnings
    - stmmac: intel: move definitions to dwmac-intel header file
    - stmmac: intel: fix wrong kernel-doc
    - stmmac: align RX buffers
    - net: stmmac: Fix mixed enum type
    - net: pcs: xpcs: delete shim definition for mdio_xpcs_get_ops()
    - net: pcs: xpcs: there is only one PHY ID
    - net: pcs: xpcs: make the checks related to the PHY interface mode
    - net: pcs: xpcs: export xpcs_validate
    - net: pcs: xpcs: export xpcs_config_eee
    - net: pcs: xpcs: export xpcs_probe
    - net: pcs: xpcs: use mdiobus_c45_addr in xpcs_{read,write}
    - net: pcs: xpcs: convert to mdio_device
    - net: pcs: xpcs: convert to phylink_pcs_ops
    - net: stmmac: split xPCS setup from mdio register
    - net: pcs: add 2500BASEX support for Intel mGbE controller
    - net: stmmac: enable Intel mGbE 2.5Gbps link speed
    - net: stmmac: fix NPD with phylink_set_pcs if there is no MDIO bus
    - n...

Changed in linux-intel-5.13 (Ubuntu Focal):
status: Fix Committed → Fix Released
Changed in linux-intel (Ubuntu Focal):
status: New → Fix Released
Changed in linux-intel (Ubuntu):
status: Fix Committed → Fix Released
Chao Qin (chaoqin)
description: updated
tags: added: iotg-ixc
summary: - [EHL][TGL][ADL] Enable Time Coordinated Compute interface driver
+ [EHL][TGL][ADL][ICX-D] Enable Time Coordinated Compute interface driver
tags: added: iotg-icx
removed: iotg-ixc
Chao Qin (chaoqin)
description: updated
summary: - [EHL][TGL][ADL][ICX-D] Enable Time Coordinated Compute interface driver
+ [EHL][TGL][ADL][ICX] Enable Time Coordinated Compute interface driver
information type: Public → Private
Ana Lasprilla (anamlt)
Changed in intel:
milestone: none → adl-iotg
Revision history for this message
Chao Qin (chaoqin) wrote :

v5.15 updates are as following

https://github.com/intel/linux-intel-quilt/tree/lts-v5.15.21-linux-220222T001242Z-1

0001-tcc-parse-PTCT-table-and-record-pesudo-sram-ranges.tcc
0002-tcc-this-is-kernel-driver-to-interface-to-TCC-PTCM-pes.tcc
0003-tcc-update-license-header.tcc
0004-tcc-L3-psram-region-should-not-overlay-L2-psram-region.tcc
0005-tcc-driver-should-exit-if-no-psram-entry-found-in-PTCT.tcc
0006-tcc-tcc-drvier-should-not-exit-even-if-no-psram-entry.tcc
0007-tcc-update-tcc-range-end_address.tcc
0008-tcc-return-error-code-to-better-match-varies-error-sce.tcc
0009-tcc-l3-psram-region-size-could-become-zero-after-exclu.tcc
0010-tcc-update-RTCT-table-parser-to-support-two-versions.tcc
0011-Enable-support-to-read-a-few-whitelisted-registers.tcc
0012-Remove-Clock_Cycles_VT-from-MHL-entry.tcc
0013-Add-new-IOCTL-to-read-error-log-buffer.tcc
0014-Display-errlog-buffer-raw-data-in-kernel-log-as-reques.tcc
0015-Fix-issue-found-in-acrn-uos-when-convert-cacheid-to-ap.tcc
0016-tcc-rounding-possible-non-page-aligned-ssram-address.tcc

Ana Lasprilla (anamlt)
Changed in intel:
status: Fix Committed → Fix Released
information type: Private → Public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.