Wrong events for ASUS L3000D

Bug #25784 reported by Jeroen van der Vegt
24
Affects Status Importance Assigned to Milestone
acpi-support (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

My laptop reports slightly different ACPI codes for the hotkeysthan those
reported in the events/asus_ scripts. Instead of 'hotkey ATKD 000000??', it
returns 'hotkey HOTK 000000??'. Manually changing this makes the hotkeys work
wonderfully. I'll attach a patch that changes the event files to look like this:

hotkey (ATKD|HOTK) 000000??

That should work make it work on more (all?) ASUS laptops.

Revision history for this message
Jeroen van der Vegt (ajvdvegt) wrote :

Created an attachment (id=4944)
Patch to make acpid recognise more ASUS hotkeys

The patch I promised. It's created using a subdirectory 'events_asus_new' next
to the 'events' directory, using 'diff -u'.

Revision history for this message
Carthik Sharma (carthik) wrote :

Has the provided patch been applied? Maybe this bug was fixed eventually. Can someone please close this bug if this is no longer an issue?

Thank you for reporting this bug.

Changed in acpi-support:
status: Unconfirmed → Needs Info
Revision history for this message
Jeroen van der Vegt (ajvdvegt) wrote :

No, the patch doesn't seem to be applied. I doubt it's fixed in another way, but I'll try to have a look these days.

Revision history for this message
Paweł Moll (pawel-moll) wrote :

I can confirm the problem for 6.06 using Asus A4H laptop. (ATKD)|(HOTK) solves the problem.

Additionally, this model uses slightly different hotkey code for wireless event - in place of "5d" it gives "52", so my asus-wireless file looks like this:

event=hotkey (ATKD)|(HOTK) 0000005[d2]
action=/etc/acpi/asus-wireless.sh

Revision history for this message
Paweł Moll (pawel-moll) wrote :

Sorry, I have misspelled... My laptop is Asus A2H (more precisely A2500H)

Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote :

I confirm that the patch is not applied in Ubuntu 6.06.
I've filled a new bug for the ASUS A2H/L and made a reference to
this report as the patch from Jeroen fixes the problem.
(I've applied the patch on my ASUS A2H)

Revision history for this message
DarkMageZ (darkmagez) wrote :

can someone confirm if this is still an issue in edgy.
does the patch apply cleanly & work in edgy?

Matthew Garrett, what do you think of the patch provided?

Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote :

I confirm that the problem still exist in Ubuntu edgy.

BTW, the patch only changes the name of the hotkeys to look for.
Nothing more as that's the only problem, one could also do:
cd /etc/acpi; sudo find ./events/ -name "asus*" -exec sed 's/ATKD/HOTK/g' -i {} \;

(It's what I've had done in Dapper and now again in Edgy)

stas@mobi:~$ cat /proc/version
Linux version 2.6.17-10-386 (root@vernadsky) (gcc version 4.1.2 20060928 (prerelease) (Ubuntu 4.1.1-13ubuntu5)) #2 Fri Oct 13 18:41:40 UTC 2006 (Ubuntu 2.6.17-10.33-386)

stas@mobi:~$ cat /proc/acpi/asus/info
Asus Laptop ACPI Extras Driver 0.30
Model reference : A2x
SFUN value : 0x0877
ASYM value : 0x0000
DSDT length : 14754
DSDT checksum : 155
DSDT revision : 1
OEM id : ASUS
OEM table id : A2H/L
OEM revision : 0x1000
ASL comp vendor id : MSFT
ASL comp revision : 0x100000e

Taken from /var/log/acpid before fixing the acpi-support problem.

[Sat Nov 4 07:12:41 2006] starting up
[Sat Nov 4 07:12:41 2006] 54 rules loaded

Hitting the volume down hotkey:
[Sat Nov 4 07:12:44 2006] client connected from 4116[108:108]
[Sat Nov 4 07:12:44 2006] 1 client rule loaded
[Sat Nov 4 07:13:34 2006] received event "hotkey HOTK 00000031 00000001"
[Sat Nov 4 07:13:34 2006] notifying client 4116[108:108]
[Sat Nov 4 07:13:34 2006] completed event "hotkey HOTK 00000031 00000001"

stas@mobi:~$ cat /etc/acpi/events/asus-volume-down
# /etc/acpi/events/asus-volume-down
# This is called when the user presses the volume down button and calls
# /etc/acpi/volume.sh for further processing.

event=hotkey ATKD 00000031
action=/etc/acpi/voldownbtn.sh

After changing the hotkey names:

stas@mobi:~$ cat /etc/acpi/events/asus-volume-down
# /etc/acpi/events/asus-volume-down
# This is called when the user presses the volume down button and calls
# /etc/acpi/volume.sh for further processing.

event=hotkey HOTK 00000031
action=/etc/acpi/voldownbtn.sh

Hitting the volume down hotkey:
[Sat Nov 4 07:39:44 2006] received event "hotkey HOTK 00000031 00000006"
[Sat Nov 4 07:39:44 2006] notifying client 4116[108:108]
[Sat Nov 4 07:39:44 2006] executing action "/etc/acpi/voldownbtn.sh"
[Sat Nov 4 07:39:44 2006] BEGIN HANDLER MESSAGES
[Sat Nov 4 07:39:44 2006] END HANDLER MESSAGES
[Sat Nov 4 07:39:44 2006] action exited with status 0
[Sat Nov 4 07:39:44 2006] completed event "hotkey HOTK 00000031 00000006"

Volume is going down, everything works as excpected.
Also the other hotkeys are working now.

Regards,
Stas

Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote :

And this bug exists also in feisty.

This is getting ridiculous.
The bug exists in three! releases while a solution is available since dapper.

Stas

Paul Sladen (sladen)
Changed in acpi-support:
assignee: mjg59 → sladen
Revision history for this message
Isaiah Gillis (isaiah-gillis) wrote :

I know this thread's been dead for a little while, but I was searching about and stumbled upon it in an attempt to fix this bug on my laptop.

Stas:
I tried the command "cd /etc/acpi; sudo find ./events/ -name "asus*" -exec sed 's/ATKD/HOTK/g' -i {} \;" and now none of my Fn + * hotkeys work nor the volume button on the side of my notebook. How do I undo this?
Thanks

Revision history for this message
Diego Caro (diegocaro) wrote :

I can confirm this bug, i solve changing the "event code".

For example, the event code for asus-media-play-pause is:
   event=hotkey.*45[[:space:]].*

:)

Bye

Revision history for this message
Jeroen van der Vegt (ajvdvegt) wrote :

I just performed a fresh install of Feisty Fawn, and this patch STILL hasn't been applied. I executed the code supplied by Stas in this comment above: https://bugs.launchpad.net/ubuntu/+source/acpi-support/+bug/25784/comments/8

It seems likely this bug will out-live the hardware I submitted it for :(

Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote :

I also noticed the bug wasn't fixed yet in Feisty when I did a number of upgrades :-(
And again I can confirm the bug is in Feisty and that the provided solution fixes it.
It seems we return to the good old days of hacking the software our selfs to get our hardware running.

I bet 5 Euro's that the bug out-lives Jeroens's laptop by 1 month and 2 weeks ;-)

Stas

Revision history for this message
Leonardo Prosperi (leo1981) wrote :

Is this bug in Gutsy too?

Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote : Re: [Bug 25784] Re: Wrong events for ASUS L3000D

On 9/27/07, Leonardo Prosperi <email address hidden> wrote:
> Is this bug in Gutsy too?
Yes.

> --
> Wrong events for ASUS L3000D
> https://bugs.launchpad.net/bugs/25784
> You received this bug notification because you are a direct subscriber
> of the bug.
>

--
A collection of educational activities for schools
http://www.schoolsplay.org

Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote :

Well it seems that this bug has out-lived my hardware :-(
My HD crashed and I had to reinstall Gutsy only to noticed that the bug is still present in Gutsy.
Can somebody explain to me why this bug isn't fixed?

Oh well, patching /etc/acpi/events again.

Revision history for this message
Daniel Hahler (blueyed) wrote :

I'm sorry that the (simple) patch has been ignored for so long, I'm cherry-picking it now.
Please expect the bug to be fixed for Hardy at least.

For your information:
Next time, please make sure that a bug is not marked incomplete if it isn't really.
Also, transforming a fix into a debdiff (http://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff) and submitting
it for review (http://wiki.ubuntu.com/SponsorshipProcess) will make it far more likely to get included.

Changed in acpi-support:
assignee: sladen → blueyed
status: Incomplete → In Progress
Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote :

On Feb 19, 2008 1:32 AM, Daniel Hahler <email address hidden> wrote:
> I'm sorry that the (simple) patch has been ignored for so long, I'm cherry-picking it now.
> Please expect the bug to be fixed for Hardy at least.
>
> For your information:
> Next time, please make sure that a bug is not marked incomplete if it isn't really.
> Also, transforming a fix into a debdiff (http://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff) and submitting
> it for review (http://wiki.ubuntu.com/SponsorshipProcess) will make it far more likely to get included.
Thanks for the explanation, I will do that the next time.

Stas

--
Free-source educational programs for schools
http://www.schoolsplay.org and http://wiki.laptop.org/go/Schoolsplay
http://gvr.sf.net and http://wiki.laptop.org/go/Guido_van_Robot

Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote :

On Tue, Feb 19, 2008 at 12:32 AM, Daniel Hahler <email address hidden> wrote:
> I'm sorry that the (simple) patch has been ignored for so long, I'm cherry-picking it now.
> Please expect the bug to be fixed for Hardy at least.
I'm just testing Hardy alpha 6 and this bug isn't fixed yet :-(
I'm hoping it will in a later Hardy release.

Stas

--
Free-source educational programs for schools
http://www.schoolsplay.org and http://wiki.laptop.org/go/Schoolsplay
http://gvr.sf.net and http://wiki.laptop.org/go/Guido_van_Robot

Revision history for this message
Daniel Hahler (blueyed) wrote :

The fix is attached to bug 193842.
You can try the test package from my ppa (https://edge.launchpad.net/~blueyed/+archive).
The sponsor bug has been finally assigned, so hopefully gets sorted out for Hardy.

Changed in acpi-support:
assignee: blueyed → nobody
status: In Progress → Triaged
Revision history for this message
Stas Zytkiewicz (stas-zytkiewicz) wrote :

On Thu, Mar 13, 2008 at 12:23 AM, Daniel Hahler <email address hidden> wrote:
> The fix is attached to bug 193842.
> You can try the test package from my ppa (https://edge.launchpad.net/~blueyed/+archive).
> The sponsor bug has been finally assigned, so hopefully gets sorted out for Hardy.
Fix is correct, let's hope Hardy finally closes this bug.

Stas

--
Free-source educational programs for schools
http://www.schoolsplay.org and http://wiki.laptop.org/go/Schoolsplay
http://gvr.sf.net and http://wiki.laptop.org/go/Guido_van_Robot

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package acpi-support - 0.106

---------------
acpi-support (0.106) hardy; urgency=low

  * Cherrypicked bugfix patches from Launchpad (LP: #193842)
  * lib/state-funcs: make wireless led work with asus-laptop (the new module);
    patch from Nicolò Chieffo (LP: #189889)
  * Add events/asus-video to support asus switch video hotkey; patch from
    Nicolò Chieffo (LP: #138228)
  * events/asus-wireless-2, asus-wireless-2.sh:
    Support Fn+F2 on Asus A8Js; patch from Matteo Collina (LP: #105929)
  * Fix the value range in sonybright.sh (0-7 instead of 1-8); patch from unggnu
    (LP: #136380)
  * "lib/FUJITSU SIEMENS.config":
    - Enable suspend for Fujitsu-Siemens C1110 (LP: #52970)
    - Enable STR for Fujitsu-Siemens Lifebook S7020, S7110
  * resume.d/50-time.sh, suspend.d/88-time.sh:
    Fix handling of hardware clock before/after suspend; patch from Rodrigo
    Novo (LP: #36815)
  * events/asus-*: Fix event key names for ASUS (HOTK); patch from
    Jeroen van der Vegt (LP: #25784)
  * Fix names in comments for events/panasonic-{mute,volume-down,volume-up}
  * debian/rules, README.toshiba: Drop toshiba_acpi.modprobe, which only
    contained an invalid/obsolete option "hotkeys_over_acpi" (LP: #180678)
  * debian/control: Standards-Version 3.7.3
  * Drop thinkpad_acpi.modprobe: the workarounds therein are not needed for
    thinkpad_acpi in Hardy anymore; investigations by Jerone Young (LP: #194679)
  * Add events/lenovo-eject to handle the Thinkpad eject button (Fn+F9); patch
    from Jerone Young (LP: #194609)

 -- Daniel Hahler <email address hidden> Thu, 06 Mar 2008 02:15:54 +0100

Changed in acpi-support:
status: Triaged → Fix Released
Revision history for this message
Daniel Hahler (blueyed) wrote :

As I've seen now, the patch matches some of the asus-event files, probably because they have been added, after this patch has been provided.
I'll fix them in the same way. Please raise an objection in case I'm wrong.

$ grep ATKD /etc/acpi/events/asus-* | grep -v HOTK
/etc/acpi/events/asus-a6u-touchpad:event=hotkey ATKD 0000006b
/etc/acpi/events/asus-brightness-down:event=hotkey ATKD 0000002[123456789abcdef]
/etc/acpi/events/asus-brightness-up:event=hotkey ATKD 0000001[123456789abcdef]
/etc/acpi/events/asus-media-eject:event=hotkey ATKD 0000004c
/etc/acpi/events/asus-touchpad:event=hotkey ATKD 0000006a
/etc/acpi/events/asus-video:event=hotkey ATKD 0000006[123]
/etc/acpi/events/asus-wireless:event=hotkey ATKD 0000005d
/etc/acpi/events/asus-wireless-2:event=hotkey ATKD 0000005[ef]

Changed in acpi-support:
status: Fix Released → Triaged
Revision history for this message
Bryce Harrington (bryce) wrote :

Fixed in Intrepid, in version 0.111

Changed in acpi-support:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.