Crash on renaming a title file

Changing the file name in the properties tab is only updating the file name within the project, it doesn't rename the file on disk (it's really intended for when you have moved a file and need to update the path), but I guess we should make that a bit clearer.

I would be much less concerned if changing the name in File properties would have done nothing, but crashing the app (even though it probably will not happen often) is annoying to the user.

I agree, a crash is not what most users would expect to be the result of
changing a file name. =)

On Sun, Jan 10, 2010 at 10:01 AM, ign
<<email address hidden><incom07%<email address hidden>>
> wrote:

> I would be much less concerned if changing the name in File properties
> would have done nothing, but crashing the app (even though it probably
> will not happen often) is annoying to the user.
>
> --
> Crash on renaming a title file
> https://bugs.launchpad.net/bugs/505390
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
>
> Status in OpenShot Video Editor: Confirmed
>
> Bug description:
> If a title file is renamed through File properties of the title, previewing
> it causes a segmentation fault.
>
> 1. Create a new project or open an existing one
> 2. Create a new title, add it to a track
> 3. Right click on the title in Project files tab, select File properties
> 4. Change the "File Name" (I kept the path and extension)
> 5. Click Apply, click Close
> 6. Right click on the title in Project files tab, select Preview
>
> Using OpenShot 1.0.0 on Ubuntu 8.04 32bit, installed from DEB (with
> dependencies) as instructed on project's Donwloads page.
>
> This is a minor inconvenience, but crashing the app may result in losing
> the unsaved changes.
>
> To developers: hope this will help to improve an amazingly well-designed
> and user-friendly application. I've been looking for an app like this for
> years, and OpenShot is the best among both commercial and open source video
> editing tools!
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help : https://help.launchpad.net/ListHelp
>

Here my path, prevent crash and show error message.
https://code.launchpad.net/~nagos/+junk/openshot-titles
this revision
http://bazaar.launchpad.net/~nagos/+junk/openshot-titles/revision/194

P.S. To rename/new_name dialog: mabe need openfile dialog to choice new file? It will update projet with existing file only.

Thanks for your help Vladimir! I will try and integrate your changes soon.
=)

On Mon, Jan 11, 2010 at 4:20 PM, Vladimir Yakovlev <email address hidden> wrote:

> Here my path, prevent crash and show error message.
> https://code.launchpad.net/~nagos/+junk/openshot-titles<https://code.launchpad.net/%7Enagos/+junk/openshot-titles>
> this revision
> http://bazaar.launchpad.net/~nagos/+junk/openshot-titles/revision/194<http://bazaar.launchpad.net/%7Enagos/+junk/openshot-titles/revision/194>
>
>
> P.S. To rename/new_name dialog: mabe need openfile dialog to choice new
> file? It will update projet with existing file only.
>
>
> ** Changed in: openshot
> Status: Confirmed => Fix Released
>
> --
> Crash on renaming a title file
> https://bugs.launchpad.net/bugs/505390
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
>
> Status in OpenShot Video Editor: Fix Released
>
> Bug description:
> If a title file is renamed through File properties of the title, previewing
> it causes a segmentation fault.
>
> 1. Create a new project or open an existing one
> 2. Create a new title, add it to a track
> 3. Right click on the title in Project files tab, select File properties
> 4. Change the "File Name" (I kept the path and extension)
> 5. Click Apply, click Close
> 6. Right click on the title in Project files tab, select Preview
>
> Using OpenShot 1.0.0 on Ubuntu 8.04 32bit, installed from DEB (with
> dependencies) as instructed on project's Donwloads page.
>
> This is a minor inconvenience, but crashing the app may result in losing
> the unsaved changes.
>
> To developers: hope this will help to improve an amazingly well-designed
> and user-friendly application. I've been looking for an app like this for
> years, and OpenShot is the best among both commercial and open source video
> editing tools!
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help : https://help.launchpad.net/ListHelp
>

The titles branch has already been merged into the trunk, and thus this fix should have also been merged.

I don't think this made it through the merge - the problem still seems to exist and I can't find the bug fix in the trunk.

Okay, this has been merged and committed to the trunk. However, I changed the error message, to use one that has already been translated. Thanks!