Patrons > Identification Type > (Sort order)

Bug #506689 reported by George Duimovich
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

EG 1.6

Minor issue but easy to fix...

In the Staff Client > Patron Editor > Primary Identification Type

Sort order needs to be by name. Current sort order appears to be by id / order in which types added rather than alpha by name.

Revision history for this message
Jason Etheridge (phasefx) wrote :

Related to this, some libraries will want to be able to choose a default type for patron registrations.

Revision history for this message
Dan Scott (denials) wrote :

So would the way to make everyone happy be:

1. Add an org_unit setting that lets administrators pick a default ID type for their library
2. Default the remainder of the list, or the entire list if no default ID type is set, to alphabetical order by name

Ideally the org_unit settings interface would learn how to pick from a list, rather than requiring admins to enter an integer. But that could be a follow-on enhancement.

Revision history for this message
Jason Etheridge (phasefx) wrote :

I'm not sure I understand #2. Tell me if this is the same thing: what I would expect is for the list to always be in alphabetical order, and the default selection to be the first entry, unless an org unit setting specifies an alternate entry, at which point that specific entry is pre-selected for new users, with the list remaining in alphabetical order.

Revision history for this message
Dan Scott (denials) wrote :

I think we're saying the same thing.

Given ID types with the overly short but easy to sort names A, B, C, and D, out of the box the list would be sorted:

A
B
C
D

... and the default selection would be "A".

If a library set the OU setting for preferred_patron_id_type (or whatever it ends up being called) to C, then the order would be:

C
A
B
D

... and the default selection would be "C".

I suppose an alternative in that case could be:

A
B
C
D

and the default selection would be "C", but... I dunno. I'm sure there's some HCI wisdom about whether one should default a user to the middle of a list (and user cursors up or down from there for alternatives) vs. default to the top (and user always cursors down from there to the alternatives). I tend towards putting the default at the top, but that's just me.

Revision history for this message
Jason Etheridge (phasefx) wrote :

Ah, I was thinking of the alternative you listed. I guess a 3rd option would be to duplicate entries in the list and do something like this:

C
--
A
B
C
D

and have the first entry always be selected.

Revision history for this message
George Duimovich (george-duimovich) wrote : RE: [Bug 506689] Re: Patrons > Identification Type > (Sort order)

I'm good with either of the suggested improvements.

george

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of
Jason Etheridge
Sent: January 12, 2010 22:14
To: Duimovich, George
Subject: [Bug 506689] Re: Patrons > Identification Type > (Sort order)

Ah, I was thinking of the alternative you listed. I guess a 3rd option
would be to duplicate entries in the list and do something like this:

C
--
A
B
C
D

and have the first entry always be selected.

--
Patrons > Identification Type > (Sort order)
https://bugs.launchpad.net/bugs/506689
You received this bug notification because you are a direct subscriber
of the bug.

Status in Evergreen - Open ILS: New

Bug description:
EG 1.6

Minor issue but easy to fix...

In the Staff Client > Patron Editor > Primary Identification Type

Sort order needs to be by name. Current sort order appears to be by id
/ order in which types added rather than alpha by name.

To unsubscribe from this bug, go to:
https://bugs.launchpad.net/evergreen/+bug/506689/+subscribe

James Fournie (jfournie)
Changed in evergreen:
status: New → In Progress
importance: Undecided → Low
status: In Progress → Confirmed
Revision history for this message
Jason Stephenson (jstephenson) wrote :

No one has reported this on more recent releases. The version is reported for is no longer supported.

Changed in evergreen:
status: Confirmed → Won't Fix
Revision history for this message
Michael Peters (mrpeters) wrote :

Not so fast, I'd say. It still happens in master.

NSERT INTO config.identification_type (name) VALUES ('Bill');

See it appears at the bottom of the list, instead of the top.

In this same interface, may be we can peek at Statistical Categories. Their entries intuitively display in alpha order. I think that's the behavior we want in cases where we have non-default ident types.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Setting back to confirmed, thanks Mike.

Leaving it at Low, unless someone thinks it should be wishlist?

Changed in evergreen:
status: Won't Fix → Confirmed
Revision history for this message
George Duimovich (george-duimovich) wrote :

Still the same in 2.2. 0

Not a big deal but for any list > 4 entries would be nice to have alpha sort.

Wishlist - imho all drop down lists should default to alphabetical by label/name unless there's a reason otherwise.

Changed in evergreen:
importance: Low → Wishlist
Ben Shum (bshum)
tags: added: bitesize
Changed in evergreen:
status: Confirmed → In Progress
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Just noticed that no link to tsbere's fix for this issue was added to this ticket.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/sort_ident_type

mrpeters was working on fixing this with commendary on IRC back on 2014-11-19 and 2014-11-20.
http://irc.evergreen-ils.org/evergreen/2014-11-19
http://irc.evergreen-ils.org/evergreen/2014-11-20

Josh

Changed in evergreen:
status: In Progress → Confirmed
Remington Steed (rjs7)
tags: added: pullrequest
Kate Butler (kreb)
Changed in evergreen:
assignee: nobody → Kate Butler (kreb)
Revision history for this message
Remington Steed (rjs7) wrote :

For the record, I tested Thomas's sort_ident_type branch mentioned in #11, and it worked as expected. If needed, I can provide a sign-off branch.

Revision history for this message
Kate Butler (kreb) wrote :

I did not get to finish testing this at the bug squashing day, so if you can do a signoff, Remington, that would be great. I've taken myself off.

Changed in evergreen:
assignee: Kate Butler (kreb) → nobody
Revision history for this message
Remington Steed (rjs7) wrote :
tags: added: signedoff
Remington Steed (rjs7)
Changed in evergreen:
milestone: none → 2.next
Kathy Lussier (klussier)
Changed in evergreen:
milestone: 2.next → 2.12-beta
Revision history for this message
Mike Rylander (mrylander) wrote :

Picked to master. Not backporting, though, as the patron reg interface that was changed is going away soon-ish.

Changed in evergreen:
assignee: nobody → Mike Rylander (mrylander)
assignee: Mike Rylander (mrylander) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.