stats-report doesn't do a good job of error reporting

Bug #612722 reported by gholt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Low
Greg Lange

Bug Description

stats-report, when things are going wrong, doesn't do a good job of helping track down the problem. For instance, 404s and 507s are completely muted with no options to reenable them. It be nice to be able to run in a debug-mode to tell which devices are 404/507ing.

Revision history for this message
Andrew Clay Shafer (littleidea) wrote :

I'm looking at the stats-report and considering refactoring it.

I'm new to Python, but I don't see any tests for this executable.

If you have an opinion about how this should work or be made better, let me know. (or any tips on testing python)

Revision history for this message
gholt (gholt) wrote :

You're right, there are no tests currently for that. Actually, there are no tests for anything in the bin directory. Once we got around to testing stuff like that, we put the code-to-test into a package in the main swift dir and then just had the bin file call that code. If you were to add tests I would go the same route and just be sure to use the standard python unittest framework [copy one of the test/unit files and modify away].

Revision history for this message
Andrew Clay Shafer (littleidea) wrote :

@gholt

Ok, I'll muck around and see what I come up with.

Is there dev mailing list or something where people review patches and discuss design?

Would anyone be opposed to my merging the configurations from the options and the config file into the same data structure to collapse parameters out of some of the functions?

Revision history for this message
gholt (gholt) wrote :

There's a mailing list on the https://launchpad.net/~swift page, but I think most folks have been using IRC so far.

Combine conf and options at will!

Changed in swift:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8248

Changed in swift:
status: Confirmed → In Progress
Thierry Carrez (ttx)
Changed in swift:
assignee: nobody → Greg Lange (greglange)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/8248
Committed: http://github.com/openstack/swift/commit/27455cb15bc29b19953d6d47aad669a7b246f97b
Submitter: Jenkins
Branch: master

commit 27455cb15bc29b19953d6d47aad669a7b246f97b
Author: Greg Lange <email address hidden>
Date: Wed Jun 6 19:57:04 2012 +0000

    added printing of 404s to dispersion report; fixed small, unrelated bug

    also fixed bug where in error_log where identifier wasn't being set to anything meaningful, set it to the right thing

    bug 612722

    Change-Id: I53f237ea0db2a5b2b8979a7b41189faf1275e861

Changed in swift:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in swift:
milestone: none → 1.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.