128 characters limit on tags

Bug #894874 reported by Bug Importer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ares
Fix Released
Medium
DCoder DCoder

Bug Description

Tags have a 128 character limit, this generally doesn't affect most ini tags but it can limit the AI Controls, the PadAircraft or AnimToInfantry tags etc.

Tags: limit tags
Revision history for this message
pd (pdmail) wrote :

Confirmed.

This is indeed a problem for the things you named, and one thing you forgot to mention: Owners.

I don't even think this will need any further discussion, this will be worked on.

Revision history for this message
Nighthawk (nighthawk) wrote :

I noticed this issue hasn't been touched in a while, and I ran into this problem earlier today with the Owner tag. Any update on its progress?

Revision history for this message
DCoder DCoder (dcoder1337) wrote :

It is fairly simple to do, so I can implement it quickly someday.

Revision history for this message
DCoder DCoder (dcoder1337) wrote :

Expanded to 2048 chars for:

[General]
AmerParaDropInf
AllyParaDropInf
SovParaDropInf
YuriParaDropInf
AmerParaDropNum
AllyParaDropNum
SovParaDropNum
YuriParaDropNum
AnimToInfantry
SecretInfantry
SecretUnits
SecretBuildings
HarvesterUnit
BaseUnit
PadAircraft
Shipyard
RepairBay
WeatherConClouds
WeatherConBolts
BridgeExplosions
DefaultMirageDisguises

[CombatDamage]
Scorches
Scorches1
Scorches2
Scorches3
Scorches4
SplashList

[AI]
BuildConst
BuildPower
BuildRefinery
BuildBarracks
BuildTech
BuildWeapons
AlliedBaseDefenses
SovietBaseDefenses
ThirdBaseDefenses
BuildDefense
BuildPDefense
BuildAA
BuildHelipad
BuildRadar
ConcreteWalls
NSGates
EWGates
BuildNavalYard
BuildDummy
NeutralTechBuildings

[Country]
VeteranInfantry
VeteranUnits
VeteranAircraft

[TechnoType]
ForbiddenHouses
SecretHouses
RequiredHouses
Owner
DamageParticleSystems
DestroyParticleSystems
Prerequisite

[Warhead]
AnimList

Landing in SVN tonight, not tested yet. Let me know if I missed any flags.

Note that this list doesn't include changed/added flags such as [GenericPrerequisites] which are now set to 2048 as well. One glaring omission is PrerequisiteOverride, which I will do tomorrow, and map actions/events which I'll do this week as well.

Revision history for this message
Bug Importer (bug-importer) wrote :

Code related to this issue has just been checked in; DCoder wrote in revision 233:
Lots of changes. Wheeee. Refactored all applicable things to use the new INI parsers. Etc.

#633 - Changed to use HouseClass indices, refactored some code into template. (Will post the missing sections for transcription tomorrow.)
#662 - Improvements in lag handling, but still unusable.
#423 - Significant progress towards saving/loading right.
#462 - Should fix the parasite slots.

Resolved issue #628 - crash on exit.
Resolved issue #658 - Cancel buildable Conyard IE.
Resolved issue #653 - PowerToggle IE on empty ground.
Resolved issue #472 - WarpAway deglobalized again.
Resolved issue #189 - Customizing Electro death animation.
Resolved issue #367 - Mind control parasites should now be moving in sync with the host, so the link will not draw back to the original capture point.
Resolved issue #193 - 128 characters limit on tags - added map action/event/trigger support.
Related to issue 633,662,628,658,653,472,189,367,423,462,193 .
SVN: http://svn.renegadeprojects.com/listing.php?repname=Ares&path=%2Ftrunk%2F&rev=233&sc=1

Revision history for this message
Renegade (renegade) wrote :

Setting to resolved as per rev. 233 commit message, mirrored above.

Revision history for this message
DCoder DCoder (dcoder1337) wrote :

Closing these issues - implemented a fair while ago, tested during implementation. If any bugs do crop up, be sure to thank the lazy testers for doing their job so well.

Revision history for this message
cranium (cranium) wrote :

Dock= seems to have the 128 character limit still

using this list here:
Dock=GAAIRC,AMRADR,GDIRADAR,GDIRADARCLONE,YURIHELIPAD,YURIHELIPADCLONE,NODRADAR,NODRADARCLONE,ALLIEDAIRSTRIPCLONE,GDIAIRSTRIPCLONE,NODAIRSTRIPCLONE,YURIAIRSTRIPCLONE
It gets cut off at
Dock=GAAIRC,AMRADR,GDIRADAR,GDIRADARCLONE,YURIHELIPAD,YURIHELIPADCLONE,NODRADAR,NODRADARCLONE,ALLIEDAIRSTRIPCLONE,GDIAIRSTRIPCLONE,N

resulting in a [BuildingType] **=N after performing a Data Dump

Attached a debug .log to show results

[Edit] I checked all other tags I thought would have an issue with this. They all checked out O.K. So from my knowledge its only Dock= that has the limitation.

Revision history for this message
Bug Importer (bug-importer) wrote :

Code related to this issue has just been checked in!
Author: DCoder
Location: various-fixes, r1072
Commit contains DLL: Yes
Revision comment:
Related to issue #193 - added Dock parsing, rewrote all existing parsers to not use junk macros, removed said junk macros.
SVN: http://svn.renegadeprojects.com/Ares/1072

Revision history for this message
DCoder DCoder (dcoder1337) wrote :

Your turn, testers.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

Do every single tag need retesting or will it be enough by testing a few(like 5-10)?

Revision history for this message
cranium (cranium) wrote :

Dock= limit of 128 has been resolved. Thanks:)

Revision history for this message
Rogan (pdrogan) wrote :

Copy and pasted cranium's dock list (sorry...) onto the harrier.

Obviously, it gave dev errors stating that the game failed to parse the new entries.
However, there were no cut-off entries in sight.

This issue is now fixed.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

Tested:
Owner=
RequiredHouses=
BuildNavalYard
SovietBaseDefenses
They worked.

Revision history for this message
DCoder DCoder (dcoder1337) wrote :

Nobody has reported any more problems with this for ages - closing fixed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.