Cannot remove journal when using manged disk on XenServer

Bug #931743 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Rick Harris

Bug Description

Occasionally we'll see this error https://paste.slicehost.com/show/6090/.

This seems to result from the system not getting a chance to cleanly unmount the FS, so when it goes to rebuild it still has journal entries that need to be replayed.

Since we're removing the journal before it gets a chance to replay these entries, it complains.

The solution is to fsck the disk before removing the journal.

Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4088

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/4088
Committed: http://github.com/openstack/nova/commit/d8a2bda822662f3ebc25f8e92d03ae1cf0676be8
Submitter: Jenkins
Branch: master

commit d8a2bda822662f3ebc25f8e92d03ae1cf0676be8
Author: Rick Harris <email address hidden>
Date: Mon Feb 13 16:11:17 2012 -0600

    Fsck disk before removing journal

    Fixes bug 931743

    Change-Id: Ibf257ca74432f8e6387ffae58f6b38477de59272

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4257

Changed in nova:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/4257
Committed: http://github.com/openstack/nova/commit/8497435226aa65bb69abdb68a1d6cc94be7966e9
Submitter: Jenkins
Branch: master

commit 8497435226aa65bb69abdb68a1d6cc94be7966e9
Author: Rick Harris <email address hidden>
Date: Thu Feb 16 22:52:54 2012 +0000

    Adds back e2fsck exit code checking.

    References bug 931743

    Change-Id: Id9e71b722e2a3b18821bceffdf138ba3895cfcf1

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.