Comment 2 for bug 165293

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 165293] Re: collisions through uploading same-named .pack files not handled correctly

On Tue, 2007-11-27 at 23:30 +0000, John A Meinel wrote:
> Are we assuming that if there is a name conflict then the packs are
> identical?

No. The existing pack could be corrupt (io error in the past), or
malicious (collision, or deliberately something that doesn't match the
md5sum as its name).

> Or do we also need to grab at least the indexes and make sure that they
> have identical data.

We should check the pack and the indices. The indices may vary because
we haven't solved the 'indices must be regeneratable' bug yet.

The
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.