BzrTools

  1. Bug #296620
  2. Comment #4

Comment 4 for bug 296620

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 296620] Re: shelf_ui import bzrtools even when --no-plugins is required

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> This approach makes it *harder* to fix bug 296125, because if any plugin
> can supply shelf_ui.diff_writer, there's no way to know whether it
> produces colourized output.
>

Why not change the DiffWriter interface to include:
"allow_colored=True/False".

Or alternatively, have the disable code just unilaterally disable the
non-native diff_writer. For the common case that a plugin is providing
colordiff, then it will have disabled coloring. For other cases, we
don't have to provide another option to disable whatever wackyness that
plugin provides.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkaKYsACgkQJdeBCYSNAAPWLACgwKB91RlhfkkEpHGGM2xqVD8I
UFkAniSUumjroB0fmmP60CGcAjF8BOlY
=WJAK
-----END PGP SIGNATURE-----