Comment 1 for bug 1664435

Revision history for this message
Billy Olsen (billy-olsen) wrote :

I'm marking this as Medium because the logic doesn't work and therefore the timeout never triggers (thankfully). I think the error conditions need to be rethought in this path and what constitutes a viable timeout (or if one even makes sense). On many machines, if a restart is required for any reason during this code path then the reboot alone could take upwards of 10 minutes. If the upgrade path goes to Jewel from Hammer then upgrading the permissions on the OSDs in a production cluster is known to take longer (I've seen 40-60 minutes or more per OSD).

The bug that prevents the timeout from triggering can easily be fixed by casting the value read in from the keystore to a float, however I think it is a bad idea to fix that part.