Comment 2 for bug 896431

Revision history for this message
Mark Mims (mark-mims) wrote :

Hi Jonathan, thanks for the moosefs charms!

This charm is in the review queue because of the 'new-charm' tag.

Couple of review notes:

- please provide a base level readme that explains the basics of how to set up the master, chunks, metalogger, and clients.

- please cryptographically verify downloads. There're several different ways to do this depending if the downloads are hashed by the upstream provider or if you have to hash them yourself. The repo lp:charm-tools has some utils to help with this process.

- it looks like the relation hooks aren't fleshed out yet. Please let me know if I can help out... (m_3 on the freenode channel #juju). The channel's pretty active during Europe and US East-coast hours.

I'll mark this as 'in progress' for now... please change the status to 'fix committed' when ready for another review.

Thanks,
Mark