Comment 2 for bug 1509267

Revision history for this message
David Ames (thedac) wrote :

James,

Thanks for reporting this bug and going above and beyond to propose solutions to it!

I have merged your nova-compute MP as this is the correct solution to Bug #1509267. The bug is now set to Fix committed.

I am however going to reject the charm-helpers MP. We use PACKAGE_CODENAMES OPENSTACK_CODENAMES for different types of of versions strings. OPENSTACK_CODENAMES has versions like '2015.2' where PACKAGE_CODNAMES has versions like '12.0.0'. The code in charmhelpers.contrib.openstack.utils.get_os_codename_package is checkgin for both types of version string. The proposed solution confuses the two and is not general enough for all situations.