command-not-found

  1. Bug #880616
  2. Comment #3

Comment 3 for bug 880616

Revision history for this message
Zygmunt Krynicki (zyga) wrote : Re: Add an option to install the package right away ( + draft patch )

Would you mind proposing the patch as a merge request. It can be reviewed easier there.

I have some comments on the patch itself, don't use os.system, it's a hole for exploits. Use subprocess.call() with shell=False (the default). Other than that we need to ensure that just pressing enter will _NOT_ install the package.

I was thinking about adding a apt-cache summary of the package that you'd install. We'd need to see how this looks like in practice.