Comment 7 for bug 2004463

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

The regression in https://github.com/epics-base/epics-base/pull/274 is the change from

> int quote, inword, backslash;

to

> bool inword = false;
> bool backslash = false;
> char quote = EOF;

Which in retrospect is an issue because the EOF macro is meant to be stored/compared with 'int' (eg. with 'getc()' and friends).

> 3. use 0 instead of EOF
>
> I prefer solution 3. ...

I agree.