I just went down the rabbithole on this issue. Working branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1017990-deprecate-hold-create - it removes the open-ils.circ.holds.create[.override] and batch methods and calls the create_hold subroutine directly. It passes the live Perl tests. I got ambitious here, so criticism is welcome!
I just went down the rabbithole on this issue. Working branch here: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ csharp/ lp1017990- deprecate- hold-create - it removes the open-ils. circ.holds. create[ .override] and batch methods and calls the create_hold subroutine directly. It passes the live Perl tests. I got ambitious here, so criticism is welcome!